tree 24cb19c72d09119368d1ce1c9fa9002f506078e3
parent 524d72b36dad6ece7e389b709d5081976de42630
author Ralf W. Grosse-Kunstleve <rwgkio@gmail.com> 1774842567 +0700
committer GitHub <noreply@github.com> 1774842567 -0700
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsFcBAABCAAQBQJpyfLHCRC1aQ7uu5UhlAAAqMgQAGgcJzp3YTTvPWTHcJBccDUI
 L+g2hwSXNapcmNAsvRlKumnuZN2vYLoS1i7fogKXgMuVkeZRmgDlECtQolln+pQ9
 FpGgzY5gXC912vPIkSSYvqa2dAObvMwHfPDOxbMesCji9iPMMrMGrGk6Z8dLMVDr
 BI2bP5OxLJT1qEESOHXkseK7ZmxeUGrdX/jG87Jez0PFv5V4awIUSZ/zofrdIu9d
 8IhXfNVS/voHBc/42ag79Bi6qXy6aWPYGrvAswCXangwmfvhSVeU+alksk186Oyb
 8T/oS4dAnNrVeoMhNO2FDZ5i65Gosy/ii3UQf/EToHkAHZ/V2v7CiRdWsKxiRuuD
 Na+Rgby9WS2WrjsRbJk7WfFBvX/lsl9883gmXwUZNreM+YsmwLe96ZikNqlQf6N9
 Jj0w41G4KZgM1WGkM/l13houuBTYJlHfZidGALbRWTWZggVulD5DWOMJrUy5v/NG
 +s9KRy/8Sn91XdDPxhkxOWPby9Yhsk+Ned8bpAEFLz/uSVMNxevwUOzczPgZ35h2
 JIC9oxnJINOQJb4mdgHSICPk124dgMZbYQFYbSoF6sQU0Qk0aMNN6x5vXoJNTJoa
 5zZThoe0/TyrHCD9PgM1VnQgn9sdir2I3SNWylOQiS0xkRAYPq/Sb4BW4Kvn4tTM
 Al92TqEMnwj4N7I+vxvc
 =pmLm
 -----END PGP SIGNATURE-----
 

fix: detect virtual inheritance in add_base to prevent pointer offset crash (#6017)

Virtual inheritance places the base subobject at a dynamic offset, but
load_impl Case 2a uses reinterpret_cast which assumes a fixed offset.
This caused segfaults when dispatching inherited methods through virtual
bases (e.g. SftVirtDerived2::name()).

Add an is_static_downcastable SFINAE trait that detects whether
static_cast<Derived*>(Base*) is valid. When it is not (virtual
inheritance), set multiple_inheritance = true in add_base to force the
implicit_casts path, which correctly adjusts pointers at runtime.

Remove the workaround .def("name", &SftVirtDerived2::name) from
test_smart_ptr.cpp that was papering over the issue.

Made-with: Cursor