tree 513839dd7cf686f044de86af0a19352fb022ffc9
parent 95ebcb3643d4573425aa78a042496a133fb322a3
author Henry Schreiner <HenrySchreinerIII@gmail.com> 1785159675 -0400
committer GitHub <noreply@github.com> 1785159675 -0400
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsFcBAABCAAQBQJqZ1/7CRC1aQ7uu5UhlAAA7ygQAC1IYgrWPznRNLaDlT8Ztl9y
 mwfjEZwl+t6ayftiOuE7HZMD8k3R7/GU2SaNsMz0wirWuvLjAlIee4zGja/k8xhZ
 8fSz8qq21bqrNXx/PWaAKZQhlKVXYZ+OsKeYAkISnFhSM81MYqKCob1hJKit5Au/
 YG8yg/zYUK1MljEANFinPeTv6qUlG+N2G0b4vCbYw+5/CCCmo1PCac1jMYCkYM+X
 vJLcD8A8Q4dJDenrKtU5f8De/JdzsxGE9KwmnoPG/uboYYuhjCvYhD7f9dwt3Sau
 9l6vUBCLyZ8mc9kCDbZCYy1EVwG3eYEdyHjw7Du45RmdlithtXfYu+sqV/47L0ya
 K0Sz/oKtFloWTv18yA7LwMZ9Q/kGTP26sujY6iVXrlSHoLSN9bUr40Fli3rLn+ZM
 I8OOu06LFr2IIPUES3N3zkIHls76UYfZMLzEw684WewOFVirRulES/uEBOJuyGQj
 E+TBMqn1jBFYk3DWW+SVK/CCZCarW+ty6U9ueZxMqh6Hb1FPEyRdQMcYxQDGKjIM
 HoR+1b6sd2wk+pc8TqloK9Tptw4GUJhjhEwuY2RwGe1J+sAylq+c4NoFOzW8ArlN
 /SyIa0AKLsuhKq+cjWr+AMNdAbYKeuguzVs4Oev4qXHQMZ9xt8ML8wg6b5PMvB3x
 YriOezDgSkuEIIMet8qS
 =nFdh
 -----END PGP SIGNATURE-----
 

fix(cmake): respect explicit PYBIND11_USE_CROSSCOMPILING under CMP0190 (#6094)

* fix(cmake): respect explicit PYBIND11_USE_CROSSCOMPILING under CMP0190

PR #5829 added `AND NOT DEFINED CMAKE_CROSSCOMPILING_EMULATOR` to the
condition setting `_PYBIND11_CROSSCOMPILING`. That gate was meant to only
control the auto-default of `PYBIND11_USE_CROSSCOMPILING`, but it ended up
overriding a value the project set explicitly. Emscripten/Pyodide defines
`CMAKE_CROSSCOMPILING_EMULATOR` (node) yet still wants cross-compiling
mode, so the flag was forced OFF and the build failed with a spurious
"Cannot run the interpreter" / pointer-size mismatch.

Move the emulator check up so it only guards the auto-default, and never
override an explicitly set `PYBIND11_USE_CROSSCOMPILING`.

Fixes #6043

Assisted-by: ClaudeCode:claude-opus-4.8

* fix(cmake): keep CMP0190 auto-default in add_subdirectory builds

The previous commit's `NOT DEFINED PYBIND11_USE_CROSSCOMPILING` guard
broke the intended auto-default for top-level / add_subdirectory builds:
CMakeLists.txt runs `option(PYBIND11_USE_CROSSCOMPILING ... OFF)` before
including pybind11Common.cmake, so the variable is already defined (OFF)
and the CMP0190 default never applied.

Capture, before the option() call, whether the project set the value
itself, and let pybind11Common.cmake apply its default unless the value
was set explicitly. This keeps both the emulator override fix and the
CMP0190 auto-default for subdirectory consumers.

Assisted-by: ClaudeCode:claude-opus-4.8