tree f325d00db600240808a1f0d6d538cbf1e7275e9c
parent 7fb54e306516b51bf0760ab210a1c2730271fed4
author Thomas Köppe <tkoeppe@google.com> 1757357561 +0100
committer GitHub <noreply@github.com> 1757357561 -0700
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsFcBAABCAAQBQJovyX5CRC1aQ7uu5UhlAAAYKoQAAXnhoDw+isL/LKTziz8PqFt
 7aMC6Imwt2Vco+WpCGAnk1M0Uum0oobtnniG+VXj0eQrYN3WeiFpQ/KJf+fOSS+f
 sBAGTQ2XgLwPExM2AA0jmWc0dnVeurRP5cw/0VK7ciEGrj7HBMVtfbtfs3wo6V+H
 LE2ZLN25/bZNFhljdKoRXZjHRhLRuSbuc5I9j4QCUZ+VeHIZCSURSZRKONEKGH6r
 pFMok8u9eJVJJQE54msoLN5vHsqz1KHkVp+imVcGMFiL+/QC9zsa8t9QXYJnag0l
 sFZR/HBjfR68Bm4kbthbXWpf7W+QYGtgJuDpC7jtymYCai17autd5NMf9BGtTvcD
 sWmtlFbGC0Z6dkAdbv1sRh3hB7YSEh6p4IJJrObCRi2TD/HcEz/yVc1rPUFq0Ly9
 dPEDedaLK9TxPjUkDLT8a4FoTqE4BhB0J9/tw9B1HYVJlSs9nX8w0YRzwFbrLD9b
 DuMg4gzuywKuA0zq6GxSWfmZT8M7Zbe/A4bXTTDcNdrZx9D16xoFPRk296KNUTcw
 zKJl82pyysEFDGcRnWwPlyfRY/BE/XY2EpafnLNCgzk31/HYjgyA99KxPuuswpqC
 z529sosAakb39ZcHXBmjsVuATu3/NQcxEmz/ODgf4df5fR4mBqsmPPMhRNc5byB9
 uvxK4HYjNuQjsDgbbjSe
 =11pU
 -----END PGP SIGNATURE-----
 

pytypes.h: constrain accessor::operator= templates so that they do not obscure special members (#5832)

* pytypes.h: constrain accessor::operator= templates so that they do not match calls that should use the special member functions.

Found by an experimental, new clang-tidy check. While we may not know the exact design decisions now, it seems unlikely that the special members were deliberately meant to not be selected (for otherwise they could have been defined differently to make this clear). Rather, it seems like an oversight that the operator templates win in overload resolution, and we should restore the intended resolution.

* Use C++11-compatible facilities

* Use C++11-compatible facilities

* style: pre-commit fixes

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>