roll: third_party/pigweed/src ecf027d..2091e07 (32 commits)

2091e07:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/342652 roll: luci
5e1b45a:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/342532 roll: fuchsia-infra-bazel-rules 20fc84c..ba0f59b (56 commits)
a79606e:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/340412 roll: python-wheel
e0849ec:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/342272 pw_kernel: Standardize logging
9c0904e:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/342052 pw_log: Fix doc comment
a69ab7a:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/341293 pw_async2: Channel BlockingSend and BlockingReceive
0c8beb6:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/341732 pw_digital_io: Fix docs typo, capitalization
d397899:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/342032 docs: Fix RSS URLs
b07381c:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/341492 pw_bluetooth_sapphire: Fix spec reference in comment
891adf6:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/341633 pw_async2: Avoid races when popping futures
c6e8f66:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/341152 pw_bluetooth_sapphire: Update Fuchsia SDK
895e442:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/341292 pw_async2: Replace OneshotCallbackTask with FutureCallbackTask
f77b536:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/340535 pw_async2: Remove RunUntilStalled() task arg; move code to Task
2d36d82:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/341552 uart_mcuxpresso/interrupt_safe: Acquire clock element dynamically
77ed350:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/337793 docs: Debugging relative paths in C++ toolchains (blog post)
d54a08c:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/341112 size_report: Delete GN builds for size reports
849c9b6:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/340734 pw_kernel: Add a `nop` syscall
77fa72e:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/341332 pw_async2: Add missing tests to GN test group; fix shadowing errors
910cdc4:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/341212 pw_tokenizer: Take uint8 array or string instead of frame
0741a19:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/340992 pw_spi_mcuxpresso: Implement proper fix for fsl_spi_dma v2.2.2
1f42b7b:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/340754 pw_async2: Fix missing mutex include
c1358d7:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/340656 cpp23: Replace std::aligned_storage_t
b4f5bfa:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/277732 pw_tokenizer: Add support for nested detokenization in TypeScript
7fbe42b:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/339592 pw_snapshot: Add xtensa to CPU arch enum
4302888:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/340575 pw_snapshot: Don't assume unknown CPU arch is arm
12e8c1a:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/340634 pw_async2: Move futures out of experimental
5beaa3e:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/339792 pw_async2: Remove task execution mutex
51107a5:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/340433 pw_bluetooth_sapphire: Remove uncalled function cached_scan_results
c3435af:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/340534 pw_async2: Move DoDestroy out of the base Task class
fc42b65:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/340572 presubmit: Fix formatting of C++ files
8021817:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/340533 targets/rp2040: Replace use of deprecated pw::SystemStart function
cc7ce71:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/340432 roll: fuchsia-infra-bazel-rules, MODULE.bazel.lock

Rolled-Repo: https://pigweed.googlesource.com/pigweed/pigweed
Rolled-Commits: ecf027d02d7347..2091e07c81910a
Roll-Count: 1
Roller-URL: https://cr-buildbucket.appspot.com/build/8698631945781305425
GitWatcher: ignore
CQ-Do-Not-Cancel-Tryjobs: true
Change-Id: I1da824976bf82170344d9ac7ac887d27bbd5111e
Reviewed-on: https://pigweed-review.googlesource.com/c/open-dice/+/342872
Commit-Queue: Pigweed Roller <pigweed-roller@pigweed-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Pigweed Roller <pigweed-roller@pigweed-service-accounts.iam.gserviceaccount.com>
Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com>
1 file changed
tree: b19ae8e7b58e641b8aa7694b227d020bbec97afe
  1. build_overrides/
  2. docs/
  3. dpe-rs/
  4. images/
  5. include/
  6. src/
  7. third_party/
  8. toolchains/
  9. tools/
  10. .clang-format
  11. .gitignore
  12. .gitmodules
  13. .gn
  14. banner.txt
  15. bootstrap.sh
  16. BUILD.gn
  17. BUILDCONFIG.gn
  18. generate_test_values.py
  19. LICENSE
  20. navbar.md
  21. OWNERS
  22. pigweed.json
  23. pyproject.toml
  24. README.md
  25. run_fuzzer.sh
  26. rustfmt.toml
README.md

Open Profile for DICE

This repository contains the specification for the Open Profile for DICE along with production-quality code. This profile is a specialization of the Hardware Requirements for a Device Identifier Composition Engine and DICE Layering Architecture specifications published by the Trusted Computing Group (TCG). For readers already familiar with those specs, notable distinctives of this profile include:

  • Separate CDIs for attestation and sealing use cases
  • Categorized inputs, including values related to verified boot
  • Certified UDS values
  • X.509 or CBOR certificates

Mailing List

You can find us (and join us!) at https://groups.google.com/g/open-profile-for-dice. We're happy to answer questions and discuss proposed changes or features.

Specification

The specification can be found here. It is versioned using a major.minor scheme. Compatibility is maintained across minor versions but not necessarily across major versions.

Code

Production quality, portable C code is included. The main code is in dice.h and dice.c. Cryptographic and certificate generation operations are injected via a set of callbacks. Multiple implementations of these operations are provided, all equally acceptable. Integrators should choose just one of these, or write their own.

Tests are included for all code and the build files in this repository can be used to build and run these tests.

Disclaimer: This is not an officially supported Google product.

Thirdparty Dependencies

Different implementations use different third party libraries. The third_party directory contains build files and git submodules for each of these. The submodules must be initialized once after cloning the repo, using git submodule update --init, and updated after pulling commits that roll the submodules using git submodule update.

Building and Running Tests

Quick setup

To setup the build environment the first time:

$ git submodule update --init --recursive
$ source bootstrap.sh
$ gn gen out

To build and run tests:

$ ninja -C out

More details

The easiest way, and currently the only supported way, to build and run tests is from a Pigweed environment on Linux. Pigweed does support other host platforms so it shouldn't be too hard to get this running on Windows for example, but we use Linux.

There are two scripts to help set this up:

  • bootstrap.sh will initialize submodules, bootstrap a Pigweed environment, and generate build files. This can take some time and may download on the order of 1GB of dependencies so the normal workflow is to just do this once.

  • activate.sh quickly reactivates an environment that has been previously bootstrapped.

These scripts must be sourced into the current session: source activate.sh.

In the environment, from the base directory of the dice-profile checkout, run ninja -C out to build everything and run all tests. You can also run pw watch which will build, run tests, and continue to watch for changes.

This will build and run tests on the host using the clang toolchain. Pigweed makes it easy to configure other targets and toolchains. See toolchains/BUILD.gn and the Pigweed documentation.

Porting

The code is designed to be portable and should work with a variety of modern toolchains and in a variety of environments. The main code in dice.h and dice.c is C99; it uses uint8_t, size_t, and memcpy from the C standard library. The various ops implementations are as portable as their dependencies (often not C99 but still very portable). Notably, this code uses designated initializers for readability. This is a feature available in C since C99 but missing from C++ until C++20 where it appears in a stricter form.

Style

The Google C++ Style Guide is used. A .clang-format file is provided for convenience.

Incorporating

To incorporate the code into another project, there are a few options:

  • Copy only the necessary code. For example:

    1. Take the main code as is: include/dice/dice.h, src/dice.c

    2. Choose an implementation for crypto and certificate generation or choose to write your own. If you choose the boringssl implementation, for example, take include/dice/utils.h, include/dice/boringssl_ops.h, src/utils.c, and src/boringssl_ops.c. Taking a look at the library targets in BUILD.gn may be helpful.

  • Add this repository as a git submodule and integrate into the project build, optionally using the gn library targets provided.

  • Integrate into a project already using Pigweed using the gn build files provided.

Size Reports

The build reports code size using Bloaty McBloatface via the pw_bloat Pigweed module. There are two reports generated:

  • Library sizes - This report includes just the library code in this repository. It shows the baseline DICE code with no ops selected, and it shows the delta introduced by choosing various ops implementations. This report does not include the size of the third party dependencies.

  • Executable sizes - This report includes sizes for the library code in this repository plus all dependencies linked into a simple main function which makes a single DICE call with all-zero input. It shows the baseline DICE code with no ops (and therefore no dependencies other than libc), and it shows the delta introduced by choosing various ops implementations. This report does include the size of the third party dependencies. Note that rows specialized from ‘Boringssl Ops’ use that as a baseline for sizing.

The reports will be in the build output, but you can also find the reports in .txt files in the build output. For example, cat out/host_optimized/gen/*.txt | less will display all reports.

Thread Safety

This code does not itself use mutable global variables, or any other type of shared data structure so there is no thread-safety concerns. However, additional care is needed to ensure dependencies are configured to be thread-safe. For example, the current boringssl configuration defines OPENSSL_NO_THREADS_CORRUPT_MEMORY_AND_LEAK_SECRETS_IF_THREADED, and that would need to be changed before running in a threaded environment.

Clearing Sensitive Data

This code makes a reasonable effort to clear memory holding sensitive data. This may help with a broader strategy to clear sensitive data but it is not sufficient on its own. Here are a few things to consider.

  • The caller of this code is responsible for buffers they own (of course).
  • The ops implementations need to clear any copies they make of sensitive data. Both boringssl and mbedtls attempt to zeroize but this may need additional care to integrate correctly. For example, boringssl skips optimization prevention when OPENSSL_NO_ASM is defined (and it is currently defined).
  • Sensitive data may remain in cache.
  • Sensitive data may have been swapped out.
  • Sensitive data may be included in a crash dump.