| commit | 5021907cac62a46bfa861ba19b5f04208af40323 | [log] [tgz] |
|---|---|---|
| author | pigweed-roller <pigweed-roller@pigweed-service-accounts.iam.gserviceaccount.com> | Mon Nov 18 00:45:32 2024 +0000 |
| committer | CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Nov 18 00:45:32 2024 +0000 |
| tree | 06b3af98f4b755da8a54359a8d89074aa74216ac | |
| parent | c2f2b64d025e5c9b5350b8ae78bc31eee447e7cd [diff] |
roll: third_party/pigweed/src 39dbc59..aeecb42 (69 commits) aeecb42:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/246732 pw_bluetooth_proxy: Prepare for BR/EDR ACL credit support 0959346:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/249653 roll: fuchsia-infra-bazel-rules c97cd7f..a627dc1 (40 commits) b4a75fd:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/248493 pw_bluetooth_proxy: Remove LDAP from TODOs 7a46cb5:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/246736 pw_bluetooth_proxy: Move+copy constructors for channels 6360c3b:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/246500 pw_bluetooth: Delete AttNotifyOverAcl a88df25:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/246499 pw_bluetooth_proxy: Increase H4 buffer size 53d5391:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/237263 pw_bluetooth_proxy: Support queueing + L2CAP credits 11ca404:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/249312 docs: Update changelog f3d2187:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/248713 pw_bluetooth_proxy: Reintroduce std::lock_guard 144c028:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/249432 pw_protobuf: Set minimum and maximum edition fields in plugin 81b8314:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/245592 docs: Configure docs_build to support emboss & sapphire 4dda096:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/249352 OWNERS: Apply WORKSPACE_OWNERS to MODULE.bazel* 92e854a:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/249414 pw_rpc: Warn when client completion callback is disabled c064969:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/249413 pw_rpc: Simplify enabling packet debug logs 786f3bc:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/249512 pw_elf: Add pw_stream to Android.bp d55664c:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/249332 pw_bluetooth_proxy: Update Android.bp ae1e16c:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/249032 pw_log_tokenized: Pass module instead of using PW_LOG_MODULE_NAME 40d4c12:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/249092 pw_bluetooth: Fix RFCOMM information length off by one 5b5c781:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/237261 pw_bluetooth_proxy: Add L2capChannelManager 9e4f2b9:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/237260 pw_bluetooth_proxy: Handle fragmented L2CAP frames 462929d:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/249132 pw_env_setup: PyPI version bump to 0.0.20 9698390:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/248332 pw_bluetooth_sapphire: Update BT inspect selectors aacf94e:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/244332 pw_metric: Expose metric token format via PW_METRIC_TOKEN 44b5368:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/249054 pw_tokenizer: Add missing dependencies in Android.bp 3ba4bfd:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/249053 pw_elf: Add Android.bp c3abd51:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/249052 pw_tokenizer: Remove unnecessary dep on pw_log f0ba9b0:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/245067 pw_rpc: Allocate more call IDs in the Python client a1acd00:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/248692 SEED-0001: Add "Intent Approved" and "On Hold" states to lifecycle 6165aa4:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/245754 pw_i2c: Set the i2c flags correctly for transactions on an i3c bus b7246bf:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/248195 pw_sensor: Add freeform extras field to sensor.yaml 21933c6:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/248638 pw_async2: Accept alignment in CoroPromiseType::operator new 5b608da:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/248637 pw_build: Restore layering_check workaround for pw_facade ef6ae0d:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/234930 pw_string: Stringify time types b6de265:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/245216 pw_bluetooth_sapphire: Add BoringSSL to size report 65d0b8c:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/248712 pw_elf: Fix reference to data file 81d18d1:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/239506 pw_bluetooth_sapphire: Create size report c9ad96c:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/227371 pw_bluetooth: Add LE Connection-Oriented Channels API acbeaab:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/248432 pw_protobuf: Extend Find() APIs to support repeated fields b8ee89e:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/232172 pw_bluetooth_proxy: L2CAP CoC supports reading bd6248b:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/248652 pw_bluetooth_proxy: Remove uses of auto 5ecdeb1:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/248672 pw_elf: Simplify ReaderExample 7fb7bb1:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/248232 pw_tokenizer: Update regex for nested args 7f24718:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/248077 pw_bluetooth: Simplify emboss RFCOMM extended length case a89e457:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/248292 pw_bluetooth_sapphire: Remove emboss-specific control packet names 2077854:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/248174 pw_bluetooth_sapphire: Remove EventPacket e51890c:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/248392 pw_protobuf_compiler: Nanopb 3 bazel build fix b9b9135:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/248312 pw_bluetooth: Format emboss files 94e2314:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/243532 pw_tokenizer: Add Detokenizer::FromElfFile 8ee7879:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/244893 pw_elf: Add ElfReader a020d35:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/248381 pw_protobuf_compiler: Specify flags for generate_proto.py 6aadd54:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/236236 pw_spi: Finalize non-Virtual interface on Initiator a703dc3:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/244892 pw_elf: Create new module a30e972:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/248173 pw_bluetooth_sapphire: Use EmbossEventPacket in CommandChannel c5d3d97:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/245113 clang-tidy: Make [[deprecated]] a warning instead of error c99ca8a:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/248194 pw_presubmit: Accept clang-*: in commit messages for clang-tidy/-format ab5df2c:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/248193 pw_system: Remove backwards compatibility overload of SystemStart() d20009a:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/243818 pw_async2: Add PW_TRY_READY_* control flow macros d38811b:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/247993 docs: Build target docs with Bazel a3184cd:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/248233 many: Reduce use of `includes` f662898:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/248272 pw_rpc_transport: Remove more stray includes 5f398c0:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/248172 pw_bluetooth_sapphire: Remove unused template 0422de1:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/247732 pw_channel: Rework inheritance to avoid SiblingCast c521eec:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/248234 pw_rpc_transport: Remove stray includes a615b8b:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/219393 pw_bluetooth: Modernize APIs 5516467:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/248212 docs: Build SEED docs with Bazel a7362ec:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/248027 pw_bluetooth: Add RFCOMM emboss definitions 447364e:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/246713 pw_bluetooth_sapphire: Add FIDL path for opening L2CAP channels dea7775:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/247872 pw_toolchain: Add migration shim for legacy GCC toolchain rules e4fe3eb:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/248054 roll: go Rolled-Repo: https://pigweed.googlesource.com/pigweed/pigweed Rolled-Commits: 39dbc59552835f..aeecb42c9905da Roll-Count: 1 Roller-URL: https://cr-buildbucket.appspot.com/build/8730975062998356689 GitWatcher: ignore CQ-Do-Not-Cancel-Tryjobs: true Change-Id: I41cfbac1246dec113e356860f09537d70e377ad1 Reviewed-on: https://pigweed-review.googlesource.com/c/open-dice/+/249673 Commit-Queue: Pigweed Roller <pigweed-roller@pigweed-service-accounts.iam.gserviceaccount.com> Bot-Commit: Pigweed Roller <pigweed-roller@pigweed-service-accounts.iam.gserviceaccount.com> Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com>
This repository contains the specification for the Open Profile for DICE along with production-quality code. This profile is a specialization of the Hardware Requirements for a Device Identifier Composition Engine and DICE Layering Architecture specifications published by the Trusted Computing Group (TCG). For readers already familiar with those specs, notable distinctives of this profile include:
You can find us (and join us!) at https://groups.google.com/g/open-profile-for-dice. We're happy to answer questions and discuss proposed changes or features.
The specification can be found here. It is versioned using a major.minor scheme. Compatibility is maintained across minor versions but not necessarily across major versions.
Production quality, portable C code is included. The main code is in dice.h and dice.c. Cryptographic and certificate generation operations are injected via a set of callbacks. Multiple implementations of these operations are provided, all equally acceptable. Integrators should choose just one of these, or write their own.
Tests are included for all code and the build files in this repository can be used to build and run these tests.
Disclaimer: This is not an officially supported Google product.
Different implementations use different third party libraries. The third_party directory contains build files and git submodules for each of these. The submodules must be initialized once after cloning the repo, using git submodule update --init, and updated after pulling commits that roll the submodules using git submodule update.
To setup the build environment the first time:
$ git submodule update --init $ source bootstrap.sh $ gn gen out
To build and run tests:
$ ninja -C out
The easiest way, and currently the only supported way, to build and run tests is from a Pigweed environment on Linux. Pigweed does support other host platforms so it shouldn't be too hard to get this running on Windows for example, but we use Linux.
There are two scripts to help set this up:
bootstrap.sh will initialize submodules, bootstrap a Pigweed environment, and generate build files. This can take some time and may download on the order of 1GB of dependencies so the normal workflow is to just do this once.
activate.sh quickly reactivates an environment that has been previously bootstrapped.
These scripts must be sourced into the current session: source activate.sh.
In the environment, from the base directory of the dice-profile checkout, run ninja -C out to build everything and run all tests. You can also run pw watch which will build, run tests, and continue to watch for changes.
This will build and run tests on the host using the clang toolchain. Pigweed makes it easy to configure other targets and toolchains. See toolchains/BUILD.gn and the Pigweed documentation.
The code is designed to be portable and should work with a variety of modern toolchains and in a variety of environments. The main code in dice.h and dice.c is C99; it uses uint8_t, size_t, and memcpy from the C standard library. The various ops implementations are as portable as their dependencies (often not C99 but still very portable). Notably, this code uses designated initializers for readability. This is a feature available in C since C99 but missing from C++ until C++20 where it appears in a stricter form.
The Google C++ Style Guide is used. A .clang-format file is provided for convenience.
To incorporate the code into another project, there are a few options:
Copy only the necessary code. For example:
Take the main code as is: include/dice/dice.h, src/dice.c
Choose an implementation for crypto and certificate generation or choose to write your own. If you choose the boringssl implementation, for example, take include/dice/utils.h, include/dice/boringssl_ops.h, src/utils.c, and src/boringssl_ops.c. Taking a look at the library targets in BUILD.gn may be helpful.
Add this repository as a git submodule and integrate into the project build, optionally using the gn library targets provided.
Integrate into a project already using Pigweed using the gn build files provided.
The build reports code size using Bloaty McBloatface via the pw_bloat Pigweed module. There are two reports generated:
Library sizes - This report includes just the library code in this repository. It shows the baseline DICE code with no ops selected, and it shows the delta introduced by choosing various ops implementations. This report does not include the size of the third party dependencies.
Executable sizes - This report includes sizes for the library code in this repository plus all dependencies linked into a simple main function which makes a single DICE call with all-zero input. It shows the baseline DICE code with no ops (and therefore no dependencies other than libc), and it shows the delta introduced by choosing various ops implementations. This report does include the size of the third party dependencies. Note that rows specialized from ‘Boringssl Ops’ use that as a baseline for sizing.
The reports will be in the build output, but you can also find the reports in .txt files in the build output. For example, cat out/host_optimized/gen/*.txt | less will display all reports.
This code does not itself use mutable global variables, or any other type of shared data structure so there is no thread-safety concerns. However, additional care is needed to ensure dependencies are configured to be thread-safe. For example, the current boringssl configuration defines OPENSSL_NO_THREADS_CORRUPT_MEMORY_AND_LEAK_SECRETS_IF_THREADED, and that would need to be changed before running in a threaded environment.
This code makes a reasonable effort to clear memory holding sensitive data. This may help with a broader strategy to clear sensitive data but it is not sufficient on its own. Here are a few things to consider.