roll: third_party/pigweed/src 78d65b0..c6751d6 (57 commits)

c6751d6:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/289635 pw_multibuf: Add chunk iterator for multibuf_v2
52852b6:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/296493 pw_console: Background command log parser fixes
90699c1:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/296414 pw_console: Fix inverted filters for empty fields
eafdae7:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/296401 pw_build: Recommend --experimental_platform_in_output_dir
341b98f:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/296402 pw_cli: Remove unused Python deps from setup.cfg
f19a245:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/286012 pw_bluetooth: Fix Android major/minor order
215956f:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/292264 pw_thread: Test for DefaultThreadContext
5ba4448:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/290552 pw_sync: Add threaded testing
300467f:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/296275 pw_tokenizer: Document workaround for tokenizing %.*s arguments
216474f:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/296175 pw_containers: Add support for generic sized InlineAsyncDeque
03b5bdc:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/296174 pw_containers: Add RawStorage specializations
5da76e8:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/274352 pw_tokenizer: Add write elf functionality
917f2ae:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/296053 pw_bluetooth_sapphire: Delete StartAdvertisingInternalStep2 return
5996f8f:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/295044 pw_bluetooth_sapphire: LowEnergyAdvertiser Inspect data
11e5296:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/294977 pw_containers: Add InlineAsyncQueue
83781ff:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/295043 pw_bluetooth_sapphire: Remove extended_pdu from AdvertisingHandleMap
150a44c:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/290593 pw_crypto: Implement ECDH for boringssl
b805f5a:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/294976 pw_containers: Add GenericQueue
ac805a6:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/294640 pw_containers: Add InlineAsyncDeque
d6a4aa0:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/296155 pw_multibuf: Fix Android build
f2928ad:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/296153 pw_env_setup: Remove Python version from error
4a462f6:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/296194 pw_env_setup: Add some Rosetta logging
4b1f8bc:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/295234 pw_bluetooth_sapphire: Allow multiple advertisements with same address
cfba271:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/294754 pw_bluetooth_sapphire: Don't replace advertisement with same address
8014684:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/290592 pw_crypto: Add facade for ECDH
6b8da92:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/296152 pw_spi_mcuxpresso: Add missing override keyword
638955e:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/296173 pw_stream_uart_mcuxpresso: Add missing override keyword
4eeed9b:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/296172 pw_stream_shmem_mcuxpresso: Add missing override keyword
1689d77:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/296059 pw_ide: Fix VSCode refresh compile command
2772952:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/296057 pw_ide: Run interceptor after actual bazel command, use default shell
c6e4c56:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/295625 pw_cli: Move pw tool implementation to multitool.py
5753b9c:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/295132 pw_build: Add PW_MUST_PLACE_SIZE
054ed2c:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/295973 pw_ide: Fix package script to use js instead of ts version
81e0b3d:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/295993 pw_i2c_mcuxpresso: Add missing override keyword
917e298:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/295972 pw_env_setup: PyPI version bump to 0.0.23
995b769:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/295864 pw_console: Log filter fix for empty column values
694dc2d:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/273572 pw_uart_mcuxpresso: Don't crash on ring buffer overflow
e3e78f5:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/295712 pw_build_mcuxpresso: Revert to c15953e4b
226e4c0:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/295952 pw_presubmit: Sort PyPI outputs before upload check
1f2d18f:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/295040 pw_log_android: Fix LOG_TAG redefinition issue
b494ca4:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/295758 pw_watch: Bugfix for fullscreen pw_console
2d66aec:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/295045 pw_build_android: Move cpp_std to common target support
9e89171:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/295046 pw_console: Window split improvements
3c3bc9b:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/295636 pw_console: Warn on unknown window titles
6998fee:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/295732 pw_result: Remove std::string from expected_test
6c67165:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/295616 targets/stm32f429i_disc1_stm32cube: Fix pw-system-console cmd
b283809:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/295621 pw_system: Always add log_pb2 to device_connection.py compiled_protos
cc99a5d:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/295693 pw_result: Fix missing header for Cmake
eb55fe9:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/295041 pw_toolchain: Add flag to allow toolchain customization
a15f828:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/295637 pw_kernel: Fix detokenizing qemu wrapper bug
a2b8665:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/295692 pw_span: Fix missing header for Cmake
763672e:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/294638 pw_containers: Factor out CountAndCapacity from GenericDeque
ff06ca7:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/295404 pw_ide: Fix bug with vscode where inactive file indicators don't update
c30dd50:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/295458 pw_ide: Only delete last compile_commands if new one has any
ff87f59:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/295372 pw_ide: Fix broken parseBazelBuildCommand test
c40a7a1:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/295405 roll: zephyr
a1e8863:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/294272 pw_chre: Fix GN check false alarm

Rolled-Repo: https://pigweed.googlesource.com/pigweed/pigweed
Rolled-Commits: 78d65b06538ff6..c6751d607bdaed
Roll-Count: 1
Roller-URL: https://cr-buildbucket.appspot.com/build/8712583877956006001
GitWatcher: ignore
CQ-Do-Not-Cancel-Tryjobs: true
Change-Id: If693f878e6153a46f28d51588c7cf37434f3393c
Reviewed-on: https://pigweed-review.googlesource.com/c/open-dice/+/296725
Commit-Queue: Pigweed Roller <pigweed-roller@pigweed-service-accounts.iam.gserviceaccount.com>
Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com>
Bot-Commit: Pigweed Roller <pigweed-roller@pigweed-service-accounts.iam.gserviceaccount.com>
1 file changed
tree: 550bf53d597fd8c54977d65adc7ab3eb80256e74
  1. build_overrides/
  2. docs/
  3. dpe-rs/
  4. images/
  5. include/
  6. src/
  7. third_party/
  8. toolchains/
  9. tools/
  10. .clang-format
  11. .gitignore
  12. .gitmodules
  13. .gn
  14. banner.txt
  15. bootstrap.sh
  16. BUILD.gn
  17. BUILDCONFIG.gn
  18. generate_test_values.py
  19. LICENSE
  20. navbar.md
  21. OWNERS
  22. pigweed.json
  23. pyproject.toml
  24. README.md
  25. run_fuzzer.sh
  26. rustfmt.toml
README.md

Open Profile for DICE

This repository contains the specification for the Open Profile for DICE along with production-quality code. This profile is a specialization of the Hardware Requirements for a Device Identifier Composition Engine and DICE Layering Architecture specifications published by the Trusted Computing Group (TCG). For readers already familiar with those specs, notable distinctives of this profile include:

  • Separate CDIs for attestation and sealing use cases
  • Categorized inputs, including values related to verified boot
  • Certified UDS values
  • X.509 or CBOR certificates

Mailing List

You can find us (and join us!) at https://groups.google.com/g/open-profile-for-dice. We're happy to answer questions and discuss proposed changes or features.

Specification

The specification can be found here. It is versioned using a major.minor scheme. Compatibility is maintained across minor versions but not necessarily across major versions.

Code

Production quality, portable C code is included. The main code is in dice.h and dice.c. Cryptographic and certificate generation operations are injected via a set of callbacks. Multiple implementations of these operations are provided, all equally acceptable. Integrators should choose just one of these, or write their own.

Tests are included for all code and the build files in this repository can be used to build and run these tests.

Disclaimer: This is not an officially supported Google product.

Thirdparty Dependencies

Different implementations use different third party libraries. The third_party directory contains build files and git submodules for each of these. The submodules must be initialized once after cloning the repo, using git submodule update --init, and updated after pulling commits that roll the submodules using git submodule update.

Building and Running Tests

Quick setup

To setup the build environment the first time:

$ git submodule update --init --recursive
$ source bootstrap.sh
$ gn gen out

To build and run tests:

$ ninja -C out

More details

The easiest way, and currently the only supported way, to build and run tests is from a Pigweed environment on Linux. Pigweed does support other host platforms so it shouldn't be too hard to get this running on Windows for example, but we use Linux.

There are two scripts to help set this up:

  • bootstrap.sh will initialize submodules, bootstrap a Pigweed environment, and generate build files. This can take some time and may download on the order of 1GB of dependencies so the normal workflow is to just do this once.

  • activate.sh quickly reactivates an environment that has been previously bootstrapped.

These scripts must be sourced into the current session: source activate.sh.

In the environment, from the base directory of the dice-profile checkout, run ninja -C out to build everything and run all tests. You can also run pw watch which will build, run tests, and continue to watch for changes.

This will build and run tests on the host using the clang toolchain. Pigweed makes it easy to configure other targets and toolchains. See toolchains/BUILD.gn and the Pigweed documentation.

Porting

The code is designed to be portable and should work with a variety of modern toolchains and in a variety of environments. The main code in dice.h and dice.c is C99; it uses uint8_t, size_t, and memcpy from the C standard library. The various ops implementations are as portable as their dependencies (often not C99 but still very portable). Notably, this code uses designated initializers for readability. This is a feature available in C since C99 but missing from C++ until C++20 where it appears in a stricter form.

Style

The Google C++ Style Guide is used. A .clang-format file is provided for convenience.

Incorporating

To incorporate the code into another project, there are a few options:

  • Copy only the necessary code. For example:

    1. Take the main code as is: include/dice/dice.h, src/dice.c

    2. Choose an implementation for crypto and certificate generation or choose to write your own. If you choose the boringssl implementation, for example, take include/dice/utils.h, include/dice/boringssl_ops.h, src/utils.c, and src/boringssl_ops.c. Taking a look at the library targets in BUILD.gn may be helpful.

  • Add this repository as a git submodule and integrate into the project build, optionally using the gn library targets provided.

  • Integrate into a project already using Pigweed using the gn build files provided.

Size Reports

The build reports code size using Bloaty McBloatface via the pw_bloat Pigweed module. There are two reports generated:

  • Library sizes - This report includes just the library code in this repository. It shows the baseline DICE code with no ops selected, and it shows the delta introduced by choosing various ops implementations. This report does not include the size of the third party dependencies.

  • Executable sizes - This report includes sizes for the library code in this repository plus all dependencies linked into a simple main function which makes a single DICE call with all-zero input. It shows the baseline DICE code with no ops (and therefore no dependencies other than libc), and it shows the delta introduced by choosing various ops implementations. This report does include the size of the third party dependencies. Note that rows specialized from ‘Boringssl Ops’ use that as a baseline for sizing.

The reports will be in the build output, but you can also find the reports in .txt files in the build output. For example, cat out/host_optimized/gen/*.txt | less will display all reports.

Thread Safety

This code does not itself use mutable global variables, or any other type of shared data structure so there is no thread-safety concerns. However, additional care is needed to ensure dependencies are configured to be thread-safe. For example, the current boringssl configuration defines OPENSSL_NO_THREADS_CORRUPT_MEMORY_AND_LEAK_SECRETS_IF_THREADED, and that would need to be changed before running in a threaded environment.

Clearing Sensitive Data

This code makes a reasonable effort to clear memory holding sensitive data. This may help with a broader strategy to clear sensitive data but it is not sufficient on its own. Here are a few things to consider.

  • The caller of this code is responsible for buffers they own (of course).
  • The ops implementations need to clear any copies they make of sensitive data. Both boringssl and mbedtls attempt to zeroize but this may need additional care to integrate correctly. For example, boringssl skips optimization prevention when OPENSSL_NO_ASM is defined (and it is currently defined).
  • Sensitive data may remain in cache.
  • Sensitive data may have been swapped out.
  • Sensitive data may be included in a crash dump.