roll: third_party/pigweed/src 3e01ec3..ea07dec (45 commits) ea07dec:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/370232 roll: luci 3b65a6f:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/370172 roll: fuchsia-infra-bazel-rules, MODULE.bazel.lock 40f4748:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/370072 roll: cmake 5c5c86f:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/369593 pw_build: Add artifacts manifest support to builds, groups, and tools 9c9e9cb:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/369832 pw_async2: Use Poll<void> instead of Poll<ReadyType> by default cca32bf:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/369472 pw_async2: Remove OnceSender/Receiver 7a2e643:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/368492 pw_log: Reserve LogEntry unused field numbers 9c981dc:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/369294 pw_bluetooth_sapphire: Migrate from OnceSender to OptionalValueProvider 660e1ed:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/369293 pw_async2: Add OptionalValueProvider 9f4e4e9:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/369653 Revert "roll: rules_python to 1.8.3" 3091526:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/355858 pw_bluetooth_sapphire: Read/write device class to BondingData b66ca60:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/366898 roll: rules_python to 1.8.3 5f88236:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/369272 pw_async2: Improve futures docs & fix example be4b720:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/369292 pw_async2: Make ValueProviders movable 3969188:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/366894 pw_bluetooth_proxy: Add CoC ChannelProxy 09e358f:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/369106 pw_async2: Remove old mention of pendable from codelab d9ffeef:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/369132 pw_bluetooth_sapphire: Update Fuchsia SDK 184954e:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/364397 sense: Update production.rst ba9e4a2:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/369172 pw_async2: Remove pw_async2/pendable.h b44346d:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/368854 pw_async2: Naming conventions for functions that return futures 79e7865:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/366572 pw_async2: Remove legacy Selector 6aed1fb:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/365981 pw_async2: Rewrite codelab step 5 to use futures 05c6870:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/365893 pw_bluetooth_proxy: Create RFCOMM submodule 07f04c4:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/368912 Revert "roll: ninja" 0b5cb5a:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/289377 pw_tokenizer: Deduplicate CSV entries 66db246:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/368932 pw_presubmit: Allow roll commits to have longer first lines 2a241ee:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/365973 pw_bluetooth_proxy: Implement SendCommand exclusions a5cb241:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/365972 pw_bluetooth_proxy: Implement SendCommand e54b14b:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/368853 roll: bazel_skylib to 1.8.2 8ca8896:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/368852 pw_async2: Remove "pendable" references from docs 1d5ee75:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/364433 pw_async2: Rewrite codelab step 4 to use futures f543f9f:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/363532 pw_async2: Rewrite codelab step 3 to use futures 7116302:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/359472 pw_async2: Rewrite codelab step 2 to use Futures 2476901:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/363913 pw_bluetooth_proxy: Separate locks to avoid deadlock in handlers 149eb80:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/353073 pw_bluetooth_proxy: Queue command packets 8ac567a:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/365892 pw_checksum: Add CRC8 support 209942e:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/354272 pw_toolchain: C++23 support and presubmit build 04b8575:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/367432 pw_build: Fix external repo handling for pw_pylint import paths 4580efa:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/367573 pw_env_setup: Remove Rosetta support 79acca5:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/367599 pw_async2: Rename //pw_async2:pend_func_task build targets 000aca0:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/367572 pw_digital_io_linux: Add missing include 37ba21f:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/368352 pw_bluetooth_proxy: Ensure test spans outlive MultiBuf dc1dea8:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/367534 pw_bluetooth_sapphire: Use GetLogicalLink in channel_manager.cc ec55e9b:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/367533 pw_bluetooth_sapphire: Debug logs on autosniff suppression 87b4652:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/367232 pw_bluetooth_sapphire: Disable autosniff while pairing in progress Rolled-Repo: https://pigweed.googlesource.com/pigweed/pigweed Rolled-Commits: 3e01ec3fda61ad..ea07decce2ea96 Roll-Count: 1 Roller-URL: https://cr-buildbucket.appspot.com/build/8691021794269771233 GitWatcher: ignore CQ-Do-Not-Cancel-Tryjobs: true Change-Id: Iad126aac08ca4257d13375b29e429f4307c6ce92 Reviewed-on: https://pigweed-review.googlesource.com/c/open-dice/+/370392 Bot-Commit: Pigweed Roller <pigweed-roller@pigweed-service-accounts.iam.gserviceaccount.com> Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com> Commit-Queue: Pigweed Roller <pigweed-roller@pigweed-service-accounts.iam.gserviceaccount.com>
This repository contains the specification for the Open Profile for DICE along with production-quality code. This profile is a specialization of the Hardware Requirements for a Device Identifier Composition Engine and DICE Layering Architecture specifications published by the Trusted Computing Group (TCG). For readers already familiar with those specs, notable distinctives of this profile include:
You can find us (and join us!) at https://groups.google.com/g/open-profile-for-dice. We're happy to answer questions and discuss proposed changes or features.
The specification can be found here. It is versioned using a major.minor scheme. Compatibility is maintained across minor versions but not necessarily across major versions.
Production quality, portable C code is included. The main code is in dice.h and dice.c. Cryptographic and certificate generation operations are injected via a set of callbacks. Multiple implementations of these operations are provided, all equally acceptable. Integrators should choose just one of these, or write their own.
Tests are included for all code and the build files in this repository can be used to build and run these tests.
Disclaimer: This is not an officially supported Google product.
Different implementations use different third party libraries. The third_party directory contains build files and git submodules for each of these. The submodules must be initialized once after cloning the repo, using git submodule update --init, and updated after pulling commits that roll the submodules using git submodule update.
To setup the build environment the first time:
$ git submodule update --init --recursive $ source bootstrap.sh $ gn gen out
To build and run tests:
$ ninja -C out
The easiest way, and currently the only supported way, to build and run tests is from a Pigweed environment on Linux. Pigweed does support other host platforms so it shouldn't be too hard to get this running on Windows for example, but we use Linux.
There are two scripts to help set this up:
bootstrap.sh will initialize submodules, bootstrap a Pigweed environment, and generate build files. This can take some time and may download on the order of 1GB of dependencies so the normal workflow is to just do this once.
activate.sh quickly reactivates an environment that has been previously bootstrapped.
These scripts must be sourced into the current session: source activate.sh.
In the environment, from the base directory of the dice-profile checkout, run ninja -C out to build everything and run all tests. You can also run pw watch which will build, run tests, and continue to watch for changes.
This will build and run tests on the host using the clang toolchain. Pigweed makes it easy to configure other targets and toolchains. See toolchains/BUILD.gn and the Pigweed documentation.
The code is designed to be portable and should work with a variety of modern toolchains and in a variety of environments. The main code in dice.h and dice.c is C99; it uses uint8_t, size_t, and memcpy from the C standard library. The various ops implementations are as portable as their dependencies (often not C99 but still very portable). Notably, this code uses designated initializers for readability. This is a feature available in C since C99 but missing from C++ until C++20 where it appears in a stricter form.
The Google C++ Style Guide is used. A .clang-format file is provided for convenience.
To incorporate the code into another project, there are a few options:
Copy only the necessary code. For example:
Take the main code as is: include/dice/dice.h, src/dice.c
Choose an implementation for crypto and certificate generation or choose to write your own. If you choose the boringssl implementation, for example, take include/dice/utils.h, include/dice/boringssl_ops.h, src/utils.c, and src/boringssl_ops.c. Taking a look at the library targets in BUILD.gn may be helpful.
Add this repository as a git submodule and integrate into the project build, optionally using the gn library targets provided.
Integrate into a project already using Pigweed using the gn build files provided.
The build reports code size using Bloaty McBloatface via the pw_bloat Pigweed module. There are two reports generated:
Library sizes - This report includes just the library code in this repository. It shows the baseline DICE code with no ops selected, and it shows the delta introduced by choosing various ops implementations. This report does not include the size of the third party dependencies.
Executable sizes - This report includes sizes for the library code in this repository plus all dependencies linked into a simple main function which makes a single DICE call with all-zero input. It shows the baseline DICE code with no ops (and therefore no dependencies other than libc), and it shows the delta introduced by choosing various ops implementations. This report does include the size of the third party dependencies. Note that rows specialized from ‘Boringssl Ops’ use that as a baseline for sizing.
The reports will be in the build output, but you can also find the reports in .txt files in the build output. For example, cat out/host_optimized/gen/*.txt | less will display all reports.
This code does not itself use mutable global variables, or any other type of shared data structure so there is no thread-safety concerns. However, additional care is needed to ensure dependencies are configured to be thread-safe. For example, the current boringssl configuration defines OPENSSL_NO_THREADS_CORRUPT_MEMORY_AND_LEAK_SECRETS_IF_THREADED, and that would need to be changed before running in a threaded environment.
This code makes a reasonable effort to clear memory holding sensitive data. This may help with a broader strategy to clear sensitive data but it is not sufficient on its own. Here are a few things to consider.