| commit | a946459be60c56d4fafd51b9e71060230e88c414 | [log] [tgz] |
|---|---|---|
| author | pigweed-roller <pigweed-roller@pigweed-service-accounts.iam.gserviceaccount.com> | Sun Dec 29 16:45:21 2024 -0800 |
| committer | CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> | Sun Dec 29 16:45:21 2024 -0800 |
| tree | 3163c68e37a653d3296fb48b6558aaa57df63805 | |
| parent | e64ff2e7ac671db1311c093d10cd7984bb8be179 [diff] |
roll: third_party/pigweed/src 7680a4e..97dc276 (22 commits) 97dc276:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/256657 pw_unit_test: Expand docs, add config 54608c1:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/256660 pw_protobuf_compiler: Wrap nanopb refs in Label 97587cb:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/256695 pw_sync_freertos: Handle nodiscard return value a567ea4:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/256433 Revert "pw_multibuf: Replace Mutex with ISL" 7cb8a82:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/256694 docs: Update ref to No-Docs-Update-Reason 8e7fd5e:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/256692 bazel: Remove obsolete label flag f7cdadd:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/256654 pw_spi_mcuxpresso: Introduce module constraint 41c5998:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/256333 pw_bluetooth_proxy: Send ongoing rx credits to remote d9cbe3f:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/256573 pw_bluetooth_proxy: Tweak test field name be3a9d7:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/220119 pw_system: Remove target_hooks_multiplexer bb41eea:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/220136 pw_crypto: Remove backend multiplexers 6ab6141:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/219053 pw_chrono: Remove backend multiplexers 6492053:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/256012 pw_toolchain: Support replacing GNU libs for ARM 46f4dc7:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/256453 pw_malloc: Add alwayslink 210617a:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/232037 pw_allocator: Add fuzzers f674d68:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/234818 pw_allocator: Add TLSF allocator 8be090f:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/256452 pw_bluetooth_proxy: Remove temp allocators from proxy proxy_host 2e04aa4:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/256332 pw_presubmit: New check for submission-blocking phrases c0162a3:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/254674 pw_bluetooth_proxy: L2capCoc segmentation 409b1f4:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/256095 pw_bluetooth_proxy: Separate l2cap coc mutex into tx and rx 4bbfa84:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/256094 pw_bluetooth_proxy: Add missing fields to l2cap coc move 06df658:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/256396 [owners] Remove luluwang@google.com from pw_bluetooth_sapphire/OWNERS Rolled-Repo: https://pigweed.googlesource.com/pigweed/pigweed Rolled-Commits: 7680a4e143633b..97dc276f6942c0 Roll-Count: 1 Roller-URL: https://cr-buildbucket.appspot.com/build/8727169989077656353 GitWatcher: ignore CQ-Do-Not-Cancel-Tryjobs: true Change-Id: I9985cde5626cf956feb27716f651ef76dc8d88b3 Reviewed-on: https://pigweed-review.googlesource.com/c/open-dice/+/256550 Bot-Commit: Pigweed Roller <pigweed-roller@pigweed-service-accounts.iam.gserviceaccount.com> Commit-Queue: Pigweed Roller <pigweed-roller@pigweed-service-accounts.iam.gserviceaccount.com> Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com>
This repository contains the specification for the Open Profile for DICE along with production-quality code. This profile is a specialization of the Hardware Requirements for a Device Identifier Composition Engine and DICE Layering Architecture specifications published by the Trusted Computing Group (TCG). For readers already familiar with those specs, notable distinctives of this profile include:
You can find us (and join us!) at https://groups.google.com/g/open-profile-for-dice. We're happy to answer questions and discuss proposed changes or features.
The specification can be found here. It is versioned using a major.minor scheme. Compatibility is maintained across minor versions but not necessarily across major versions.
Production quality, portable C code is included. The main code is in dice.h and dice.c. Cryptographic and certificate generation operations are injected via a set of callbacks. Multiple implementations of these operations are provided, all equally acceptable. Integrators should choose just one of these, or write their own.
Tests are included for all code and the build files in this repository can be used to build and run these tests.
Disclaimer: This is not an officially supported Google product.
Different implementations use different third party libraries. The third_party directory contains build files and git submodules for each of these. The submodules must be initialized once after cloning the repo, using git submodule update --init, and updated after pulling commits that roll the submodules using git submodule update.
To setup the build environment the first time:
$ git submodule update --init $ source bootstrap.sh $ gn gen out
To build and run tests:
$ ninja -C out
The easiest way, and currently the only supported way, to build and run tests is from a Pigweed environment on Linux. Pigweed does support other host platforms so it shouldn't be too hard to get this running on Windows for example, but we use Linux.
There are two scripts to help set this up:
bootstrap.sh will initialize submodules, bootstrap a Pigweed environment, and generate build files. This can take some time and may download on the order of 1GB of dependencies so the normal workflow is to just do this once.
activate.sh quickly reactivates an environment that has been previously bootstrapped.
These scripts must be sourced into the current session: source activate.sh.
In the environment, from the base directory of the dice-profile checkout, run ninja -C out to build everything and run all tests. You can also run pw watch which will build, run tests, and continue to watch for changes.
This will build and run tests on the host using the clang toolchain. Pigweed makes it easy to configure other targets and toolchains. See toolchains/BUILD.gn and the Pigweed documentation.
The code is designed to be portable and should work with a variety of modern toolchains and in a variety of environments. The main code in dice.h and dice.c is C99; it uses uint8_t, size_t, and memcpy from the C standard library. The various ops implementations are as portable as their dependencies (often not C99 but still very portable). Notably, this code uses designated initializers for readability. This is a feature available in C since C99 but missing from C++ until C++20 where it appears in a stricter form.
The Google C++ Style Guide is used. A .clang-format file is provided for convenience.
To incorporate the code into another project, there are a few options:
Copy only the necessary code. For example:
Take the main code as is: include/dice/dice.h, src/dice.c
Choose an implementation for crypto and certificate generation or choose to write your own. If you choose the boringssl implementation, for example, take include/dice/utils.h, include/dice/boringssl_ops.h, src/utils.c, and src/boringssl_ops.c. Taking a look at the library targets in BUILD.gn may be helpful.
Add this repository as a git submodule and integrate into the project build, optionally using the gn library targets provided.
Integrate into a project already using Pigweed using the gn build files provided.
The build reports code size using Bloaty McBloatface via the pw_bloat Pigweed module. There are two reports generated:
Library sizes - This report includes just the library code in this repository. It shows the baseline DICE code with no ops selected, and it shows the delta introduced by choosing various ops implementations. This report does not include the size of the third party dependencies.
Executable sizes - This report includes sizes for the library code in this repository plus all dependencies linked into a simple main function which makes a single DICE call with all-zero input. It shows the baseline DICE code with no ops (and therefore no dependencies other than libc), and it shows the delta introduced by choosing various ops implementations. This report does include the size of the third party dependencies. Note that rows specialized from ‘Boringssl Ops’ use that as a baseline for sizing.
The reports will be in the build output, but you can also find the reports in .txt files in the build output. For example, cat out/host_optimized/gen/*.txt | less will display all reports.
This code does not itself use mutable global variables, or any other type of shared data structure so there is no thread-safety concerns. However, additional care is needed to ensure dependencies are configured to be thread-safe. For example, the current boringssl configuration defines OPENSSL_NO_THREADS_CORRUPT_MEMORY_AND_LEAK_SECRETS_IF_THREADED, and that would need to be changed before running in a threaded environment.
This code makes a reasonable effort to clear memory holding sensitive data. This may help with a broader strategy to clear sensitive data but it is not sufficient on its own. Here are a few things to consider.