| commit | 9f741f729403c8f60e742bd8737ceaa03794d221 | [log] [tgz] |
|---|---|---|
| author | pigweed-roller <pigweed-roller@pigweed-service-accounts.iam.gserviceaccount.com> | Sun Mar 02 16:47:56 2025 -0800 |
| committer | CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> | Sun Mar 02 16:47:56 2025 -0800 |
| tree | 8a437d0b08dda39275f37a4021015a9e0851d764 | |
| parent | 1ba1559432478375276817a76f283db48df03004 [diff] |
roll: third_party/pigweed/src c12c17d..8ffdd15 (78 commits) 8ffdd15:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/272395 roll: gn 7dd375c:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/272393 roll: luci 8b96594:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/272392 roll: ninja 29cca8d:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/272372 roll: fuchsia-infra-bazel-rules 675bbe2..c87230d (21 commits) 1ba12f0:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/272272 pw_bluetooth_proxy: Fix Android.bp formatting 7eb794f:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/272192 pw_bluetooth_proxy: Add logging for gatt ctor/dtor b56458d:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/272193 pw_bluetooth_proxy: Drain queues after gatt write(span) b9cceca:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/272273 roll: cmake 3e26f94:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/272075 pw_fuzzer: Don't use //pw_containers:pw_containers cd2584d:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/271752 pw_kernel: Add WaitQueue 37931c6:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/272094 pw_bluetooth_sapphire: Fix crash in LowEnergyCentralServer daf1fff:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/272092 .*: Don't depend on //pw_containers:pw_containers 3d59c24:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/272112 pw_containers: Add missing dependency 3a63bba:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/272074 targets/emcraft_sf2_som: rm target with no srcs e109660:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/271688 pw_bluetooth_proxy: Add IFTTT across build files 2134bf8:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/271453 pw_bluetooth: Fixup IWYU pragmas 8f3a705:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/271832 pw_bluetooth: Annotate the A2DP specification in the packets f937c06:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/271972 pw_allocator: Update Android.bp with managed_ptr.cc changes 0801998:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/271687 pw_bluetooth_proxy: Add missing source to Android.bp c39f223:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/265633 pw_bluetooth_sapphire: Fix advertising data in tests to be accurate 0632790:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/260224 pw_bluetooth_sapphire: Move DiscoveryFilter from gap to hci bab55bb:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/260221 pw_bluetooth_sapphire: LowEnergyDiscoverySession tracks multiple filters fb7c6e5:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/271853 pw_sapphire_bluetooth: bt-host sets a memory profile 2c5e7fa:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/271852 pw_allocator: Restore Deallocator::WrapUniqueArray 03d757d:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/271681 pw_env_setup: Reorder args to cipd 30e3d13:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/271435 pw_presubmit: Get black config from file's parents 796b62d:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/271434 pw_cli: Add helpers for looking up config files b599ed3:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/271792 pw_assert: Mark :pw_assert deprecated b4a0ee4:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/271272 third_party/googletest: Add pw_third_party_googletest_ALIAS 2409b0e:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/271374 pw_allocator: Uniformly apply trait checks to block unit tests 569484f:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/271172 pw_kernel: Refactor scheduler to use ForeignBox/ForeignList ec058ef:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/270853 pw_kernel: Add ForeignList a16364a:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/270752 pw_kernel: Add ForeignBox type 0ccc12d:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/270832 pw_kernel: Move UnsafeList to deal exclusively with pointers 84eee29:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/271373 pw_allocator: Reorganize block unit tests fdb976b:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/271153 pw_preprocessor: rm BUILD.bazel list comprehension 9814a13:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/271372 pw_allocator: Simplify block unit test trait assetions 48cfde5:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/271152 pw_malloc: Remove build file variables 8b4d2d5:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/271473 pw_kernel: Add Cortex-M33 mps2-an505 QEMU platform 89e33bd:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/270413 .*: Replace pw_assert dependency e3c7b6b:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/271472 fuchsia_sdk: Replace fuchsia_sdk load statements with rules_fuchsia d643928:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/271592 pw_trace: Fix typo, add missing macro to doc 23b9953:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/271353 pw_rpc: Add console RPC completions from modules c75b4f3:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/271452 pw_bluetooth_proxy: Deliver pending events for all controller events 0a1b485:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/271412 pw_protobuf: Add missing finder definitions to codegen fa5e5ed:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/271173 pw_bluetooth_proxy: Call l2cap status tracker callbacks outside of lock 98b5712:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/270734 pw_allocator: Add ManagedPtr bed66f8:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/270733 pw_allocator: Add array support to New and MakeUnique aba9ff3:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/271292 docs: Style guidance on loads from dev deps c357ad6:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/270732 pw_allocator: Consolidate core build targets a839dbf:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/271093 pw_assert: Remove note in documentation d9fb53c:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/269193 pw_bloat: Support source_filter in Bazel targets 7c323be:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/271154 docs: Link to official Bazel Style Guide 8388d9e:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/271132 pw_env_setup: Add debug info 454233c:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/271112 third_party/googletest: Add missing header 14953c6:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/271012 pw_build: Split out recommended .bazelrc flags ef8e6ba:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/253272 pw_async: Enable BasicDispatcher::RunUntil to actually execute tasks f60af3a:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/271013 pw_unit_test: Add missing dependency ff8f31a:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/270812 pw_intrusive_ptr: Remove ref_counted.h from intrusive_ptr.h 818a872:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/269392 pw_bluetooth_sapphire: Create ActivityGovernorLeaseProvider d1402fd:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/269312 pw_bluetooth_sapphire: Create Lease API 420e39b:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/270412 pw_kernel: Add conditional log_if macros 474f5e4:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/263934 pw_bluetooth_proxy: Use pw::span_cast 4c87468:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/270833 roll: Clang cca9290:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/270914 pw_bluetooth_proxy: Add a common WriteLocked on L2capChannel e83026f:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/270913 docs: Connect upstream guide to contributing c53611c:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/270912 pw_string: Add missing dependency 9c7b530:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/270418 pw_bluetooth_proxy: Hold channels lock while using L2capChannel 56fe85e:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/267952 pw_uart_mcuxpresso: Implement FlushOutput for dma_uart_nonblocking 5eec1e4:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/270834 pw_json: Add missing dependency f0082a3:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/269755 pw_bluetooth_proxy: Allow accessing gatt channel attribute handle 76e4c2b:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/270852 pw_bluetooth_sapphire: Set role for bt-host main thread 98c880b:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/270753 pw_spi_mcuxpresso: responder: Use span_cast 978718e:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/269673 pw_bluetooth_sapphire: Set BoringSSL as AES backend 4014763:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/269672 pw_crypto: Ignore zero-size update in Cmac 61106fd:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/268172 pw_presubmit: Use runfiles manager for pigweed_format 66f0d06:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/269612 bazel: Check directory sources for changes 1af782c:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/270173 pw_intrusive_ptr: Move RefCounted into ref_counted.h Rolled-Repo: https://pigweed.googlesource.com/pigweed/pigweed Rolled-Commits: c12c17d8a25f0b..8ffdd1514e11f6 Roll-Count: 1 Roller-URL: https://cr-buildbucket.appspot.com/build/8721462368521825393 GitWatcher: ignore CQ-Do-Not-Cancel-Tryjobs: true Change-Id: I08e684380d6967da5c703099f789ede6da2d87fc Reviewed-on: https://pigweed-review.googlesource.com/c/open-dice/+/272416 Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com> Bot-Commit: Pigweed Roller <pigweed-roller@pigweed-service-accounts.iam.gserviceaccount.com> Commit-Queue: Pigweed Roller <pigweed-roller@pigweed-service-accounts.iam.gserviceaccount.com>
This repository contains the specification for the Open Profile for DICE along with production-quality code. This profile is a specialization of the Hardware Requirements for a Device Identifier Composition Engine and DICE Layering Architecture specifications published by the Trusted Computing Group (TCG). For readers already familiar with those specs, notable distinctives of this profile include:
You can find us (and join us!) at https://groups.google.com/g/open-profile-for-dice. We're happy to answer questions and discuss proposed changes or features.
The specification can be found here. It is versioned using a major.minor scheme. Compatibility is maintained across minor versions but not necessarily across major versions.
Production quality, portable C code is included. The main code is in dice.h and dice.c. Cryptographic and certificate generation operations are injected via a set of callbacks. Multiple implementations of these operations are provided, all equally acceptable. Integrators should choose just one of these, or write their own.
Tests are included for all code and the build files in this repository can be used to build and run these tests.
Disclaimer: This is not an officially supported Google product.
Different implementations use different third party libraries. The third_party directory contains build files and git submodules for each of these. The submodules must be initialized once after cloning the repo, using git submodule update --init, and updated after pulling commits that roll the submodules using git submodule update.
To setup the build environment the first time:
$ git submodule update --init --recursive $ source bootstrap.sh $ gn gen out
To build and run tests:
$ ninja -C out
The easiest way, and currently the only supported way, to build and run tests is from a Pigweed environment on Linux. Pigweed does support other host platforms so it shouldn't be too hard to get this running on Windows for example, but we use Linux.
There are two scripts to help set this up:
bootstrap.sh will initialize submodules, bootstrap a Pigweed environment, and generate build files. This can take some time and may download on the order of 1GB of dependencies so the normal workflow is to just do this once.
activate.sh quickly reactivates an environment that has been previously bootstrapped.
These scripts must be sourced into the current session: source activate.sh.
In the environment, from the base directory of the dice-profile checkout, run ninja -C out to build everything and run all tests. You can also run pw watch which will build, run tests, and continue to watch for changes.
This will build and run tests on the host using the clang toolchain. Pigweed makes it easy to configure other targets and toolchains. See toolchains/BUILD.gn and the Pigweed documentation.
The code is designed to be portable and should work with a variety of modern toolchains and in a variety of environments. The main code in dice.h and dice.c is C99; it uses uint8_t, size_t, and memcpy from the C standard library. The various ops implementations are as portable as their dependencies (often not C99 but still very portable). Notably, this code uses designated initializers for readability. This is a feature available in C since C99 but missing from C++ until C++20 where it appears in a stricter form.
The Google C++ Style Guide is used. A .clang-format file is provided for convenience.
To incorporate the code into another project, there are a few options:
Copy only the necessary code. For example:
Take the main code as is: include/dice/dice.h, src/dice.c
Choose an implementation for crypto and certificate generation or choose to write your own. If you choose the boringssl implementation, for example, take include/dice/utils.h, include/dice/boringssl_ops.h, src/utils.c, and src/boringssl_ops.c. Taking a look at the library targets in BUILD.gn may be helpful.
Add this repository as a git submodule and integrate into the project build, optionally using the gn library targets provided.
Integrate into a project already using Pigweed using the gn build files provided.
The build reports code size using Bloaty McBloatface via the pw_bloat Pigweed module. There are two reports generated:
Library sizes - This report includes just the library code in this repository. It shows the baseline DICE code with no ops selected, and it shows the delta introduced by choosing various ops implementations. This report does not include the size of the third party dependencies.
Executable sizes - This report includes sizes for the library code in this repository plus all dependencies linked into a simple main function which makes a single DICE call with all-zero input. It shows the baseline DICE code with no ops (and therefore no dependencies other than libc), and it shows the delta introduced by choosing various ops implementations. This report does include the size of the third party dependencies. Note that rows specialized from ‘Boringssl Ops’ use that as a baseline for sizing.
The reports will be in the build output, but you can also find the reports in .txt files in the build output. For example, cat out/host_optimized/gen/*.txt | less will display all reports.
This code does not itself use mutable global variables, or any other type of shared data structure so there is no thread-safety concerns. However, additional care is needed to ensure dependencies are configured to be thread-safe. For example, the current boringssl configuration defines OPENSSL_NO_THREADS_CORRUPT_MEMORY_AND_LEAK_SECRETS_IF_THREADED, and that would need to be changed before running in a threaded environment.
This code makes a reasonable effort to clear memory holding sensitive data. This may help with a broader strategy to clear sensitive data but it is not sufficient on its own. Here are a few things to consider.