roll: third_party/pigweed/src 116506d..62bd30d (65 commits) 62bd30d:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/442892 roll: luci 3aaf990:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/442852 roll: fuchsia-infra-bazel-rules 70f5247..07bb99a (3 commits) b825f50:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/441632 pw_bluetooth: Add Emboss definitions for AVCTP/AVRCP interception b87071e:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/440852 pw_async_basic: Fix dispatcher test race condition 6e7f466:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/436292 docs: Add section for security and bulletins 6db89b8:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/424592 pw_multibuf: Add ShallowCopy method a63dda3:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/442152 build: Don't run full build on clippy builds ca8f2a7:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/441575 pw_kernel: Refactor Mutex into RawMutex and Mutex 6c7ae9b:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/393773 pw_kernel: Adding nucleo-f103rb (stm32f103rb) to targets with the corresponding tests abbf5c2:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/441572 pw_bluetooth_sapphire: Fix LE CoC RX engine spec validation and credit enforcement 4a54257:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/433960 pw_bluetooth_proxy: Serialize off-dispatcher callers in async mode c59d362:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/338953 pw_bluetooth_sapphire: Move A2DP offloading opcodes to Emboss 2cdb8d4:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/441634 pw_metric: Fix ClangTidy include-cleaner warnings c9a4fa8:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/440072 pw_toolchain: Suppress -Wunused-template globally 07f9d86:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/441693 pw_async2: Fix coroutine_handle ABI mismatch 70189e4:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/441472 pw_snapshot, pw_system: Plumb snapshot cpu_arch to LlvmSymbolizer e0f05e9:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/441357 pw_bluetooth_sapphire: Fix unbounded memory growth on invalid PA reassembly d4f44dd:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/441356 pw_bluetooth_sapphire: Limit DataElement recursion 309122c:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/440572 pw_symbolizer: Support 64-bit address formatting in Symbol.to_string() 0df3975:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/439332 pw_symbolizer: Adjust return addresses for parent frames 4285f56:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/440812 pw_time: Add Duration human time accessors ce35bb4:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/441355 pw_bluetooth_sapphire: Drop malformed SDP frame 53da352:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/441354 pw_bluetooth_sapphire: Fix potential underflow on max_records calculation 2aabcf2:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/441353 pw_bluetooth_sapphire: Properly open channel when modes are inconsistent de5b2d4:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/441352 pw_bluetooth_sapphire: Add L2CAP configuration timeout and pending limit 999e126:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/427312 pw_tokenizer: Add pw::tokenizer::TokenBytes() 508ae91:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/434637 pw_bluetooth_sapphire: Cap L2CAP pre-activation SDU queue a34b673:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/440772 pw_sync_zephyr: Use quote includes for Pigweed headers 20b31f0:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/440753 pw_bluetooth_proxy: Define test utils before their dependents 455d214:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/440752 pw_chrono_zephyr/cmake: Remove extra header in system_timer 71726ae:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/434643 pw_bluetooth_sapphire: Implement repeated attempts backoff in sm c86a84d:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/440254 pw_chrono_zephyr: Migrate to strip_include_prefix 3f7a576:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/440253 pw_thread_zephyr: Migrate to strip_include_prefix 95bfb93:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/440252 pw_sync_zephyr: Migrate to strip_include_prefix 209813b:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/439895 pw_chrono_zephyr: Isolate backend override headers 8500413:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/439894 pw_thread_zephyr: Isolate backend override headers cf68240:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/439893 pw_sync_zephyr: Isolate backend override headers 556c2dd:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/436532 pw_tokenizer: Respect length specifiers when decoding integers in Rust 9ae22d9:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/433955 pw_bluetooth_proxy: Handle parameters without prior enable gracefully f4a43d1:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/440652 pw_i2c_mcuxpresso: Fix clock holding regression d12882a:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/439294 pw_bluetooth_sapphire: Add backoff to SecurityManager pairing f77a45f:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/439293 pw_bluetooth_sapphire: Ignore unsolicited SCO connection complete 0499e14:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/439192 pw_bluetooth_sapphire: Replace debug key assert with graceful failure 5e71fe8:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/439892 pw_bluetooth_proxy: Rfcomm: fix deadlock at PDU while socket write d0ca3b4:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/439432 pw_time: Move duration to an unsigned type to match std semantics fed3a37:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/438352 various: Fix unused template warnings from a nightly toolchain roll f8f03e2:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/439292 pw_bluetooth_sapphire: Fix unbounded pending PDUs a5eb3e6:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/437932 pw_bluetooth_proxy: Define snapshot foundation header and configs c5aa254:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/434635 pw_bluetooth_sapphire: Signal requests on CompletePairingRequests when not pairing a0ace66:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/439612 pw_bluetooth: Allow max_latency 0 in SniffSubrate d363390:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/438372 pw_trace_tokenized: Add type annotations to trace_tokenized.py 0e242cb:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/434634 pw_bluetooth_sapphire: Bound pending_pdus in ERTM TxEngine 20a52c9:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/433959 pw_bluetooth_proxy: Close stopped channels during ACL disconnection 7f42932:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/433957 pw_bluetooth_proxy: Handle Stop() on closed L2CAP channels c271b2f:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/434633 pw_bluetooth_sapphire: Notify service on client disconnect d0b3ea6:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/439176 pw_rpc_transport: Make kMaxChannelId customizable 1c407aa:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/439352 pw_allocator: Name ControlBlock::Create parameter 98875eb:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/425214 pw_metric: Document 64-bit support f759727:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/427596 pw_metric: Add temporary 28-bit detokenization fallback b2d61c1:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/429314 pw_metric: Add opt-in 64-bit metric support 766c92b:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/438995 pw_bluetooth_sapphire: Check delegate is alive before dereferencing 944e765:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/438996 pw_bluetooth_sapphire: Add missing return to LowEnergyConnectionServer 157ff65:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/439052 pw_preprocessor: Add PW_INTERNAL_ATTRIBUTED_CAPTURED_BY_THIS 6dac613:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/438994 pw_bluetooth_sapphire: Check callback existence before invoking 7c438d7:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/424534 pw_metric: Refactor Metric for 64-bit support Rolled-Repo: https://pigweed.googlesource.com/pigweed/pigweed Rolled-Commits: 116506db544d22..62bd30d9d8a0f9 Roll-Count: 1 Roller-URL: https://cr-buildbucket.appspot.com/build/8675167331435567633 GitWatcher: ignore CQ-Do-Not-Cancel-Tryjobs: true Change-Id: I93d0e9e88dc1f034734ead206c13e103cccbaf08 Reviewed-on: https://pigweed-review.googlesource.com/c/open-dice/+/443052
This repository contains the specification for the Open Profile for DICE along with production-quality code. This profile is a specialization of the Hardware Requirements for a Device Identifier Composition Engine and DICE Layering Architecture specifications published by the Trusted Computing Group (TCG). For readers already familiar with those specs, notable distinctives of this profile include:
You can find us (and join us!) at https://groups.google.com/g/open-profile-for-dice. We're happy to answer questions and discuss proposed changes or features.
The specification can be found here. It is versioned using a major.minor scheme. Compatibility is maintained across minor versions but not necessarily across major versions.
Production quality, portable C code is included. The main code is in dice.h and dice.c. Cryptographic and certificate generation operations are injected via a set of callbacks. Multiple implementations of these operations are provided, all equally acceptable. Integrators should choose just one of these, or write their own.
Tests are included for all code and the build files in this repository can be used to build and run these tests.
Disclaimer: This is not an officially supported Google product.
Different implementations use different third party libraries. The third_party directory contains build files and git submodules for each of these. The submodules must be initialized once after cloning the repo, using git submodule update --init, and updated after pulling commits that roll the submodules using git submodule update.
To setup the build environment the first time:
$ git submodule update --init --recursive $ source bootstrap.sh $ gn gen out
To build and run tests:
$ ninja -C out
The easiest way, and currently the only supported way, to build and run tests is from a Pigweed environment on Linux. Pigweed does support other host platforms so it shouldn't be too hard to get this running on Windows for example, but we use Linux.
There are two scripts to help set this up:
bootstrap.sh will initialize submodules, bootstrap a Pigweed environment, and generate build files. This can take some time and may download on the order of 1GB of dependencies so the normal workflow is to just do this once.
activate.sh quickly reactivates an environment that has been previously bootstrapped.
These scripts must be sourced into the current session: source activate.sh.
In the environment, from the base directory of the dice-profile checkout, run ninja -C out to build everything and run all tests. You can also run pw watch which will build, run tests, and continue to watch for changes.
This will build and run tests on the host using the clang toolchain. Pigweed makes it easy to configure other targets and toolchains. See toolchains/BUILD.gn and the Pigweed documentation.
The code is designed to be portable and should work with a variety of modern toolchains and in a variety of environments. The main code in dice.h and dice.c is C99; it uses uint8_t, size_t, and memcpy from the C standard library. The various ops implementations are as portable as their dependencies (often not C99 but still very portable). Notably, this code uses designated initializers for readability. This is a feature available in C since C99 but missing from C++ until C++20 where it appears in a stricter form.
The Google C++ Style Guide is used. A .clang-format file is provided for convenience.
To incorporate the code into another project, there are a few options:
Copy only the necessary code. For example:
Take the main code as is: include/dice/dice.h, src/dice.c
Choose an implementation for crypto and certificate generation or choose to write your own. If you choose the boringssl implementation, for example, take include/dice/utils.h, include/dice/boringssl_ops.h, src/utils.c, and src/boringssl_ops.c. Taking a look at the library targets in BUILD.gn may be helpful.
Add this repository as a git submodule and integrate into the project build, optionally using the gn library targets provided.
Integrate into a project already using Pigweed using the gn build files provided.
The build reports code size using Bloaty McBloatface via the pw_bloat Pigweed module. There are two reports generated:
Library sizes - This report includes just the library code in this repository. It shows the baseline DICE code with no ops selected, and it shows the delta introduced by choosing various ops implementations. This report does not include the size of the third party dependencies.
Executable sizes - This report includes sizes for the library code in this repository plus all dependencies linked into a simple main function which makes a single DICE call with all-zero input. It shows the baseline DICE code with no ops (and therefore no dependencies other than libc), and it shows the delta introduced by choosing various ops implementations. This report does include the size of the third party dependencies. Note that rows specialized from ‘Boringssl Ops’ use that as a baseline for sizing.
The reports will be in the build output, but you can also find the reports in .txt files in the build output. For example, cat out/host_optimized/gen/*.txt | less will display all reports.
This code does not itself use mutable global variables, or any other type of shared data structure so there is no thread-safety concerns. However, additional care is needed to ensure dependencies are configured to be thread-safe. For example, the current boringssl configuration defines OPENSSL_NO_THREADS_CORRUPT_MEMORY_AND_LEAK_SECRETS_IF_THREADED, and that would need to be changed before running in a threaded environment.
This code makes a reasonable effort to clear memory holding sensitive data. This may help with a broader strategy to clear sensitive data but it is not sufficient on its own. Here are a few things to consider.