commit 006229b27409e05f06fe25264ba573f9bd9ebf01
author pigweed-integration-roller <pigweed-integration-roller@pigweed.google.com.iam.gserviceaccount.com> Fri Jul 16 22:42:51 2021 +0000
committer CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Jul 16 22:49:14 2021 +0000
tree c869a56a2b90fc1eed925b6cd32357a5ab351ae9
parent bea6963bebdf3d9e6f057a6fabedd75170109f29

[roll third_party/pigweed] pw_rpc: Fix responding with empty buffers

The Channel::OutputBuffer::Contains() method previously did not check if
the OutputBuffer itself was empty. An empty span sent as a raw response
would appear as a span within the OutputBuffer, even though the
OutputBuffer was never allocated. Instead of allocating an OutputBuffer
for the RPC packet, the responder would attempt to encode it into the
empty OutputBuffer, which would fail.

- Update Contains() so it returns false on an empty OutputBuffer.
- Add tests for OutputBuffer::Contains() and sending an empty response.

Original-Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/53420

third_party/pigweed Rolled-Commits: 5f15bfd071edb14..68daa72bb4ac9a8
Roller-URL: https://ci.chromium.org/b/8841510847015520080
Cq-Cl-Tag: roller-builder:pigweed-experimental-roller
Cq-Cl-Tag: roller-bid:8841510847015520080
CQ-Do-Not-Cancel-Tryjobs: true
Change-Id: If7dbe482fe39cece22e0df506f35bf9c49c70b5a
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/experimental/+/53528
Reviewed-by: Pigweed Integration Roller <pigweed-integration-roller@pigweed.google.com.iam.gserviceaccount.com>
Commit-Queue: Pigweed Integration Roller <pigweed-integration-roller@pigweed.google.com.iam.gserviceaccount.com>