[roll third_party/pigweed] pw_spi: Correct full-duplex behavior of linux_spi
Prior to this change, LinuxInitiator::WriteRead() would always perform a
compound transfer, sending write_buffer *then* receiving read_buffer,
i.e. a half-duplex write-then-read operation.
This corrects that behavior to match the interface which describes a
full-duplex (simultaneous write and read) operation.
Note that `struct spi_ioc_transfer` only has a single `len` field
describing the number of bytes to send and receive in that transfer.
Because write_buffer and read_buffer could have different sizes,
this implementation will split the transaction into two transfers if
necessary to transfer the longer of the two.
Also add missing "override" to ~LinuxInitiator(), and remove a few
extraneous #includes.
Test: bazel test //pw_spi:linux_spi_test
Test: Execute a test application on a Linux host connected to a SPI
responder MCU programmed to send a fixed message with no dummy
cycles.
Test: Call WriteRead() with buffers of the same size. Verify message
is received in read_buffer. Verify via logic analyzer that a
single transaction is performed (no extra clock cycles).
Test: Call WriteRead with write_buffer longer than read_buffer.
Verify (partial) message is received in read_buffer. Verify via
logic analyzer that two transfers were performed (indicated by
inter-transfer delay with CS still active), and only
write_buffer.size() bytes were transmitted.
Test: Call WriteRead with read_buffer longer than write_buffer.
Verify message is received in read_buffer. Verify via logic
analyzer that two transfers were performed, and the transmitted
data was zero-padded out to read_buffer.size().
Original-Bug: b/316067628
Original-Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/192591
https://pigweed.googlesource.com/pigweed/pigweed
third_party/pigweed Rolled-Commits: ff7e7a78ce968db..63903b4f24e9122
Roller-URL: https://ci.chromium.org/b/8755992859306136001
GitWatcher: ignore
CQ-Do-Not-Cancel-Tryjobs: true
Change-Id: I4724256f488aa8d1c547e07a2bec8fb9e4d80c3a
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/experimental/+/192765
Bot-Commit: Pigweed Roller <pigweed-roller@pigweed-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Pigweed Roller <pigweed-roller@pigweed-service-accounts.iam.gserviceaccount.com>
This repository contains a variety experiments to help inform various Pigweed policies, designs, and implementation behaviors.
Code in this repository is not reviewed to the standard of the main Pigweed repository, and generally speaking is untested and maintained on a best-effort basis. This is not a repository of “early access” Pigweed modules, but more so a sandbox for Pigweed contributors to collaborate on investigations. For more information, see the contribution guidelines for the experimental repository and where to land code.
DO NOT DEPEND ON THIS REPOSITORY IN ANY PRODUCTION PROJECT!
Clone this repo with --recursive to get all required submodules.
git clone --recursive https://pigweed.googlesource.com/pigweed/experimental
This will pull the Pigweed source repository into third_party/pigweed. If you already cloned but forgot to --recursive run git submodule update --init to pull all submodules.
The //pw_graphics folder contains some libraries for drawing to an RGB565 framebuffer and displaying it on various platforms.
The demo applications that make use of these libraries are:
First time setup:
git clone --recursive https://pigweed.googlesource.com/pigweed/experimental cd experimental . ./bootstrap.sh pw package install imgui pw package install glfw pw package install stm32cube_f4 pw package install pico_sdk
Compile:
gn gen out --export-compile-commands --args=" dir_pw_third_party_stm32cube_f4=\"$PW_PROJECT_ROOT/environment/packages/stm32cube_f4\" " ninja -C out
Flash:
openocd -f third_party/pigweed/targets/stm32f429i_disc1/py/stm32f429i_disc1_utils/openocd_stm32f4xx.cfg -c "program out/stm32f429i_disc1_stm32cube_debug/obj/applications/terminal_display/bin/terminal_demo.elf verify reset exit"
First time setup:
pw package install stm32cube_f7
Compile:
gn gen out --export-compile-commands --args=" dir_pw_third_party_stm32cube_f7=\"//environment/packages/stm32cube_f7\" " ninja -C out
Flash:
openocd -f targets/stm32f769i_disc0/py/stm32f769i_disc0_utils/openocd_stm32f7xx.cfg \ -c "program out/stm32f769i_disc0_debug/obj/applications/blinky/bin/blinky.elf verify reset exit"
Compile:
gn gen out --export-compile-commands --args=" dir_pw_third_party_imgui=\"$PW_PROJECT_ROOT/environment/packages/imgui\" dir_pw_third_party_glfw=\"$PW_PROJECT_ROOT/environment/packages/glfw\" " ninja -C out
Run:
out/host_debug/obj/applications/terminal_display/bin/terminal_demo
Working displays:
First time setup:
pw package install pico_sdk
Compile:
gn gen out --export-compile-commands --args=' PICO_SRC_DIR="//environment/packages/pico_sdk" ' ninja -C out
Flash:
Using a uf2 file:
./out/rp2040/obj/applications/terminal_display/terminal_demo.uf2 to your Pi Pico.Using picotool:
picotool:picotool reboot -f -u
picotool load ./out/rp2040/obj/applications/terminal_display/bin/terminal_demo.elf picotool reboot
Using a Pico Probe and openocd:
This requires installing the Raspberry Pi foundation's OpenOCD fork for the Pico probe. More details including how to connect the two Pico boards is available at Raspberry Pi Pico and RP2040 - C/C++ Part 2: Debugging with VS Code
Install RaspberryPi's OpenOCD Fork:
git clone https://github.com/raspberrypi/openocd.git \ --branch picoprobe \ --depth=1 \ --no-single-branch \ openocd-picoprobe cd openocd-picoprobe ./bootstrap ./configure --enable-picoprobe --prefix=$HOME/apps/openocd --disable-werror make -j2 make install
Setup udev rules (Linux only):
cat <<EOF > 49-picoprobe.rules SUBSYSTEMS=="usb", ATTRS{idVendor}=="2e8a", ATTRS{idProduct}=="0004", MODE:="0666" KERNEL=="ttyACM*", ATTRS{idVendor}=="2e8a", ATTRS{idProduct}=="0004", MODE:="0666" EOF sudo cp 49-picoprobe.rules /usr/lib/udev/rules.d/49-picoprobe.rules sudo udevadm control --reload-rules
Flash the Pico:
~/apps/openocd/bin/openocd -f ~/apps/openocd/share/openocd/scripts/interface/picoprobe.cfg -f ~/apps/openocd/share/openocd/scripts/target/rp2040.cfg -c 'program out/rp2040/obj/applications/terminal_display/bin/terminal_demo.elf verify reset exit'
Launching gdb*
~/apps/openocd/bin/openocd -f ~/apps/openocd/share/openocd/scripts/interface/picoprobe.cfg -f ~/apps/openocd/share/openocd/scripts/target/rp2040.cfg
gdb-multiarch -ex "target remote :3333" -ex "set print pretty on" out/rp2040/obj/applications/terminal_display/bin/terminal_demo.elf
arm-none-eabi-gdb can be used in place of gdb-multiarch above.
Setup NXP SDK:
Compile:
gn gen out --export-compile-commands --args=" pw_MIMXRT595_EVK_SDK=\"//environment/SDK_2_12_1_EVK-MIMXRT595\" pw_target_mimxrt595_evk_MANIFEST=\"//environment/SDK_2_12_1_EVK-MIMXRT595/EVK-MIMXRT595_manifest_v3_10.xml\" pw_third_party_mcuxpresso_SDK=\"//targets/mimxrt595_evk:mimxrt595_sdk\" " ninja -C out
Flash the MIMXRT595-EVK:
Follow the instructions to flash the MIMXRT595-EVK with the SEGGER J-Link firmware and using arm-none-eabi-gdb at https://pigweed.dev/targets/mimxrt595_evk/target_docs.html#running-and-debugging.
https://www.pjrc.com/teensy/loader_cli.html
brew install teensy_loader_cli
OBJCOPY=/Applications/Arduino.app/Contents/Java/hardware/tools/avr/bin/avr-objcopy INFILE=out/arduino_debug/obj/applications/terminal_display/bin/terminal_demo.elf OUTFILE=foo.hex $OBJCOPY -O ihex -R .eeprom -R .fuse -R .lock -R .signature $INFILE $OUTFILE teensy_loader_cli --mcu=TEENSY41 -w -v $OUTFILE