commit 5ce42bf2e93e65d6c133fd8975f9550448e678f9
author Taylor Cramer <cramertj@pigweed.infra.roller.google.com> Tue Jun 13 20:01:57 2023 +0000
committer CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Jun 13 20:01:57 2023 +0000
tree c98eaea85dcdce856c63b1d5911609b325be50e2
parent 817b61145e9c10e8a79adbe3f203657fc12607dc

[roll third_party/pigweed] pw_build: Add `enable_if` to missing backend error

A dependency on a facade in a toolchain with a missing backend commonly
occurs by depending on the facade in a test. This change suggests using
`enable_if` to enable the test only when a backend is provided.

Tested: removed an existing `enable_if` and saw this error:

ERR Build error for //pw_chrono:system_clock.NO_BACKEND_SET(//targets/stm32f429i_disc1:stm32f429i_disc1_debug):
ERR
ERR   Attempted to build the //pw_chrono:system_clock facade with no backend.
ERR
ERR   If you are using this facade, ensure you have configured a backend
ERR   properly. The build arg for the facade must be set to a valid
ERR   backend in the toolchain. For example, you may need to add a line
ERR   like the following to the toolchain's .gni file:
ERR
ERR     pw_chrono_<FACADE_NAME>_BACKEND = "//path/to/the:backend"
ERR
ERR   Alternatively, if the target depending on this facade is a
<wrapped> `pw_test`
ERR   which should only be built in toolchains with a provided backend,
ERR   consider adding an `enable_if` to the dependent target:
ERR
ERR     pw_test(...) {
ERR       enable_if = pw_chrono_<FACADE_NAME>_BACKEND != ""
ERR       ...
ERR     }
ERR
ERR   If you are NOT using this facade, this error may have been
<wrapped> triggered
ERR   by trying to build all targets.
ERR
ERR Dependency path to this target:
ERR
ERR   gn path out //:default "//pw_chrono:system_clock.NO_BACKEND_SET(//targets/stm32f429i_disc1:stm32f429i_disc1_debug)"

Original-Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/151651

https://pigweed.googlesource.com/pigweed/pigweed
third_party/pigweed Rolled-Commits: 734cbf0a461a30f..886717437a55489
Roller-URL: https://ci.chromium.org/b/8778375291167847521
GitWatcher: ignore
CQ-Do-Not-Cancel-Tryjobs: true
Change-Id: I4fbed94320e0230bc19a81f854eaa77e345483d6
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/experimental/+/151579
Commit-Queue: Pigweed Integration Roller <pigweed-integration-roller@pigweed.google.com.iam.gserviceaccount.com>
Bot-Commit: Pigweed Integration Roller <pigweed-integration-roller@pigweed.google.com.iam.gserviceaccount.com>