| commit | 66a40cd2f6dd18d638ba94cec5fd5f941d4d6961 | [log] [tgz] |
|---|---|---|
| author | Jonathon Reinhart <jrreinhart@pigweed.infra.roller.google.com> | Thu Oct 02 22:58:19 2025 -0700 |
| committer | CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Oct 02 22:58:19 2025 -0700 |
| tree | 97e26de4eac3f893e5cee4b07fb204ebdd687654 | |
| parent | e86617dfa6cc6a882efda755c518fa35c838ca5c [diff] |
roll: third_party/pigweed pw_tokenizer: Apply no_sanitize("address") to tokenizer string entries
ASAN applies a 32-byte alignment to global variables as part of its
redzone strategy. This breaks the requirement that the
_pw_tokenizer_string_entry_* variables are 1-byte aligned so they appear
consecutively in the ELF section without any padding.
This isn't normally an issue as ASAN isn't used on firmware builds where
tokenization is used. But in the case of self-detokenizing programs
(namely tests), this causes ASAN violations and corrupt token entry ELF
section data.
Applying __attribute__((no_sanitize("address"))) to these variables
bypasses this behavior.
See also: https://pwrev.dev/c/pigweed/pigweed/+/328273/comments/7ee80b04_6fde2fa2
Original-Bug: 448430357
Original-Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/328692
Original-Revision: d7b8ed3f82c75d7f9ba8503983f220ffbb09b3e5
Rolled-Repo: https://pigweed.googlesource.com/pigweed/pigweed
Rolled-Commits: 83b3862437b4d0..d7b8ed3f82c75d
Roll-Count: 1
Roller-URL: https://cr-buildbucket.appspot.com/build/8702055970863540497
GitWatcher: ignore
CQ-Do-Not-Cancel-Tryjobs: true
Change-Id: Ic32caaec6257582ff9b48f7735112e180ba15f48
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/experimental/+/328752
Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com>
Bot-Commit: Pigweed Roller <pigweed-roller@pigweed-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Pigweed Roller <pigweed-roller@pigweed-service-accounts.iam.gserviceaccount.com>
diff --git a/third_party/pigweed b/third_party/pigweed index 83b3862..d7b8ed3 160000 --- a/third_party/pigweed +++ b/third_party/pigweed
@@ -1 +1 @@ -Subproject commit 83b3862437b4d01ea1fb7104a1e971bebc048cba +Subproject commit d7b8ed3f82c75d7f9ba8503983f220ffbb09b3e5