| commit | 66a40cd2f6dd18d638ba94cec5fd5f941d4d6961 | [log] [tgz] |
|---|---|---|
| author | Jonathon Reinhart <jrreinhart@pigweed.infra.roller.google.com> | Thu Oct 02 22:58:19 2025 -0700 |
| committer | CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Oct 02 22:58:19 2025 -0700 |
| tree | 97e26de4eac3f893e5cee4b07fb204ebdd687654 | |
| parent | e86617dfa6cc6a882efda755c518fa35c838ca5c [diff] |
roll: third_party/pigweed pw_tokenizer: Apply no_sanitize("address") to tokenizer string entries
ASAN applies a 32-byte alignment to global variables as part of its
redzone strategy. This breaks the requirement that the
_pw_tokenizer_string_entry_* variables are 1-byte aligned so they appear
consecutively in the ELF section without any padding.
This isn't normally an issue as ASAN isn't used on firmware builds where
tokenization is used. But in the case of self-detokenizing programs
(namely tests), this causes ASAN violations and corrupt token entry ELF
section data.
Applying __attribute__((no_sanitize("address"))) to these variables
bypasses this behavior.
See also: https://pwrev.dev/c/pigweed/pigweed/+/328273/comments/7ee80b04_6fde2fa2
Original-Bug: 448430357
Original-Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/328692
Original-Revision: d7b8ed3f82c75d7f9ba8503983f220ffbb09b3e5
Rolled-Repo: https://pigweed.googlesource.com/pigweed/pigweed
Rolled-Commits: 83b3862437b4d0..d7b8ed3f82c75d
Roll-Count: 1
Roller-URL: https://cr-buildbucket.appspot.com/build/8702055970863540497
GitWatcher: ignore
CQ-Do-Not-Cancel-Tryjobs: true
Change-Id: Ic32caaec6257582ff9b48f7735112e180ba15f48
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/experimental/+/328752
Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com>
Bot-Commit: Pigweed Roller <pigweed-roller@pigweed-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Pigweed Roller <pigweed-roller@pigweed-service-accounts.iam.gserviceaccount.com>
This repository contains a variety experiments to help inform various Pigweed policies, designs, and implementation behaviors.
Code in this repository is not reviewed to the standard of the main Pigweed repository, and generally speaking is untested and maintained on a best-effort basis. This is not a repository of “early access” Pigweed modules, but more so a sandbox for Pigweed contributors to collaborate on investigations. For more information, see the contribution guidelines for the experimental repository and where to land code.
DO NOT DEPEND ON THIS REPOSITORY IN ANY PRODUCTION PROJECT!
Clone this repo with --recursive to get all required submodules.
git clone --recursive https://pigweed.googlesource.com/pigweed/experimental
This will pull the Pigweed source repository into third_party/pigweed. If you already cloned but forgot to --recursive run git submodule update --init to pull all submodules.
The //pw_graphics folder contains some libraries for drawing to an RGB565 framebuffer and displaying it on various platforms.
The demo applications that make use of these libraries are:
First time setup:
git clone --recursive https://pigweed.googlesource.com/pigweed/experimental cd experimental . ./bootstrap.sh pw package install imgui pw package install glfw pw package install stm32cube_f4 pw package install pico_sdk
Compile:
gn gen out --export-compile-commands --args=" dir_pw_third_party_stm32cube_f4=\"$PW_PROJECT_ROOT/environment/packages/stm32cube_f4\" " ninja -C out
Flash:
openocd -f third_party/pigweed/targets/stm32f429i_disc1/py/stm32f429i_disc1_utils/openocd_stm32f4xx.cfg -c "program out/stm32f429i_disc1_stm32cube_debug/obj/applications/terminal_display/bin/terminal_demo.elf verify reset exit"
First time setup:
pw package install stm32cube_f7
Compile:
gn gen out --export-compile-commands --args=" dir_pw_third_party_stm32cube_f7=\"//environment/packages/stm32cube_f7\" " ninja -C out
Flash:
openocd -f targets/stm32f769i_disc0/py/stm32f769i_disc0_utils/openocd_stm32f7xx.cfg \ -c "program out/stm32f769i_disc0_debug/obj/applications/blinky/bin/blinky.elf verify reset exit"
Compile:
gn gen out --export-compile-commands --args=" dir_pw_third_party_imgui=\"$PW_PROJECT_ROOT/environment/packages/imgui\" dir_pw_third_party_glfw=\"$PW_PROJECT_ROOT/environment/packages/glfw\" " ninja -C out
Run:
out/host_debug/obj/applications/terminal_display/bin/terminal_demo
Working displays:
First time setup:
pw package install pico_sdk
Compile:
gn gen out --export-compile-commands --args=' PICO_SRC_DIR="//environment/packages/pico_sdk" ' ninja -C out
Flash:
Using a uf2 file:
./out/rp2040/obj/applications/terminal_display/terminal_demo.uf2 to your Pi Pico.Using picotool:
picotool:picotool reboot -f -u
picotool load ./out/rp2040/obj/applications/terminal_display/bin/terminal_demo.elf picotool reboot
Using a Pico Probe and openocd:
This requires installing the Raspberry Pi foundation's OpenOCD fork for the Pico probe. More details including how to connect the two Pico boards is available at Raspberry Pi Pico and RP2040 - C/C++ Part 2: Debugging with VS Code
Install RaspberryPi's OpenOCD Fork:
git clone https://github.com/raspberrypi/openocd.git \ --branch picoprobe \ --depth=1 \ --no-single-branch \ openocd-picoprobe cd openocd-picoprobe ./bootstrap ./configure --enable-picoprobe --prefix=$HOME/apps/openocd --disable-werror make -j2 make install
Setup udev rules (Linux only):
cat <<EOF > 49-picoprobe.rules SUBSYSTEMS=="usb", ATTRS{idVendor}=="2e8a", ATTRS{idProduct}=="0004", MODE:="0666" KERNEL=="ttyACM*", ATTRS{idVendor}=="2e8a", ATTRS{idProduct}=="0004", MODE:="0666" EOF sudo cp 49-picoprobe.rules /usr/lib/udev/rules.d/49-picoprobe.rules sudo udevadm control --reload-rules
Flash the Pico:
~/apps/openocd/bin/openocd -f ~/apps/openocd/share/openocd/scripts/interface/picoprobe.cfg -f ~/apps/openocd/share/openocd/scripts/target/rp2040.cfg -c 'program out/rp2040/obj/applications/terminal_display/bin/terminal_demo.elf verify reset exit'
Launching gdb*
~/apps/openocd/bin/openocd -f ~/apps/openocd/share/openocd/scripts/interface/picoprobe.cfg -f ~/apps/openocd/share/openocd/scripts/target/rp2040.cfg
gdb-multiarch -ex "target remote :3333" -ex "set print pretty on" out/rp2040/obj/applications/terminal_display/bin/terminal_demo.elf
arm-none-eabi-gdb can be used in place of gdb-multiarch above.
Setup NXP SDK:
Compile:
gn gen out --export-compile-commands --args=" pw_MIMXRT595_EVK_SDK=\"//environment/SDK_2_12_1_EVK-MIMXRT595\" pw_target_mimxrt595_evk_MANIFEST=\"//environment/SDK_2_12_1_EVK-MIMXRT595/EVK-MIMXRT595_manifest_v3_10.xml\" pw_third_party_mcuxpresso_SDK=\"//targets/mimxrt595_evk:mimxrt595_sdk\" " ninja -C out
Flash the MIMXRT595-EVK:
Follow the instructions to flash the MIMXRT595-EVK with the SEGGER J-Link firmware and using arm-none-eabi-gdb at https://pigweed.dev/targets/mimxrt595_evk/target_docs.html#running-and-debugging.
https://www.pjrc.com/teensy/loader_cli.html
brew install teensy_loader_cli
OBJCOPY=/Applications/Arduino.app/Contents/Java/hardware/tools/avr/bin/avr-objcopy INFILE=out/arduino_debug/obj/applications/terminal_display/bin/terminal_demo.elf OUTFILE=foo.hex $OBJCOPY -O ihex -R .eeprom -R .fuse -R .lock -R .signature $INFILE $OUTFILE teensy_loader_cli --mcu=TEENSY41 -w -v $OUTFILE