commit | a7444188dc518c2ecf383d1cede629b9de5cd0f3 | [log] [tgz] |
---|---|---|
author | Wyatt Hepler <hepler@pigweed.infra.roller.google.com> | Wed Sep 28 00:54:38 2022 +0000 |
committer | CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Sep 28 00:54:38 2022 +0000 |
tree | 0734a764044d0ab074c18e4727262933368fd02a | |
parent | 5edbfc862be68e9a2950e271d61fe462ad4b9d09 [diff] |
[roll third_party/pigweed] pw_string: Match std::string semantics for literal / array overloads Previously, the constructor, assign, and append overloads for string literals or arrays used the length of the array as the length of the string, and dropped the final character only if it was a null terminator. This avoided some strlen() calls and made assigning to an InlineString more like working with an ""sv string literal. However, since the character array is not guaranteed to be null terminated, this approach had some drawbacks: - A string of length N could not be assigned to an InlineString<N>, to account for non-terminated character arrays. - The capacity template argument would be deduced to a value one larger than the length of the string. - Behavior was inconsistent with std::string, since nulls could be included in assignments. This commit updates pw::InlineString's string literal or array overloads to use the same semantics as std::string. Unlike std::string, pw::InlineString checks the array size to prevent out-of-bounds reads. Original-Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/111711 https://pigweed.googlesource.com/pigweed/pigweed third_party/pigweed Rolled-Commits: 3da49f09465804b..71a3266aa316744 Roller-URL: https://ci.chromium.org/b/8801821297538188049 GitWatcher: ignore CQ-Do-Not-Cancel-Tryjobs: true Change-Id: Iad0b9b9903653008f3cfe957a832b76fb25ac6db Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/experimental/+/112353 Bot-Commit: Pigweed Integration Roller <pigweed-integration-roller@pigweed.google.com.iam.gserviceaccount.com> Commit-Queue: Pigweed Integration Roller <pigweed-integration-roller@pigweed.google.com.iam.gserviceaccount.com>
This repository contains experimental pigweed modules.
Clone this repo with --recursive
to get all required submodules.
git clone --recursive https://pigweed.googlesource.com/pigweed/experimental
This will pull the Pigweed source repository into third_party/pigweed
. If you already cloned but forgot to --recursive
run git submodule update --init
to pull all submodules.
The //pw_graphics folder contains some libraries for drawing to an RGB565 framebuffer and displaying it on various platforms.
The demo applications that make use of these libraries are:
First time setup:
git clone --recursive https://pigweed.googlesource.com/pigweed/experimental cd experimental . ./bootstrap.sh pw package install imgui pw package install glfw pw package install stm32cube_f4 pw package install pico_sdk
Compile:
gn gen out --export-compile-commands --args=" dir_pw_third_party_stm32cube_f4=\"$PW_PROJECT_ROOT/environment/packages/stm32cube_f4\" " ninja -C out
Flash:
openocd -f third_party/pigweed/targets/stm32f429i_disc1/py/stm32f429i_disc1_utils/openocd_stm32f4xx.cfg -c "program out/stm32f429i_disc1_stm32cube_debug/obj/applications/terminal_display/bin/terminal_demo.elf verify reset exit"
Compile:
gn gen out --export-compile-commands --args=" dir_pw_third_party_imgui=\"$PW_PROJECT_ROOT/environment/packages/imgui\" dir_pw_third_party_glfw=\"$PW_PROJECT_ROOT/environment/packages/glfw\" " ninja -C out
Run:
out/host_debug/obj/applications/terminal_display/bin/terminal_demo
Working displays:
Compile:
gn gen out --export-compile-commands --args=" PICO_SRC_DIR=\"$PW_PROJECT_ROOT/environment/packages/pico_sdk\" " ninja -C out
Flash:
Using a uf2 file:
./out/host_debug/obj/targets/rp2040/bin/elf2uf2 ./out/rp2040/obj/applications/terminal_display/bin/terminal_demo.elf ./out/rp2040/obj/applications/terminal_display/bin/terminal_demo.uf2
Copy ./out/rp2040/obj/applications/terminal_display/bin/terminal_demo.uf2
to your Pi Pico.
Using a Pico Probe and openocd:
This requires installing the Raspberry Pi foundation's OpenOCD fork for the Pico probe. More details including how to connect the two Pico boards is available at Raspberry Pi Pico and RP2040 - C/C++ Part 2: Debugging with VS Code
Install RaspberryPi's OpenOCD Fork:
git clone https://github.com/raspberrypi/openocd.git \ --branch picoprobe \ --depth=1 \ --no-single-branch \ openocd-picoprobe cd openocd-picoprobe ./bootstrap ./configure --enable-picoprobe --prefix=$HOME/apps/openocd --disable-werror make -j2 make install
Setup udev rules (Linux only):
cat <<EOF > 49-picoprobe.rules SUBSYSTEMS=="usb", ATTRS{idVendor}=="2e8a", ATTRS{idProduct}=="0004", MODE:="0666" KERNEL=="ttyACM*", ATTRS{idVendor}=="2e8a", ATTRS{idProduct}=="0004", MODE:="0666" EOF sudo cp 49-picoprobe.rules /usr/lib/udev/rules.d/49-picoprobe.rules sudo udevadm control --reload-rules
Flash the Pico:
~/apps/openocd/bin/openocd -f ~/apps/openocd/share/openocd/scripts/interface/picoprobe.cfg -f ~/apps/openocd/share/openocd/scripts/target/rp2040.cfg -c 'program out/rp2040/obj/applications/terminal_display/bin/terminal_demo.elf verify reset exit'