[roll third_party/pigweed] pw_emu: Fix pid file race condition
There is a race condition between writing and reading the pid file where
the reader can get an empty line:
======================================================================
ERROR: test_get_channel_addr (__main__.TestQemuChannelsTcp)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/local/google/home/tavip/src/pigweed/pw_emu/py/pw_emu/core.py", line 828, in _start_proc
pid = int(file.readline())
ValueError: invalid literal for int() with base 10: ''
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "pw_emu/py/tests/qemu_test.py", line 79, in setUp
self._emu.start(target='test-target', pause=True)
File "/usr/local/google/home/tavip/src/pigweed/pw_emu/py/pw_emu/frontend.py", line 100, in start
self._connector = self._launcher.start(
File "/usr/local/google/home/tavip/src/pigweed/pw_emu/py/pw_emu/core.py", line 909, in start
raise err
File "/usr/local/google/home/tavip/src/pigweed/pw_emu/py/pw_emu/core.py", line 905, in start
proc = self._start_proc(self._emu, cmd, foreground)
File "/usr/local/google/home/tavip/src/pigweed/pw_emu/py/pw_emu/core.py", line 831, in _start_proc
raise RunError(name, str(err))
pw_emu.core.RunError: error running `qemu`: invalid literal for int() with base 10:
To fix this race condition use a temporary file to write the pid than
rename that temporary file to the pid file.
Test: stress --cpu 512 --io 20 and run 1000 iterations of TestQemuChannelsTcp.test_get_channel_addr
Original-Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/176782
https://pigweed.googlesource.com/pigweed/pigweed
third_party/pigweed Rolled-Commits: 2eb3273c02f1ab8..a10b00e890dccb6
Roller-URL: https://ci.chromium.org/b/8766852027546800065
GitWatcher: ignore
CQ-Do-Not-Cancel-Tryjobs: true
Change-Id: I7abb49cd4f8ad16ab177a528607eb3aff1f549c9
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/experimental/+/176894
Bot-Commit: Pigweed Roller <pigweed-roller@pigweed-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Pigweed Roller <pigweed-roller@pigweed-service-accounts.iam.gserviceaccount.com>
This repository contains experimental pigweed modules.
Clone this repo with --recursive to get all required submodules.
git clone --recursive https://pigweed.googlesource.com/pigweed/experimental
This will pull the Pigweed source repository into third_party/pigweed. If you already cloned but forgot to --recursive run git submodule update --init to pull all submodules.
The //pw_graphics folder contains some libraries for drawing to an RGB565 framebuffer and displaying it on various platforms.
The demo applications that make use of these libraries are:
First time setup:
git clone --recursive https://pigweed.googlesource.com/pigweed/experimental cd experimental . ./bootstrap.sh pw package install imgui pw package install glfw pw package install stm32cube_f4 pw package install pico_sdk
Compile:
gn gen out --export-compile-commands --args=" dir_pw_third_party_stm32cube_f4=\"$PW_PROJECT_ROOT/environment/packages/stm32cube_f4\" " ninja -C out
Flash:
openocd -f third_party/pigweed/targets/stm32f429i_disc1/py/stm32f429i_disc1_utils/openocd_stm32f4xx.cfg -c "program out/stm32f429i_disc1_stm32cube_debug/obj/applications/terminal_display/bin/terminal_demo.elf verify reset exit"
First time setup:
pw package install stm32cube_f7
Compile:
gn gen out --export-compile-commands --args=" dir_pw_third_party_stm32cube_f7=\"//environment/packages/stm32cube_f7\" " ninja -C out
Flash:
openocd -f targets/stm32f769i_disc0/py/stm32f769i_disc0_utils/openocd_stm32f7xx.cfg \ -c "program out/stm32f769i_disc0_debug/obj/applications/blinky/bin/blinky.elf verify reset exit"
Compile:
gn gen out --export-compile-commands --args=" dir_pw_third_party_imgui=\"$PW_PROJECT_ROOT/environment/packages/imgui\" dir_pw_third_party_glfw=\"$PW_PROJECT_ROOT/environment/packages/glfw\" " ninja -C out
Run:
out/host_debug/obj/applications/terminal_display/bin/terminal_demo
Working displays:
First time setup:
pw package install pico_sdk
Compile:
gn gen out --export-compile-commands --args=' PICO_SRC_DIR="//environment/packages/pico_sdk" ' ninja -C out
Flash:
Using a uf2 file:
./out/rp2040/obj/applications/terminal_display/terminal_demo.uf2 to your Pi Pico.Using picotool:
picotool:picotool reboot -f -u
picotool load ./out/rp2040/obj/applications/terminal_display/bin/terminal_demo.elf picotool reboot
Using a Pico Probe and openocd:
This requires installing the Raspberry Pi foundation's OpenOCD fork for the Pico probe. More details including how to connect the two Pico boards is available at Raspberry Pi Pico and RP2040 - C/C++ Part 2: Debugging with VS Code
Install RaspberryPi's OpenOCD Fork:
git clone https://github.com/raspberrypi/openocd.git \ --branch picoprobe \ --depth=1 \ --no-single-branch \ openocd-picoprobe cd openocd-picoprobe ./bootstrap ./configure --enable-picoprobe --prefix=$HOME/apps/openocd --disable-werror make -j2 make install
Setup udev rules (Linux only):
cat <<EOF > 49-picoprobe.rules SUBSYSTEMS=="usb", ATTRS{idVendor}=="2e8a", ATTRS{idProduct}=="0004", MODE:="0666" KERNEL=="ttyACM*", ATTRS{idVendor}=="2e8a", ATTRS{idProduct}=="0004", MODE:="0666" EOF sudo cp 49-picoprobe.rules /usr/lib/udev/rules.d/49-picoprobe.rules sudo udevadm control --reload-rules
Flash the Pico:
~/apps/openocd/bin/openocd -f ~/apps/openocd/share/openocd/scripts/interface/picoprobe.cfg -f ~/apps/openocd/share/openocd/scripts/target/rp2040.cfg -c 'program out/rp2040/obj/applications/terminal_display/bin/terminal_demo.elf verify reset exit'
Launching gdb*
~/apps/openocd/bin/openocd -f ~/apps/openocd/share/openocd/scripts/interface/picoprobe.cfg -f ~/apps/openocd/share/openocd/scripts/target/rp2040.cfg
gdb-multiarch -ex "target remote :3333" -ex "set print pretty on" out/rp2040/obj/applications/terminal_display/bin/terminal_demo.elf
arm-none-eabi-gdb can be used in place of gdb-multiarch above.
Setup NXP SDK:
Compile:
gn gen out --export-compile-commands --args=" pw_MIMXRT595_EVK_SDK=\"//environment/SDK_2_12_1_EVK-MIMXRT595\" pw_target_mimxrt595_evk_MANIFEST=\"//environment/SDK_2_12_1_EVK-MIMXRT595/EVK-MIMXRT595_manifest_v3_10.xml\" pw_third_party_mcuxpresso_SDK=\"//targets/mimxrt595_evk:mimxrt595_sdk\" " ninja -C out
Flash the MIMXRT595-EVK:
Follow the instructions to flash the MIMXRT595-EVK with the SEGGER J-Link firmware and using arm-none-eabi-gdb at https://pigweed.dev/targets/mimxrt595_evk/target_docs.html#running-and-debugging.
https://www.pjrc.com/teensy/loader_cli.html
brew install teensy_loader_cli
OBJCOPY=/Applications/Arduino.app/Contents/Java/hardware/tools/avr/bin/avr-objcopy INFILE=out/arduino_debug/obj/applications/terminal_display/bin/terminal_demo.elf OUTFILE=foo.hex $OBJCOPY -O ihex -R .eeprom -R .fuse -R .lock -R .signature $INFILE $OUTFILE teensy_loader_cli --mcu=TEENSY41 -w -v $OUTFILE