[roll third_party/pigweed] pw_rpc: Add destructor to stateful Call subclasses b5f8cd9 moved waiting for callback completion from Call's destructors into the destructors of some subclasses. This helped ensure that the callbacks were completed prior to the destruction of fields referenced by those callbacks. However, that change missed a number of classes, and applied the destructor to some classes where no extra state was carried (except transitively through parent classes). This resulted in some bugs, notably b/282138354. This change moves the DestroyClientCall and DestroyServerCall invocations into two places: - The destructors of any stateful Call subclasses (those subclasses whose fields may be referenced by the callbacks). - The destructors of ServerCall and ClientCall (to guard the stateful `Call` class appropriately in the case of classes whose heirarchy would not otherwise have invoked `DestroyXXXCall`). This results in some duplication, notably between classes where multiple layers in the inheritance tree are stateful: each stateful layer will `DestroyXXXCall`. However, the alternative is leaving intermediate classes unprotected, which makes it undefined behavior to create an instance of such an intermediate class, and makes it hard to track whether the final subclasses are properly protected: they must include a destructor if and only if their parents had state and did *not* include a destructor. This condition is much too complex to validate, especially given that Call has 40+ subclasses, many with four-deep inheritance. After this CL, it should be easy to check a class for correctness: it must include a `DestroyXXXCall`-invoking destructor if it has a field whose state may be referenced from a callback. Original-Bug: b/282138354 Original-Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/148110 https://pigweed.googlesource.com/pigweed/pigweed third_party/pigweed Rolled-Commits: 0d5b4d933a0c457..ea55bee9faa2b0f Roller-URL: https://ci.chromium.org/b/8780104038322576993 GitWatcher: ignore CQ-Do-Not-Cancel-Tryjobs: true Change-Id: I195f2389285198b7477a353280ce400f2a93ded4 Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/experimental/+/148934 Bot-Commit: Pigweed Integration Roller <pigweed-integration-roller@pigweed.google.com.iam.gserviceaccount.com> Commit-Queue: Pigweed Integration Roller <pigweed-integration-roller@pigweed.google.com.iam.gserviceaccount.com>
This repository contains experimental pigweed modules.
Clone this repo with --recursive to get all required submodules.
git clone --recursive https://pigweed.googlesource.com/pigweed/experimental
This will pull the Pigweed source repository into third_party/pigweed. If you already cloned but forgot to --recursive run git submodule update --init to pull all submodules.
The //pw_graphics folder contains some libraries for drawing to an RGB565 framebuffer and displaying it on various platforms.
The demo applications that make use of these libraries are:
First time setup:
git clone --recursive https://pigweed.googlesource.com/pigweed/experimental cd experimental . ./bootstrap.sh pw package install imgui pw package install glfw pw package install stm32cube_f4 pw package install pico_sdk
Compile:
gn gen out --export-compile-commands --args=" dir_pw_third_party_stm32cube_f4=\"$PW_PROJECT_ROOT/environment/packages/stm32cube_f4\" " ninja -C out
Flash:
openocd -f third_party/pigweed/targets/stm32f429i_disc1/py/stm32f429i_disc1_utils/openocd_stm32f4xx.cfg -c "program out/stm32f429i_disc1_stm32cube_debug/obj/applications/terminal_display/bin/terminal_demo.elf verify reset exit"
First time setup:
pw package install stm32cube_f7
Compile:
gn gen out --export-compile-commands --args=" dir_pw_third_party_stm32cube_f7=\"//environment/packages/stm32cube_f7\" " ninja -C out
Flash:
openocd -f targets/stm32f769i_disc0/py/stm32f769i_disc0_utils/openocd_stm32f7xx.cfg \ -c "program out/stm32f769i_disc0_debug/obj/applications/blinky/bin/blinky.elf verify reset exit"
Compile:
gn gen out --export-compile-commands --args=" dir_pw_third_party_imgui=\"$PW_PROJECT_ROOT/environment/packages/imgui\" dir_pw_third_party_glfw=\"$PW_PROJECT_ROOT/environment/packages/glfw\" " ninja -C out
Run:
out/host_debug/obj/applications/terminal_display/bin/terminal_demo
Working displays:
Compile:
gn gen out --export-compile-commands --args=" PICO_SRC_DIR=\"$PW_PROJECT_ROOT/environment/packages/pico_sdk\" " ninja -C out
Flash:
Using a uf2 file:
./out/host_debug/obj/targets/rp2040/bin/elf2uf2 ./out/rp2040/obj/applications/terminal_display/bin/terminal_demo.elf ./out/rp2040/obj/applications/terminal_display/bin/terminal_demo.uf2
Copy ./out/rp2040/obj/applications/terminal_display/bin/terminal_demo.uf2 to your Pi Pico.
Using a Pico Probe and openocd:
This requires installing the Raspberry Pi foundation's OpenOCD fork for the Pico probe. More details including how to connect the two Pico boards is available at Raspberry Pi Pico and RP2040 - C/C++ Part 2: Debugging with VS Code
Install RaspberryPi's OpenOCD Fork:
git clone https://github.com/raspberrypi/openocd.git \ --branch picoprobe \ --depth=1 \ --no-single-branch \ openocd-picoprobe cd openocd-picoprobe ./bootstrap ./configure --enable-picoprobe --prefix=$HOME/apps/openocd --disable-werror make -j2 make install
Setup udev rules (Linux only):
cat <<EOF > 49-picoprobe.rules SUBSYSTEMS=="usb", ATTRS{idVendor}=="2e8a", ATTRS{idProduct}=="0004", MODE:="0666" KERNEL=="ttyACM*", ATTRS{idVendor}=="2e8a", ATTRS{idProduct}=="0004", MODE:="0666" EOF sudo cp 49-picoprobe.rules /usr/lib/udev/rules.d/49-picoprobe.rules sudo udevadm control --reload-rules
Flash the Pico:
~/apps/openocd/bin/openocd -f ~/apps/openocd/share/openocd/scripts/interface/picoprobe.cfg -f ~/apps/openocd/share/openocd/scripts/target/rp2040.cfg -c 'program out/rp2040/obj/applications/terminal_display/bin/terminal_demo.elf verify reset exit'
Setup NXP SDK:
Compile:
gn gen out --export-compile-commands --args=" pw_MIMXRT595_EVK_SDK=\"//environment/SDK_2_12_1_EVK-MIMXRT595\" pw_target_mimxrt595_evk_MANIFEST=\"//environment/SDK_2_12_1_EVK-MIMXRT595/EVK-MIMXRT595_manifest_v3_10.xml\" pw_third_party_mcuxpresso_SDK=\"//targets/mimxrt595_evk:mimxrt595_sdk\" " ninja -C out
Flash the MIMXRT595-EVK:
Follow the instructions to flash the MIMXRT595-EVK with the SEGGER J-Link firmware and using arm-none-eabi-gdb at https://pigweed.dev/targets/mimxrt595_evk/target_docs.html#running-and-debugging.
https://www.pjrc.com/teensy/loader_cli.html
brew install teensy_loader_cli
OBJCOPY=/Applications/Arduino.app/Contents/Java/hardware/tools/avr/bin/avr-objcopy INFILE=out/arduino_debug/obj/applications/terminal_display/bin/terminal_demo.elf OUTFILE=foo.hex $OBJCOPY -O ihex -R .eeprom -R .fuse -R .lock -R .signature $INFILE $OUTFILE teensy_loader_cli --mcu=TEENSY41 -w -v $OUTFILE