common_pico: Correct CS and RESET pin polarity
Also update pigweed-experimental submodule to include pw_spi_rp2040
and display driver polarity fixes.
Change-Id: I5c9cc95adfe5a8f2b1ffcb59a106efff2e16b3a0
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/kudzu/+/192350
Commit-Queue: Anthony DiGirolamo <tonymd@google.com>
Reviewed-by: Erik Gilling <konkers@google.com>
diff --git a/applications/app_common_impl/common_pico.cc b/applications/app_common_impl/common_pico.cc
index cf96e7a..2581b84 100644
--- a/applications/app_common_impl/common_pico.cc
+++ b/applications/app_common_impl/common_pico.cc
@@ -119,8 +119,6 @@
.bit_order = pw::spi::BitOrder::kMsbFirst,
};
-// TODO(tonymd): Determine the correct polarity and update the these modules:
-// pw_spi_rp2040 and pw_pixel_pusher_rp2040_pio
Rp2040DigitalInOut s_display_dc_pin({
.pin = DISPLAY_DC_GPIO,
.polarity = pw::digital_io::Polarity::kActiveHigh,
@@ -128,7 +126,7 @@
#if DISPLAY_RESET_GPIO != -1
Rp2040DigitalInOut s_display_reset_pin({
.pin = DISPLAY_RESET_GPIO,
- .polarity = pw::digital_io::Polarity::kActiveHigh,
+ .polarity = pw::digital_io::Polarity::kActiveLow,
});
#endif
#if DISPLAY_TE_GPIO != -1
@@ -139,7 +137,7 @@
#endif
Rp2040DigitalInOut s_display_cs_pin({
.pin = DISPLAY_CS_GPIO,
- .polarity = pw::digital_io::Polarity::kActiveHigh,
+ .polarity = pw::digital_io::Polarity::kActiveLow,
});
PicoChipSelector s_spi_chip_selector(s_display_cs_pin);
PicoInitiator s_spi_initiator(SPI_PORT);
diff --git a/third_party/pigweed-experimental b/third_party/pigweed-experimental
index d997908..42a328f 160000
--- a/third_party/pigweed-experimental
+++ b/third_party/pigweed-experimental
@@ -1 +1 @@
-Subproject commit d9979080cadf230ca7037066dd2c0df37a0004eb
+Subproject commit 42a328f5fc6e9ed622565180600523f6e507cd46
