commit | 25c981df913f421a05647c789786a976f16132fb | [log] [tgz] |
---|---|---|
author | Eli Lipsitz <elipsitz@google.com> | Fri Jan 27 16:01:01 2023 +0000 |
committer | CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Jan 27 16:01:01 2023 +0000 |
tree | a671e76b13c61b364a88cdd52f2196e650edc9da | |
parent | 4855987e331fc887d80639073adbfc5efc09638d [diff] |
pw_build: Detect EOF on macOS in pw-wrap-ninja Previously, we relied on Python throwing an OSError when we attempted to read from the Ninja subprocess's stdout to know if it closed its side of the TTY. This doesn't work on macOS -- instead, `read` returns an empty string. This commit checks for both, preventing the issue where pw-wrap-ninja would hang indefinitely when running it on macOS. Change-Id: Ib8fca3e75197848c8aa2df733357010031c96959 Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/126921 Pigweed-Auto-Submit: Eli Lipsitz <elipsitz@google.com> Commit-Queue: Auto-Submit <auto-submit@pigweed.google.com.iam.gserviceaccount.com> Reviewed-by: Rob Mohr <mohrr@google.com>
Pigweed is an open source collection of embedded-targeted libraries–or as we like to call them, modules. These modules are building blocks and infrastructure that enable faster and more reliable development on small-footprint MMU-less 32-bit microcontrollers like the STMicroelectronics STM32L452 or the Nordic nRF52832.
For more information please see our website: https://pigweed.dev/.