commit 36bca0bd5ec921660f169e38767590b5d3a23ae0
author Octavian Purdila <tavip@google.com> Mon Oct 16 18:27:21 2023 +0000
committer CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Oct 16 18:27:21 2023 +0000
tree bfbe3a91611e202cc3a7c403ca3503925acb6137
parent 34a7853d07c00146ee3ad85e9769469c1130c87d

pw_emu: core: Let the OS terminate foreground emulator processes

When the CLI runs the emulator in foreground there is no need to
explicitly terminate the emulator processes, the OS will do that for
us when the CLI process is terminated as long as the CLI runs attached
to a console.

Foreground CLI tests do not have a console attached (due to missing
pty support on Windows) and instead are using plain pipes. Because of
that logic was added to the core code to terminate the emulator
processes when it was running in foreground.

However, foreground tests were refactored to run the CLI as a session
leader and that allows clean termination for emulator processes
directly from the tests.

Thus it is no longer necessary to explicitly terminate emulator
processes in the core code when running in foreground.

Change-Id: Ib16578a94a757dcde3bf3744253745a9de52ffad
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/175638
Presubmit-Verified: CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Armando Montanez <amontanez@google.com>
Commit-Queue: Octavian Purdila <tavip@google.com>