commit 5d8e12df984d0525f4085587f24a16533ef01725
author Armando Montanez <amontanez@google.com> Thu Oct 28 15:25:35 2021 -0700
committer CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Dec 14 20:57:45 2021 +0000
tree af572149ea04d78feedcc323de90888d5a640910
parent a398cd1084f6da9253f6aea2ef2629aadb740ddf

pw_build_info: Better flag compatibility

Conditionally applies a GCC-only flag when building with gcc.

Change-Id: I22d8decbd780db89b3b07c6880ff4f46a185897f
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/66784
Pigweed-Auto-Submit: Armando Montanez <amontanez@google.com>
Reviewed-by: Wyatt Hepler <hepler@google.com>
Commit-Queue: Auto-Submit <auto-submit@pigweed.google.com.iam.gserviceaccount.com>

pw_build_info/build_id.cc

diff --git a/pw_build_info/build_id.cc b/pw_build_info/build_id.cc
index 7987667..d1e727f 100644
--- a/pw_build_info/build_id.cc
+++ b/pw_build_info/build_id.cc
@@ -33,6 +33,12 @@
 
 }  // namespace
 
+// Reading more than a uint8_t from gnu_build_id_begin triggers compiler
+// warnings that must be silenced.
+PW_MODIFY_DIAGNOSTICS_PUSH();
+PW_MODIFY_DIAGNOSTIC(ignored, "-Warray-bounds");
+PW_MODIFY_DIAGNOSTIC_GCC(ignored, "-Wstringop-overflow");
+
 std::span<const std::byte> BuildId() {
   // Read the sizes at the beginning of the note section.
   ElfNoteInfo build_id_note_sizes;
@@ -46,4 +52,6 @@
                                  build_id_note_sizes.descriptor_size));
 }
 
+PW_MODIFY_DIAGNOSTICS_POP();
+
 }  // namespace pw::build_info