commit | 78bf0ebd45afff754a9b00f693b210b71892d58e | [log] [tgz] |
---|---|---|
author | Luis Flores <lesprit@google.com> | Wed Mar 20 21:53:53 2024 +0000 |
committer | CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Mar 20 21:53:53 2024 +0000 |
tree | 6a939ffd58cc73ead1ca3198d31867216b564834 | |
parent | 00411468dd71e4564a39bd54fc524477ace88540 [diff] |
pw_web: Update createLogViewer to use union types A previous update to the input parameters in `createLogViewer` to enable multiple log sources (pwrev/192370) caused an error in the Hearables flash tool due to type mismatches. This change allows for one or more LogSource objects without requiring any modifications to external references to this function. Changelist: - Use union types instead of rest operator to maintain existing parameter order - Add a default assignment to `logStore` in case it's not provided by the caller - Update test files to use the new format Bug: 330564978 Change-Id: I5adebee9f5ed7f25a57ae3b35150ccac19d57dbf Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/198210 Presubmit-Verified: CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> Commit-Queue: Luis Flores <lesprit@google.com> Reviewed-by: Anthony DiGirolamo <tonymd@google.com>
Pigweed is an open source collection of embedded-targeted libraries–or as we like to call them, modules. These modules are building blocks and infrastructure that enable faster and more reliable development on small-footprint MMU-less 32-bit microcontrollers like the STMicroelectronics STM32L452 or the Nordic nRF52832.
For more information please see our website: https://pigweed.dev/.