| commit | 83e3901fd302aa46498de45d9366b67d4f3b0bd6 | [log] [tgz] |
|---|---|---|
| author | Taylor Cramer <cramertj@google.com> | Wed Feb 14 16:09:23 2024 +0000 |
| committer | CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Feb 14 16:09:23 2024 +0000 |
| tree | d75b76cb4fb9c6a37625a4326ac652b8f162d1ec | |
| parent | 7a40804002b6802464bd3d0edc62fde7655ab7f7 [diff] |
pw_presubmit: Log format --fix output Prior to this change, the format --fix command would silently exit with success regardless of the output of the actual fix subcommand output. This is due to some subcommands writing output or returning non-zero exit codes regardless of whether the command was successful. Unfortunately, this approach meant that failed fix subprocess commands were completely silent! This change instead logs the output of the subcommand to aid in debugging failed format commands. Change-Id: I083f660566012df95ec300aa1a329190bf96891e Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/192394 Reviewed-by: Anthony DiGirolamo <tonymd@google.com> Presubmit-Verified: CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> Commit-Queue: Auto-Submit <auto-submit@pigweed-service-accounts.iam.gserviceaccount.com> Pigweed-Auto-Submit: Taylor Cramer <cramertj@google.com>
Pigweed is an open source collection of embedded-targeted libraries–or as we like to call them, modules. These modules are building blocks and infrastructure that enable faster and more reliable development on small-footprint MMU-less 32-bit microcontrollers like the STMicroelectronics STM32L452 or the Nordic nRF52832.
For more information please see our website: https://pigweed.dev/.