pw_chre: Update bug numbers
Update the TODOs from the initial implementation bug to more
specific bugs. There's still a generic "implement unfinished behavior"
bug, but memory allocations and PALs have been split into two
new bugs.
Fixed: b/294106526
Change-Id: I5b09ad556bc28554e58456a38841d7825d9cf26d
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/172330
Presubmit-Verified: CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com>
Commit-Queue: Auto-Submit <auto-submit@pigweed-service-accounts.iam.gserviceaccount.com>
Pigweed-Auto-Submit: David Gilhooley <dgilhooley@google.com>
Reviewed-by: Armando Montanez <amontanez@google.com>
diff --git a/pw_chre/host_link.cc b/pw_chre/host_link.cc
index 6862bbb..51d7749 100644
--- a/pw_chre/host_link.cc
+++ b/pw_chre/host_link.cc
@@ -22,7 +22,7 @@
namespace chre {
-// TODO: b/294106526 - Implement these, possibly by adding a facade.
+// TODO: b/301477662 - Implement these, possibly by adding a facade.
void HostLink::flushMessagesSentByNanoapp(uint64_t) {}
bool HostLink::sendMessage(const MessageToHost* message) {
diff --git a/pw_chre/include/chre/target_platform/host_link_base.h b/pw_chre/include/chre/target_platform/host_link_base.h
index c40100b..6faea63 100644
--- a/pw_chre/include/chre/target_platform/host_link_base.h
+++ b/pw_chre/include/chre/target_platform/host_link_base.h
@@ -15,7 +15,7 @@
#pragma once
namespace chre {
-// TODO: b/294106526 - This class will likely need a facade since this will be
+// TODO: b/301477662 - This class will likely need a facade since this will be
// implemented in downstream products.
class HostLinkBase {
public:
diff --git a/pw_chre/memory.cc b/pw_chre/memory.cc
index 5ec1925..5aaddf9 100644
--- a/pw_chre/memory.cc
+++ b/pw_chre/memory.cc
@@ -18,7 +18,7 @@
namespace chre {
-// TODO: b/294106526 - Today these APIs call the system malloc and free, but
+// TODO: b/301477067 - Today these APIs call the system malloc and free, but
// they should be updated to use pw_allocator.
void* memoryAlloc(size_t size) { return malloc(size); }
diff --git a/pw_chre/platform_debug_dump_manager.cc b/pw_chre/platform_debug_dump_manager.cc
index 1c77e04..af6b497 100644
--- a/pw_chre/platform_debug_dump_manager.cc
+++ b/pw_chre/platform_debug_dump_manager.cc
@@ -19,9 +19,8 @@
PlatformDebugDumpManagerBase::~PlatformDebugDumpManagerBase() {}
-// TODO: b/294106526 - Implement these.
+// TODO: b/301477662 - Implement these.
void PlatformDebugDumpManager::sendDebugDump(const char*, bool) {}
-
void PlatformDebugDumpManager::logStateToBuffer(DebugDumpWrapper&) {}
} // namespace chre
diff --git a/pw_chre/platform_pal.cc b/pw_chre/platform_pal.cc
index 0771a3c..3003a23 100644
--- a/pw_chre/platform_pal.cc
+++ b/pw_chre/platform_pal.cc
@@ -16,7 +16,8 @@
namespace chre {
-// TODO: b/294106526 - Implement this.
+// TODO: b/301477951 - Implement this when we have PALs implemented. It is
+// unclear without more examples what this API would be used for.
void PlatformPal::prePalApiCall(PalType) const {}
} // namespace chre
diff --git a/pw_chre/power_control_manager.cc b/pw_chre/power_control_manager.cc
index fdcd502..6d45ea0 100644
--- a/pw_chre/power_control_manager.cc
+++ b/pw_chre/power_control_manager.cc
@@ -16,10 +16,9 @@
namespace chre {
-// TODO: b/294106526 - Implement these, possibly by adding a facade.
+// TODO: b/301477662 - Implement these, possibly by adding a facade.
void PowerControlManager::preEventLoopProcess(size_t) {}
void PowerControlManager::postEventLoopProcess(size_t) {}
-
bool PowerControlManager::hostIsAwake() { return true; }
} // namespace chre
diff --git a/third_party/chre/BUILD.gn b/third_party/chre/BUILD.gn
index fddbf16..729889d 100644
--- a/third_party/chre/BUILD.gn
+++ b/third_party/chre/BUILD.gn
@@ -32,9 +32,6 @@
"-Wno-int-in-bool-context",
"-Wno-thread-safety-analysis",
]
-
- # TODO: b/294106526 - Fill out the rest of the implementation and remove this.
- cflags += [ "-Wno-unused-parameter" ]
visibility = [ ":*" ]
}
