Google GitGoogle Git
Sign in
pigweed/pigweed/pigweed/cbf1831d2e5cacaf7ac6524d17ff751c734bb16a
commit
cbf1831d2e5cacaf7ac6524d17ff751c734bb16a
[log]
author
Ben <benlawson@google.com>
Thu Oct 01 15:32:45 2026 -0700
committer
CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com>
Thu Oct 01 15:32:45 2026 -0700
tree
17176837943a538dc69a2e4fe050cd8233e4893d
parent
427f22a9febfae259b4bb7434d53c038ad18ab28 [diff]
pw_bluetooth_sapphire: Guard null callback in AcknowledgeRead

Check that return_credits_callback_ is non-null before sharing and
invoking it in CreditBasedFlowControlRxEngine::AcknowledgeRead, and add
unit tests covering multiple AcknowledgeRead calls across SDUs as well
as null return_credits_callback_ handling.

Bug: b/525203197
Change-Id: I4f33a92dba24779b3bcc4972f5058f2a1d14780c
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/490174
2 files changed
tree: 17176837943a538dc69a2e4fe050cd8233e4893d
  1. .agents/
  2. .allstar/
  3. .gemini/
  4. .github/
  5. .vscode/
  6. build_overrides/
  7. docker/
  8. docs/
  9. kudzu/
  10. pw_alignment/
  11. pw_allocator/
  12. pw_allocator_zephyr/
  13. pw_analog/
  14. pw_android_toolchain/
  15. pw_arduino_build/
  16. pw_assert/
  17. pw_assert_basic/
  18. pw_assert_fuchsia/
  19. pw_assert_log/
  20. pw_assert_tokenized/
  21. pw_assert_trap/
  22. pw_assert_zephyr/
  23. pw_async/
  24. pw_async2/
  25. pw_async_basic/
  26. pw_async_fuchsia/
  27. pw_atomic/
  28. pw_base64/
  29. pw_bloat/
  30. pw_blob_store/
  31. pw_bluetooth/
  32. pw_bluetooth_hci/
  33. pw_bluetooth_profiles/
  34. pw_bluetooth_proxy/
  35. pw_bluetooth_sapphire/
  36. pw_boot/
  37. pw_boot_cortex_m/
  38. pw_buf/
  39. pw_build/
  40. pw_build_android/
  41. pw_build_info/
  42. pw_build_mcuxpresso/
  43. pw_bytes/
  44. pw_change/
  45. pw_channel/
  46. pw_checksum/
  47. pw_chre/
  48. pw_chrono/
  49. pw_chrono_embos/
  50. pw_chrono_freertos/
  51. pw_chrono_rp2040/
  52. pw_chrono_stl/
  53. pw_chrono_threadx/
  54. pw_chrono_zephyr/
  55. pw_cli/
  56. pw_cli_analytics/
  57. pw_clock_tree/
  58. pw_clock_tree_mcuxpresso/
  59. pw_compilation_testing/
  60. pw_config_loader/
  61. pw_console/
  62. pw_containers/
  63. pw_cpu_exception/
  64. pw_cpu_exception_cortex_m/
  65. pw_cpu_exception_risc_v/
  66. pw_crypto/
  67. pw_digital_io/
  68. pw_digital_io_linux/
  69. pw_digital_io_mcuxpresso/
  70. pw_digital_io_rp2040/
  71. pw_digital_io_zephyr/
  72. pw_display/
  73. pw_dma_mcuxpresso/
  74. pw_docgen/
  75. pw_doctor/
  76. pw_elf/
  77. pw_emu/
  78. pw_enum/
  79. pw_env_setup/
  80. pw_env_setup_zephyr/
  81. pw_file/
  82. pw_flatbuffers/
  83. pw_format/
  84. pw_fortifier/
  85. pw_function/
  86. pw_fuzzer/
  87. pw_ghish/
  88. pw_grpc/
  89. pw_hal/
  90. pw_hdlc/
  91. pw_hex_dump/
  92. pw_hil/
  93. pw_i2c/
  94. pw_i2c_linux/
  95. pw_i2c_mcuxpresso/
  96. pw_i2c_rp2040/
  97. pw_i2c_zephyr/
  98. pw_ide/
  99. pw_interrupt/
  100. pw_interrupt_cortex_m/
  101. pw_interrupt_freertos/
  102. pw_interrupt_zephyr/
  103. pw_intrusive_ptr/
  104. pw_json/
  105. pw_kernel/
  106. pw_kvs/
  107. pw_libc/
  108. pw_libcxx/
  109. pw_log/
  110. pw_log_android/
  111. pw_log_basic/
  112. pw_log_fuchsia/
  113. pw_log_null/
  114. pw_log_rpc/
  115. pw_log_string/
  116. pw_log_tokenized/
  117. pw_log_zephyr/
  118. pw_malloc/
  119. pw_malloc_freelist/
  120. pw_malloc_freertos/
  121. pw_memory/
  122. pw_metric/
  123. pw_module/
  124. pw_multibuf/
  125. pw_multisink/
  126. pw_numeric/
  127. pw_package/
  128. pw_perf_test/
  129. pw_persistent_ram/
  130. pw_polyfill/
  131. pw_preprocessor/
  132. pw_presubmit/
  133. pw_protobuf/
  134. pw_protobuf_compiler/
  135. pw_random/
  136. pw_random_fuchsia/
  137. pw_result/
  138. pw_ring_buffer/
  139. pw_router/
  140. pw_rpc/
  141. pw_rpc2/
  142. pw_rpc_transport/
  143. pw_rust/
  144. pw_sensor/
  145. pw_snapshot/
  146. pw_software_update/
  147. pw_span/
  148. pw_spi/
  149. pw_spi_linux/
  150. pw_spi_mcuxpresso/
  151. pw_spi_rp2040/
  152. pw_spi_zephyr/
  153. pw_status/
  154. pw_stm32cube_build/
  155. pw_stream/
  156. pw_stream_uart_linux/
  157. pw_stream_uart_mcuxpresso/
  158. pw_string/
  159. pw_symbolizer/
  160. pw_sync/
  161. pw_sync_baremetal/
  162. pw_sync_embos/
  163. pw_sync_freertos/
  164. pw_sync_stl/
  165. pw_sync_threadx/
  166. pw_sync_zephyr/
  167. pw_sys_io/
  168. pw_sys_io_ambiq_sdk/
  169. pw_sys_io_arduino/
  170. pw_sys_io_baremetal_lm3s6965evb/
  171. pw_sys_io_baremetal_stm32f429/
  172. pw_sys_io_emcraft_sf2/
  173. pw_sys_io_mcuxpresso/
  174. pw_sys_io_rp2040/
  175. pw_sys_io_stdio/
  176. pw_sys_io_stm32cube/
  177. pw_sys_io_zephyr/
  178. pw_system/
  179. pw_target_runner/
  180. pw_thread/
  181. pw_thread_embos/
  182. pw_thread_freertos/
  183. pw_thread_stl/
  184. pw_thread_threadx/
  185. pw_thread_zephyr/
  186. pw_time/
  187. pw_tls_client/
  188. pw_tls_client_boringssl/
  189. pw_tls_client_mbedtls/
  190. pw_tokenizer/
  191. pw_toolchain/
  192. pw_trace/
  193. pw_trace_tokenized/
  194. pw_transfer/
  195. pw_transport/
  196. pw_uart/
  197. pw_uart_mcuxpresso/
  198. pw_unit_test/
  199. pw_uuid/
  200. pw_varint/
  201. pw_watch/
  202. pw_web/
  203. pw_work_queue/
  204. seed/
  205. targets/
  206. third_party/
  207. zephyr/
  208. .dockerignore ⇨ .gitignore
  209. activate.fish ⇨ bootstrap.fish
  210. activate.sh ⇨ bootstrap.sh
  211. .bazelignore
  212. .bazelrc
  213. .bazelversion
  214. .black.toml
  215. .clang-format
  216. .clang-tidy
  217. .git-blame-ignore-revs
  218. .gitattributes
  219. .gitignore
  220. .gn
  221. .mypy.ini
  222. .prettierignore
  223. .prettierrc.cjs
  224. .pw_ide.yaml
  225. .pylintrc
  226. .rgignore
  227. .ruff.toml
  228. activate.bat
  229. AGENTS.md
  230. Android.bp
  231. AUTHORS
  232. bootstrap.bat
  233. bootstrap.fish
  234. bootstrap.sh
  235. BUILD.bazel
  236. BUILD.gn
  237. BUILDCONFIG.gn
  238. CLAUDE.md
  239. CMakeLists.txt
  240. EXTENDED_OWNERS
  241. GEMINI.md
  242. gh
  243. go.mod
  244. go.sum
  245. Kconfig.zephyr
  246. LICENSE
  247. MODULE.bazel
  248. MODULE.bazel.lock
  249. modules.gni
  250. OWNERS
  251. package.json
  252. pigweed.json
  253. PIGWEED_MODULES
  254. pw
  255. README.md
  256. REPO.bazel
  257. rustfmt.toml
  258. tsconfig.json
  259. workflows.json
  260. WORKSPACE_OWNERS
README.md

Pigweed

Pigweed is an open source collection of embedded-targeted libraries–or as we like to call them, modules. These modules are building blocks and infrastructure that enable faster and more reliable development on small-footprint MMU-less 32-bit microcontrollers like the STMicroelectronics STM32L452 or the Nordic nRF52832.

For more information please see our website: https://pigweed.dev/.

Links