commit | d48a5727b2103e6447b28222c4a9536799fec55d | [log] [tgz] |
---|---|---|
author | Wyatt Hepler <hepler@google.com> | Mon Jun 06 14:07:08 2022 -0700 |
committer | CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Jun 09 18:22:35 2022 +0000 |
tree | 1e91cf6b990cadcaa78a13c004bf5c635393e572 | |
parent | 00c321b734ba4bfe911bcb6f83af7302a779bdc4 [diff] |
pw_presubmit: Use python -m for pre-push hook - Using __file__ as the presubmit hook causes the hook to refer to the version of the script installed in the venv. setuptools drops the executable permissions bit, so the pre-push hook cannot execute the presubmit checks. Instead of using the file path in the presubmit hook, invoke the checks with `python -m pw_presubmit.pigweed_presubmit`. - Create install_git_hook(), a new version of the install_hook() function that takes the entire command as a list rather than splitting the command across two arguments. Bug: b/234728287 Change-Id: Id513f8618094144ede7bbb1bb1e40140a71d3598 Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/97222 Pigweed-Auto-Submit: Wyatt Hepler <hepler@google.com> Reviewed-by: Rob Mohr <mohrr@google.com> Commit-Queue: Auto-Submit <auto-submit@pigweed.google.com.iam.gserviceaccount.com> Reviewed-by: Ted Pudlik <tpudlik@google.com>
Pigweed is an open source collection of embedded-targeted libraries–or as we like to call them, modules. These modules are building blocks and infrastructure that enable faster and more reliable development on small-footprint MMU-less 32-bit microcontrollers like the STMicroelectronics STM32L452 or the Nordic nRF52832.
For more information please see our website: https://pigweed.dev/