| commit | dd01216fe0c4cc4e8418ba5f5f3e97650c7954a3 | [log] [tgz] |
|---|---|---|
| author | Ted Pudlik <tpudlik@google.com> | Fri Mar 15 22:16:25 2024 +0000 |
| committer | CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Mar 15 22:16:25 2024 +0000 |
| tree | 5109daa8c82b0690433dc2afe69077b6edc851d4 | |
| parent | 94b1e27729f2b64e5a86dfd9e68b5e635e6effba [diff] |
pw_rpc: Move some headers from srcs to hdrs Although some of these headers are in the "internal" subdirectory, they are all included by the proto generated code (see https://cs.opensource.google/pigweed/pigweed/+/main:pw_rpc/py/pw_rpc/codegen.py;l=153-161;drc=92e75196ab4c840b59752a9135d75f9289fc4cf7), so they ought to be public to avoid violating the layering check. It is a little strange that headers described as "internal" are part of the public API of this `cc_library`. I'm open to other suggestions for how to refactor the build! (E.g., should the generated target depend on a different, internal `cc_library` with restricted visibility? I don't understand pw_rpc well enough to propose an approach here.) Incidentally, GN has the same issue: these internal headers are listed in the `sources` but not considered `public`, even though the generated code includes them. Bug: 323749176 Change-Id: Id54876b7d5885195c317a7b42aed75ec489aa2ef Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/196850 Reviewed-by: Wyatt Hepler <hepler@google.com> Presubmit-Verified: CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> Commit-Queue: Ted Pudlik <tpudlik@google.com>
Pigweed is an open source collection of embedded-targeted libraries–or as we like to call them, modules. These modules are building blocks and infrastructure that enable faster and more reliable development on small-footprint MMU-less 32-bit microcontrollers like the STMicroelectronics STM32L452 or the Nordic nRF52832.
For more information please see our website: https://pigweed.dev/.