Make googletest a full dependency, not a dev_dependency
In principle, googletest is only needed for tests and could be a
dev_dependency. But it would then be impossible for downstream modules
to run BoringSSL's tests. The downstream module provides the toolchain,
so we may need to request they run tests when triaging issues. If
https://github.com/bazelbuild/bazel/issues/22187 is ever fixed, we can
change this.
With this change, the following works:
cd util/bazel-example
bazelisk test @boringssl//:crypto_test
Change-Id: Ied2276047de134883d6b61b0789f3c7bfcaad669
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/68127
Commit-Queue: David Benjamin <davidben@google.com>
Commit-Queue: Adam Langley <agl@google.com>
Auto-Submit: David Benjamin <davidben@google.com>
Reviewed-by: Adam Langley <agl@google.com>
diff --git a/MODULE.bazel b/MODULE.bazel
index b40ca9f..1d181be 100644
--- a/MODULE.bazel
+++ b/MODULE.bazel
@@ -20,7 +20,13 @@
compatibility_level = 2,
)
-bazel_dep(name = "googletest", version = "1.14.0.bcr.1", dev_dependency = True)
+# In principle, googletest is only needed for tests and could be a
+# dev_dependency. But it would then be impossible for downstream modules to run
+# BoringSSL's tests. The downstream module provides the toolchain, so we may
+# need to request they run tests when triaging issues. If
+# https://github.com/bazelbuild/bazel/issues/22187 is ever fixed, we can change
+# this.
+bazel_dep(name = "googletest", version = "1.14.0.bcr.1")
bazel_dep(name = "platforms", version = "0.0.9")
bazel_dep(name = "rules_cc", version = "0.0.9")
diff --git a/MODULE.bazel.lock b/MODULE.bazel.lock
index 4d065c0..7ac13bb 100644
--- a/MODULE.bazel.lock
+++ b/MODULE.bazel.lock
@@ -1,6 +1,6 @@
{
"lockFileVersion": 6,
- "moduleFileHash": "a4101ffdbea48850b26e5a4dd65cfa325c0de62c7625c1a240289146ff90ea54",
+ "moduleFileHash": "2cfd97765850664f634f2e744a77eaa1187f29cc1393af2fd497dc36f1a9b09c",
"flags": {
"cmdRegistries": [
"https://bcr.bazel.build/"
