commit 534970f39203d3aac98dfcf07bf87a15d2e9f75e
author David Benjamin <davidben@google.com> Fri Jul 08 18:00:29 2022 -0400
committer Boringssl LUCI CQ <boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Jul 12 15:22:43 2022 +0000
tree e0e9644f5177c4dad4748824b666a23816d1ea4d
parent f022e8421b927296d50436ae7b4b54fa4019cf41

Remove X509_ALGORS.

I found no uses of this. If we have to put it back, it's no big deal,
but one less group of functions to have to document. (SEQUENCE OF
AlgorithmIdentifier is mostly a weird PKCS#7 thing.)

Update-Note: X509_ALGORS is removed. If someone was relying on it, we
can re-export it.

Change-Id: I2b8e8d0d1d56d2debf99687023bc3621e92f6b08
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/53307
Commit-Queue: David Benjamin <davidben@google.com>
Reviewed-by: Bob Beck <bbe@google.com>

crypto/x509/x_algor.c

diff --git a/crypto/x509/x_algor.c b/crypto/x509/x_algor.c
index a2d778a..819aee5 100644
--- a/crypto/x509/x_algor.c
+++ b/crypto/x509/x_algor.c
@@ -69,14 +69,7 @@
     ASN1_OPT(X509_ALGOR, parameter, ASN1_ANY),
 } ASN1_SEQUENCE_END(X509_ALGOR)
 
-ASN1_ITEM_TEMPLATE(X509_ALGORS) = ASN1_EX_TEMPLATE_TYPE(ASN1_TFLG_SEQUENCE_OF,
-                                                        0, algorithms,
-                                                        X509_ALGOR)
-ASN1_ITEM_TEMPLATE_END(X509_ALGORS)
-
 IMPLEMENT_ASN1_FUNCTIONS_const(X509_ALGOR)
-IMPLEMENT_ASN1_ENCODE_FUNCTIONS_const_fname(X509_ALGORS, X509_ALGORS,
-                                            X509_ALGORS)
 IMPLEMENT_ASN1_DUP_FUNCTION_const(X509_ALGOR)
 
 int X509_ALGOR_set0(X509_ALGOR *alg, ASN1_OBJECT *aobj, int ptype, void *pval) {

include/openssl/x509.h

diff --git a/include/openssl/x509.h b/include/openssl/x509.h
index 673edfe..e0f4a3b 100644
--- a/include/openssl/x509.h
+++ b/include/openssl/x509.h
@@ -119,8 +119,6 @@
 
 DEFINE_STACK_OF(X509_ALGOR)
 
-typedef STACK_OF(X509_ALGOR) X509_ALGORS;
-
 DEFINE_STACK_OF(X509_NAME_ENTRY)
 
 DEFINE_STACK_OF(X509_NAME)
@@ -799,8 +797,6 @@
 OPENSSL_EXPORT const char *X509_get_default_cert_file_env(void);
 OPENSSL_EXPORT const char *X509_get_default_private_dir(void);
 
-DECLARE_ASN1_ENCODE_FUNCTIONS_const(X509_ALGORS, X509_ALGORS)
-
 DECLARE_ASN1_FUNCTIONS_const(X509_PUBKEY)
 
 // X509_PUBKEY_set serializes |pkey| into a newly-allocated |X509_PUBKEY|