| commit | 80944b538d606a8ee143db85ca9e50305d3c73e4 | [log] [tgz] |
|---|---|---|
| author | Mike Frysinger <vapier@google.com> | Wed Jul 22 03:23:20 2020 -0400 |
| committer | Mike Frysinger <vapier@google.com> | Sat Jul 25 08:31:52 2020 +0000 |
| tree | 1f35e59909e8f91366c3812a0c559bfd469960fe | |
| parent | 89f3ae5ae65de412bdde50e6e01ca666a1b7c2bb [diff] |
upload: exit non-zero when preupload hooks fail Bug: https://crbug.com/gerrit/13159 Change-Id: Id140b619242c841223c6bc5d4aa0c37a7ce0219d Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/276294 Reviewed-by: Jonathan Nieder <jrn@google.com> Tested-by: Mike Frysinger <vapier@google.com>
diff --git a/subcmds/upload.py b/subcmds/upload.py index 3dd9fd2..a886af9 100644 --- a/subcmds/upload.py +++ b/subcmds/upload.py
@@ -596,7 +596,7 @@ print('\nWARNING: pre-upload hooks failed, but uploading anyways.', file=sys.stderr) else: - return + return 1 if opt.reviewers: reviewers = _SplitEmails(opt.reviewers)