Google Git
Sign in
pigweed / third_party / gerrit / git-repo / bb8ee7f54a4e0bf07d466304d800f13ec41ac21c
commitbb8ee7f54a4e0bf07d466304d800f13ec41ac21c[log] [tgz]
authorMike Frysinger <vapier@google.com>Sat Feb 22 05:30:12 2020 -0500
committerMike Frysinger <vapier@google.com>Fri Mar 13 18:48:52 2020 +0000
treeaf0dec0603951b94f2cb7a73d273edd486df0fbf
parent23d7dafd10e382f42c34618f7c86b3ff1c9d4245 [diff]
manifest_xml: unify bool & int parsing

We've been overly lenient with boolean parsing by ignoring invalid
values as "false" even if the user didn't intend that.  Turn all
unknown values into warnings to avoid breaking existing manifests,
and unify the parsing logic in a helper to simplify.

We've been stricter about numbers, but still copying & pasting
inconsistent code.  Add a helper for this too.  For out of range
sync-j numbers (i.e. less than 1), throw a warning for now, but
mark it for future hard failures.

Change-Id: I924162b8036e6a5f1e31b6ebb24b6a26ed63712d
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/256457
Reviewed-by: Michael Mortensen <mmortensen@google.com>
Tested-by: Mike Frysinger <vapier@google.com>
2 files changed
tree: af0dec0603951b94f2cb7a73d273edd486df0fbf
  1. .github/
  2. docs/
  3. hooks/
  4. release/
  5. subcmds/
  6. tests/
  7. .flake8
  8. .gitattributes
  9. .gitignore
  10. .mailmap
  11. .project
  12. .pydevproject
  13. color.py
  14. command.py
  15. editor.py
  16. error.py
  17. event_log.py
  18. git_command.py
  19. git_config.py
  20. git_refs.py
  21. git_ssh
  22. gitc_utils.py
  23. LICENSE
  24. main.py
  25. MANIFEST.in
  26. manifest_xml.py
  27. pager.py
  28. platform_utils.py
  29. platform_utils_win32.py
  30. progress.py
  31. project.py
  32. pyversion.py
  33. README.md
  34. repo
  35. repo_trace.py
  36. run_tests
  37. setup.py
  38. SUBMITTING_PATCHES.md
  39. tox.ini
  40. wrapper.py
README.md

repo

Repo is a tool built on top of Git. Repo helps manage many Git repositories, does the uploads to revision control systems, and automates parts of the development workflow. Repo is not meant to replace Git, only to make it easier to work with Git. The repo command is an executable Python script that you can put anywhere in your path.

Contact

Please use the repo-discuss mailing list or issue tracker for questions.

You can file a new bug report under the “repo” component.

Please do not e-mail individual developers for support. They do not have the bandwidth for it, and often times questions have already been asked on repo-discuss or bugs posted to the issue tracker. So please search those sites first.

Install

Many distros include repo, so you might be able to install from there.

# Debian/Ubuntu.
$ sudo apt-get install repo

# Gentoo.
$ sudo emerge dev-vcs/repo

You can install it manually as well as it's a single script.

$ mkdir -p ~/.bin
$ PATH="${HOME}/.bin:${PATH}"
$ curl https://storage.googleapis.com/git-repo-downloads/repo > ~/.bin/repo
$ chmod a+rx ~/.bin/repo