commit 59b50a19979d42c3b0b60458b6e3cb80d6cc4c6e
author Hanno Becker <hanno.becker@arm.com> Wed Sep 09 10:56:56 2020 +0100
committer Hanno Becker <hanno.becker@arm.com> Wed Sep 09 10:58:52 2020 +0100
tree 6af80e8600239bc1ba1c5f7f78709912948820f1
parent 9b9be006066b21d2c0c1c09869c0c3b6a463e1d4

Don't use _xxx naming for local variables in ssl_tls13_keys.c

Signed-off-by: Hanno Becker <hanno.becker@arm.com>

library/ssl_tls13_keys.c

diff --git a/library/ssl_tls13_keys.c b/library/ssl_tls13_keys.c
index 1730501..a924dc8 100644
--- a/library/ssl_tls13_keys.c
+++ b/library/ssl_tls13_keys.c
@@ -280,8 +280,8 @@
 {
     int ret = MBEDTLS_ERR_SSL_INTERNAL_ERROR;
     size_t hlen, ilen;
-    unsigned char _secret[ MBEDTLS_MD_MAX_SIZE ] = { 0 };
-    unsigned char _input [ MBEDTLS_MD_MAX_SIZE ] = { 0 };
+    unsigned char tmp_secret[ MBEDTLS_MD_MAX_SIZE ] = { 0 };
+    unsigned char tmp_input [ MBEDTLS_MD_MAX_SIZE ] = { 0 };
 
     const mbedtls_md_info_t *md;
     md = mbedtls_md_info_from_type( hash_alg );
@@ -300,14 +300,14 @@
                    MBEDTLS_SSL_TLS1_3_LBL_WITH_LEN( derived ),
                    NULL, 0, /* context */
                    MBEDTLS_SSL_TLS1_3_CONTEXT_UNHASHED,
-                   _secret, hlen );
+                   tmp_secret, hlen );
         if( ret != 0 )
             goto cleanup;
     }
 
     if( input != NULL )
     {
-        memcpy( _input, input, input_len );
+        memcpy( tmp_input, input, input_len );
         ilen = input_len;
     }
     else
@@ -319,8 +319,8 @@
      * The salt is the old secret, and the input key material
      * is the input secret (PSK / ECDHE). */
     ret = mbedtls_hkdf_extract( md,
-                    _secret, hlen,
-                    _input, ilen,
+                    tmp_secret, hlen,
+                    tmp_input, ilen,
                     secret_new );
     if( ret != 0 )
         goto cleanup;
@@ -329,8 +329,8 @@
 
  cleanup:
 
-    mbedtls_platform_zeroize( _secret, sizeof(_secret) );
-    mbedtls_platform_zeroize( _input,  sizeof(_input)  );
+    mbedtls_platform_zeroize( tmp_secret, sizeof(tmp_secret) );
+    mbedtls_platform_zeroize( tmp_input,  sizeof(tmp_input)  );
     return( ret );
 }