commit 889b3b76da4ca9471a4b73f3bf544909e85f15a4
author Jerry Yu <jerry.h.yu@arm.com> Fri Dec 10 12:57:45 2021 +0800
committer Jerry Yu <jerry.h.yu@arm.com> Fri Dec 10 12:57:45 2021 +0800
tree 6aaa5a667e130b616e8203ed4fe0285c4716118a
parent 4a2fa5d0aaa99ce906bcaee76deeb67273b4b691

fix clang build fail

Signed-off-by: Jerry Yu <jerry.h.yu@arm.com>

library/ssl_tls13_keys.c

diff --git a/library/ssl_tls13_keys.c b/library/ssl_tls13_keys.c
index ea0c55b..88f0fe5 100644
--- a/library/ssl_tls13_keys.c
+++ b/library/ssl_tls13_keys.c
@@ -655,7 +655,6 @@
     size_t transcript_len;
 
     unsigned char *base_key = NULL;
-    size_t base_key_len;
 
     mbedtls_md_type_t const md_type = ssl->handshake->ciphersuite_info->mac;
     const mbedtls_md_info_t* const md_info =
@@ -678,15 +677,9 @@
     MBEDTLS_SSL_DEBUG_BUF( 4, "handshake hash", transcript, transcript_len );
 
     if( from == MBEDTLS_SSL_IS_CLIENT )
-    {
         base_key = ssl->handshake->tls13_hs_secrets.client_handshake_traffic_secret;
-        base_key_len = sizeof( ssl->handshake->tls13_hs_secrets.client_handshake_traffic_secret );
-    }
     else
-    {
         base_key = ssl->handshake->tls13_hs_secrets.server_handshake_traffic_secret;
-        base_key_len = sizeof( ssl->handshake->tls13_hs_secrets.server_handshake_traffic_secret );
-    }
 
     ret = ssl_tls13_calc_finished_core( md_type, base_key, transcript, dst );
     if( ret != 0 )
@@ -698,7 +691,10 @@
 
 exit:
     /* Erase handshake secrets */
-    mbedtls_platform_zeroize( base_key, base_key_len );
+    if( from == MBEDTLS_SSL_IS_CLIENT )
+        mbedtls_platform_zeroize( base_key, sizeof( ssl->handshake->tls13_hs_secrets.client_handshake_traffic_secret ) );
+    else
+        mbedtls_platform_zeroize( base_key, sizeof( ssl->handshake->tls13_hs_secrets.server_handshake_traffic_secret ) );
     mbedtls_platform_zeroize( transcript, sizeof( transcript ) );
     return( ret );
 }