commit 6b698ff6bc539a932b28aa5220fc978a3d585667
author Ching-Hsin,Lee <chinglee@amazon.com> Wed Jan 10 05:08:03 2024 +0000
committer Paul Bartell <paul.bartell@gmail.com> Thu Jan 11 10:53:54 2024 -0800
tree 9b7167e2860a8c64a3c340fa7b0aa8a2660c0d71
parent 88d3540b54d837f1e06e9dd3837316ca5f425c14

Fix potential race condition

portable/ThirdParty/GCC/Posix/port.c

diff --git a/portable/ThirdParty/GCC/Posix/port.c b/portable/ThirdParty/GCC/Posix/port.c
index c5864f8..34293f0 100644
--- a/portable/ThirdParty/GCC/Posix/port.c
+++ b/portable/ThirdParty/GCC/Posix/port.c
@@ -105,11 +105,7 @@
 static pthread_t hMainThread = ( pthread_t ) NULL;
 static volatile BaseType_t uxCriticalNesting;
 static List_t xThreadList;
-/*-----------------------------------------------------------*/
-
 static pthread_t hTimerTickThread;
-static bool xTimerTickThreadShouldRun;
-
 static BaseType_t xSchedulerEnd = pdFALSE;
 /*-----------------------------------------------------------*/
 
@@ -181,13 +177,14 @@
 
     thread->ev = event_create();
 
-    /* Add the new thread in xThreadList. */
     vListInitialiseItem( &thread->xThreadListItem );
     listSET_LIST_ITEM_OWNER( &thread->xThreadListItem, thread );
-    vListInsertEnd( &xThreadList, &thread->xThreadListItem );
 
     vPortEnterCritical();
 
+    /* Add the new thread in xThreadList. */
+    vListInsertEnd( &xThreadList, &thread->xThreadListItem );
+
     iRet = pthread_create( &thread->pthread, &xThreadAttributes,
                            prvWaitForStart, thread );
 
@@ -245,10 +242,6 @@
         sigwait( &xSignals, &iSignal );
     }
 
-    /* asking timer thread to shut down */
-    xTimerTickThreadShouldRun = false;
-    pthread_join( hTimerTickThread, NULL );
-
     /*
      * cancel and join any remaining pthreads
      * to ensure their resources are freed
@@ -261,8 +254,6 @@
         Thread_t *pxThread = ( Thread_t * ) listGET_LIST_ITEM_OWNER( pxIterator );
 
         pthread_cancel( pxThread->pthread );
-        event_signal( pxThread->ev );
-
         pthread_join( pxThread->pthread, NULL );
         event_delete( pxThread->ev );
     }
@@ -276,14 +267,15 @@
 
 void vPortEndScheduler( void )
 {
-    Thread_t * xCurrentThread;
+    /* Stop the timer tick thread. */
+    pthread_cancel( hTimerTickThread );
+    pthread_join( hTimerTickThread, NULL );
 
     /* Signal the scheduler to exit its loop. */
     xSchedulerEnd = pdTRUE;
     ( void ) pthread_kill( hMainThread, SIG_RESUME );
 
-    xCurrentThread = prvGetThreadFromTask( xTaskGetCurrentTaskHandle() );
-    prvSuspendSelf( xCurrentThread );
+    pthread_exit( NULL );
 }
 /*-----------------------------------------------------------*/
 
@@ -378,19 +370,24 @@
 
 static void* prvTimerTickHandler(void *arg)
 {
-    while( xTimerTickThreadShouldRun )
+    for(;;)
     {
         /*
          * signal to the active task to cause tick handling or
          * preemption (if enabled)
          */
-        Thread_t * thread = prvGetThreadFromTask( xTaskGetCurrentTaskHandle() );
-        pthread_kill( thread->pthread, SIGALRM );
+        TaskHandle_t hCurrentTask;
+        Thread_t * thread;
 
+        hCurrentTask = xTaskGetCurrentTaskHandle();
+        if( hCurrentTask != NULL )
+        {
+            thread = prvGetThreadFromTask( hCurrentTask );
+            pthread_kill( thread->pthread, SIGALRM );
+        }
         usleep( portTICK_RATE_MICROSECONDS );
+	pthread_testcancel();
     }
-
-    return NULL;
 }
 
 /*
@@ -399,7 +396,6 @@
  */
 void prvSetupTimerInterrupt( void )
 {
-    xTimerTickThreadShouldRun = true;
     pthread_create( &hTimerTickThread, NULL, prvTimerTickHandler, NULL );
 
     prvStartTimeNs = prvGetTimeNs();
@@ -463,13 +459,14 @@
     Thread_t * pxThreadToCancel = prvGetThreadFromTask( pxTaskToDelete );
 
     /* Remove the thread from xThreadList. */
+    vPortEnterCritical();
     uxListRemove( &pxThreadToCancel->xThreadListItem );
+    vPortExitCritical();
 
     /*
      * The thread has already been suspended so it can be safely cancelled.
      */
     pthread_cancel( pxThreadToCancel->pthread );
-    event_signal( pxThreadToCancel->ev );
     pthread_join( pxThreadToCancel->pthread, NULL );
     event_delete( pxThreadToCancel->ev );
 }