commit a49c35b5dc0f1f521eef3ef993d401af7f26f439
author kakkoko <parenthesized.ko@gmail.com> Wed Oct 16 18:36:20 2024 +0900
committer GitHub <noreply@github.com> Wed Oct 16 15:06:20 2024 +0530
tree fae8dc39510f84c1ce47142a7052a41c085e725a
parent 5f3bab1a3242640c6e031d9cfb1be756bd76fb3c

Fix incorrect error checking of prvCreateIdleTasks (#1158)

In environments that do not support static allocation
(configSUPPORT_STATIC_ALLOCATION == 0), at prvCreateIdleTasks(), call
xCreateTask() and compare its return value to pdFAIL to check whether
xCreateTask() failed. However, xCreateTask() returns
errCOULD_NOT_ALLOCATE_REQUIRED_MEMORY as the error value, so the
result of this comparison is always false.

This commit fixes this problem by changing the return value comparison
to pdPASS instead of pdFAIL.

tasks.c

diff --git a/tasks.c b/tasks.c
index 1be3fca..6d86326 100644
--- a/tasks.c
+++ b/tasks.c
@@ -3630,7 +3630,7 @@
         #endif /* configSUPPORT_STATIC_ALLOCATION */
 
         /* Break the loop if any of the idle task is failed to be created. */
-        if( xReturn == pdFAIL )
+        if( xReturn != pdPASS )
         {
             break;
         }