Explicitly depend on //absl/strings:string_view where used. Traditionally, `//absl/strings` provided string_view.h, but it is its own target now and we should depend on it whenever we include `absl/strings/string_view.h`, see comment here: https://github.com/abseil/abseil-cpp/blob/a690167a55b9e210b7884d311759977c0f5669c9/absl/strings/BUILD.bazel#L94-L99 Apply this strict reading to absl itself. In some cases, this also allowed to remove a dependency on the bigger `//absl/strings` library. PiperOrigin-RevId: 971474577 Change-Id: Ia38c24dab1402e679660081b5bfa39d1dfff746d
diff --git a/absl/strings/BUILD.bazel b/absl/strings/BUILD.bazel index 7f8ca5f..25d9599 100644 --- a/absl/strings/BUILD.bazel +++ b/absl/strings/BUILD.bazel
@@ -211,6 +211,7 @@ copts = ABSL_TEST_COPTS, visibility = ["//visibility:private"], deps = [ + ":string_view", ":strings", "@googletest//:gtest", "@googletest//:gtest_main", @@ -245,6 +246,7 @@ ":charset", ":cord", ":str_format", + ":string_view", ":strings", "//absl/base:core_headers", "//absl/container:fixed_array", @@ -265,6 +267,7 @@ tags = ["benchmark"], visibility = ["//visibility:private"], deps = [ + ":string_view", ":strings", "//absl/base:raw_logging_internal", "@google_benchmark//:benchmark_main", @@ -315,6 +318,7 @@ copts = ABSL_TEST_COPTS, visibility = ["//visibility:private"], deps = [ + ":string_view", ":strings", "//absl/base:core_headers", "@googletest//:gtest", @@ -517,6 +521,7 @@ visibility = ["//visibility:private"], deps = [ ":charset", + ":string_view", ":strings", "@googletest//:gtest", "@googletest//:gtest_main", @@ -549,6 +554,7 @@ "//visibility:private", ], deps = [ + ":string_view", ":strings", "//absl/base:config", "//absl/base:core_headers", @@ -573,7 +579,7 @@ deps = [ ":cord_internal", ":cord_rep_test_util", - ":strings", + ":string_view", "//absl/base:config", "@googletest//:gtest", "@googletest//:gtest_main", @@ -590,6 +596,7 @@ deps = [ ":cord_internal", ":cord_rep_test_util", + ":string_view", ":strings", "//absl/base:config", "//absl/base:raw_logging_internal", @@ -609,6 +616,7 @@ deps = [ ":cord_internal", ":cord_rep_test_util", + ":string_view", ":strings", "//absl/base:config", "//absl/base:raw_logging_internal", @@ -627,7 +635,7 @@ ":cord", ":cord_internal", ":cord_rep_test_util", - ":strings", + ":string_view", "//absl/base:config", "//absl/base:raw_logging_internal", "@googletest//:gtest", @@ -698,6 +706,7 @@ ":cordz_update_tracker", ":internal", ":resize_and_overwrite", + ":string_view", ":strings", "//absl/base:config", "//absl/base:core_headers", @@ -956,7 +965,7 @@ deps = [ ":cord", ":cord_internal", - ":strings", + ":string_view", "//absl/base:config", ], ) @@ -969,7 +978,7 @@ linkopts = ABSL_DEFAULT_LINKOPTS, deps = [ ":cord_internal", - ":strings", + ":string_view", "//absl/base:config", "//absl/base:raw_logging_internal", "//absl/types:span", @@ -1035,6 +1044,7 @@ ":cordz_test_helpers", ":cordz_update_tracker", ":str_format", + ":string_view", ":strings", "//absl/base:config", "//absl/base:core_headers", @@ -1078,6 +1088,7 @@ ":cordz_statistics", ":cordz_test_helpers", ":cordz_update_tracker", + ":string_view", ":strings", "//absl/base:config", "//absl/base:core_headers", @@ -1094,6 +1105,7 @@ copts = ABSL_TEST_COPTS, visibility = ["//visibility:private"], deps = [ + ":string_view", ":strings", "//absl/base:core_headers", "@googletest//:gtest", @@ -1138,6 +1150,7 @@ copts = ABSL_TEST_COPTS, visibility = ["//visibility:private"], deps = [ + ":string_view", ":strings", "@googletest//:gtest", "@googletest//:gtest_main", @@ -1150,6 +1163,7 @@ copts = ABSL_TEST_COPTS, visibility = ["//visibility:private"], deps = [ + ":string_view", ":strings", "//absl/base:core_headers", "//absl/base:dynamic_annotations", @@ -1170,6 +1184,7 @@ tags = ["benchmark"], visibility = ["//visibility:private"], deps = [ + ":string_view", ":strings", "//absl/base:raw_logging_internal", "@google_benchmark//:benchmark_main", @@ -1226,6 +1241,7 @@ copts = ABSL_TEST_COPTS, visibility = ["//visibility:private"], deps = [ + ":string_view", ":strings", "//absl/base:core_headers", "//absl/memory", @@ -1255,6 +1271,7 @@ visibility = ["//visibility:private"], deps = [ ":str_format", + ":string_view", ":strings", "//absl/base:config", "@googletest//:gtest", @@ -1271,6 +1288,7 @@ visibility = ["//visibility:private"], deps = [ ":str_format", + ":string_view", ":strings", "//absl/random", "//absl/random:distributions", @@ -1290,6 +1308,7 @@ deps = [ ":internal", ":pow10_helper", + ":string_view", ":strings", "//absl/base:config", "//absl/cleanup", @@ -1310,6 +1329,7 @@ tags = ["benchmark"], visibility = ["//visibility:private"], deps = [ + ":string_view", ":strings", "//absl/base:raw_logging_internal", "//absl/random", @@ -1325,6 +1345,7 @@ copts = ABSL_TEST_COPTS, visibility = ["//visibility:private"], deps = [ + ":string_view", ":strings", "@googletest//:gtest", "@googletest//:gtest_main", @@ -1338,6 +1359,7 @@ deps = [ ":pow10_helper", ":str_format", + ":string_view", ":strings", "@googletest//:gtest", "@googletest//:gtest_main", @@ -1369,6 +1391,7 @@ ], copts = ABSL_TEST_COPTS, deps = [ + ":string_view", ":strings", "//absl/base:config", "@googletest//:gtest", @@ -1434,6 +1457,7 @@ visibility = ["//visibility:private"], deps = [ ":internal", + ":string_view", ":strings", "//absl/base:config", "//absl/base:core_headers", @@ -1458,6 +1482,7 @@ ":cord", ":str_format", ":str_format_internal", + ":string_view", ":strings", "//absl/base:config", "//absl/base:core_headers", @@ -1477,7 +1502,7 @@ deps = [ ":str_format", ":str_format_internal", - ":strings", + ":string_view", "//absl/random", "@googletest//:gtest", "@googletest//:gtest_main", @@ -1535,6 +1560,7 @@ deps = [ ":str_format", ":str_format_internal", + ":string_view", ":strings", "//absl/base", "//absl/base:config", @@ -1610,6 +1636,7 @@ visibility = ["//visibility:private"], deps = [ ":str_format", + ":string_view", ":strings", "//absl/base", ], @@ -1643,6 +1670,7 @@ ], deps = [ ":str_format", + ":string_view", ":strings", "//absl/base:config", "//absl/log/internal:container",
diff --git a/absl/strings/CMakeLists.txt b/absl/strings/CMakeLists.txt index 3ea24fe..9178ed3 100644 --- a/absl/strings/CMakeLists.txt +++ b/absl/strings/CMakeLists.txt
@@ -232,6 +232,7 @@ COPTS ${ABSL_TEST_COPTS} DEPS + absl::string_view absl::strings absl::base GTest::gmock_main @@ -246,6 +247,7 @@ ${ABSL_TEST_COPTS} DEPS absl::charset + absl::string_view absl::strings absl::str_format absl::core_headers @@ -286,6 +288,7 @@ COPTS ${ABSL_TEST_COPTS} DEPS + absl::string_view absl::strings absl::core_headers GTest::gmock_main @@ -369,6 +372,7 @@ COPTS ${ABSL_TEST_COPTS} DEPS + absl::string_view absl::strings absl::core_headers GTest::gmock_main @@ -382,6 +386,7 @@ COPTS ${ABSL_TEST_COPTS} DEPS + absl::string_view absl::strings GTest::gmock_main ) @@ -394,6 +399,7 @@ COPTS ${ABSL_TEST_COPTS} DEPS + absl::string_view absl::strings absl::core_headers absl::dynamic_annotations @@ -439,6 +445,7 @@ COPTS ${ABSL_TEST_COPTS} DEPS + absl::string_view absl::strings absl::base absl::core_headers @@ -454,6 +461,7 @@ COPTS ${ABSL_TEST_COPTS} DEPS + absl::string_view absl::strings absl::str_format absl::config @@ -478,6 +486,7 @@ absl::pow10_helper absl::random_distributions absl::random_random + absl::string_view absl::strings absl::strings_internal GTest::gmock_main @@ -491,6 +500,7 @@ COPTS ${ABSL_TEST_COPTS} DEPS + absl::string_view absl::strings absl::base GTest::gmock_main @@ -504,6 +514,7 @@ COPTS ${ABSL_TEST_COPTS} DEPS + absl::string_view absl::strings GTest::gmock_main ) @@ -516,6 +527,7 @@ COPTS ${ABSL_TEST_COPTS} DEPS + absl::string_view absl::strings absl::str_format absl::pow10_helper @@ -547,6 +559,7 @@ COPTS ${ABSL_TEST_COPTS} DEPS + absl::string_view absl::strings absl::config GTest::gmock_main @@ -593,6 +606,7 @@ ${ABSL_DEFAULT_COPTS} DEPS absl::bits + absl::string_view absl::strings absl::config absl::core_headers @@ -619,6 +633,7 @@ absl::core_headers absl::span absl::str_format + absl::string_view absl::strings GTest::gmock_main ) @@ -634,7 +649,7 @@ absl::random_random absl::str_format absl::str_format_internal - absl::strings + absl::string_view GTest::gmock_main ) @@ -692,6 +707,7 @@ absl::span absl::str_format absl::str_format_internal + absl::string_view absl::strings GTest::gmock_main ) @@ -799,6 +815,7 @@ absl::inlined_vector absl::layout absl::raw_logging_internal + absl::string_view absl::strings absl::throw_delegate absl::type_traits @@ -1085,6 +1102,7 @@ absl::optional absl::raw_logging_internal absl::span + absl::string_view absl::strings absl::strings_append_and_overwrite absl::strings_resize_and_overwrite @@ -1105,7 +1123,7 @@ absl::config absl::cord_internal absl::raw_logging_internal - absl::strings + absl::string_view TESTONLY ) @@ -1120,7 +1138,7 @@ absl::config absl::cord absl::cord_internal - absl::strings + absl::string_view TESTONLY PUBLIC ) @@ -1171,6 +1189,7 @@ absl::log absl::random_random absl::str_format + absl::string_view absl::strings GTest::gmock_main ) @@ -1188,7 +1207,7 @@ absl::cord_internal absl::cord_rep_test_util absl::core_headers - absl::strings + absl::string_view GTest::gmock_main ) @@ -1207,6 +1226,7 @@ absl::cord_rep_test_util absl::core_headers absl::raw_logging_internal + absl::string_view absl::strings GTest::gmock_main ) @@ -1225,6 +1245,7 @@ absl::cord_rep_test_util absl::core_headers absl::raw_logging_internal + absl::string_view absl::strings GTest::gmock_main ) @@ -1243,7 +1264,7 @@ absl::cord_rep_test_util absl::core_headers absl::raw_logging_internal - absl::strings + absl::string_view GTest::gmock_main ) @@ -1283,6 +1304,7 @@ absl::config absl::core_headers absl::raw_logging_internal + absl::string_view absl::strings GTest::gmock_main )