Explicitly depend on //absl/strings:string_view where used. Traditionally, `//absl/strings` provided string_view.h, but it is its own target now and we should depend on it whenever we include `absl/strings/string_view.h`, see comment here: https://github.com/abseil/abseil-cpp/blob/a690167a55b9e210b7884d311759977c0f5669c9/absl/strings/BUILD.bazel#L94-L99 Apply this strict reading to absl itself. In some cases, this also allowed to remove a dependency on the bigger `//absl/strings` library. PiperOrigin-RevId: 971558541 Change-Id: I8d193322f0aa4e16f0b551a6b396387807d4c79b
diff --git a/absl/log/internal/BUILD.bazel b/absl/log/internal/BUILD.bazel index d9cb7b2..42114ed 100644 --- a/absl/log/internal/BUILD.bazel +++ b/absl/log/internal/BUILD.bazel
@@ -85,6 +85,7 @@ "//absl/debugging:leak_check", "//absl/strings", "//absl/strings:has_ostream_operator", + "//absl/strings:string_view", ], ) @@ -144,6 +145,7 @@ "//absl/base:log_severity", "//absl/strings", "//absl/strings:str_format", + "//absl/strings:string_view", "//absl/time", "//absl/types:span", ], @@ -165,6 +167,7 @@ "//absl/base:log_severity", "//absl/base:raw_logging_internal", "//absl/strings", + "//absl/strings:string_view", "//absl/time", ], ) @@ -216,6 +219,7 @@ "//absl/log:log_sink_registry", "//absl/strings", "//absl/strings:internal", + "//absl/strings:string_view", "//absl/time", "//absl/types:source_location", "//absl/types:span", @@ -229,8 +233,8 @@ linkopts = ABSL_DEFAULT_LINKOPTS, deps = [ "//absl/base:config", - "//absl/strings", "//absl/strings:internal", + "//absl/strings:string_view", "//absl/types:span", ], ) @@ -257,7 +261,7 @@ "//absl/log:globals", "//absl/log:log_entry", "//absl/log:log_sink", - "//absl/strings", + "//absl/strings:string_view", "//absl/synchronization", "//absl/types:span", ], @@ -284,7 +288,7 @@ "//absl/base:config", "//absl/base:core_headers", "//absl/base:log_severity", - "//absl/strings", + "//absl/strings:string_view", ], ) @@ -318,6 +322,7 @@ "//absl/base:core_headers", "//absl/functional:any_invocable", "//absl/strings", + "//absl/strings:string_view", ], ) @@ -333,7 +338,6 @@ deps = [ ":proto", "//absl/base:config", - "//absl/strings", "//absl/types:span", "//absl/types:variant", ], @@ -365,6 +369,7 @@ "//absl/base:log_severity", "//absl/log:log_entry", "//absl/strings", + "//absl/strings:string_view", "//absl/time", ] + select({ "@rules_cc//cc/compiler:msvc-cl": [], @@ -413,7 +418,7 @@ "//absl/base:core_headers", "//absl/base:log_severity", "//absl/log:log_entry", - "//absl/strings", + "//absl/strings:string_view", "//absl/time", "@googletest//:gtest", ] + select({ @@ -444,7 +449,7 @@ "//absl/base", "//absl/base:config", "//absl/base:core_headers", - "//absl/strings", + "//absl/strings:string_view", "//absl/types:span", ], ) @@ -457,7 +462,7 @@ linkopts = ABSL_DEFAULT_LINKOPTS, deps = [ "//absl/base:config", - "//absl/strings", + "//absl/strings:string_view", ], ) @@ -481,6 +486,7 @@ "//absl/base:no_destructor", "//absl/base:nullability", "//absl/strings", + "//absl/strings:string_view", "//absl/synchronization", ], )