Change the default visibility for packages to //visibility:private and then change individual build rules back to their prior visibility. The motivation for this change is making sure future additions are private by default so that new rules are not accidentally public. Some of the rules that are currently public were not meant to be, and the fact that they are marked public does not mean they should be used. As always, the rule is never spell out anything with the word internal (or any synonym for internal). Some of these accidentally public rules will be manually corrected with future changes. PiperOrigin-RevId: 942876114 Change-Id: Ife012abf5c72f6653be44239e7840ed99c951114
diff --git a/absl/base/BUILD.bazel b/absl/base/BUILD.bazel index ea4db17..25c32f6 100644 --- a/absl/base/BUILD.bazel +++ b/absl/base/BUILD.bazel
@@ -25,7 +25,7 @@ ) package( - default_visibility = ["//visibility:public"], + default_visibility = ["//visibility:private"], features = [ "header_modules", "layering_check", @@ -102,6 +102,7 @@ hdrs = ["log_severity.h"], copts = ABSL_DEFAULT_COPTS, linkopts = ABSL_DEFAULT_LINKOPTS, + visibility = ["//visibility:public"], deps = [ ":config", ":core_headers", @@ -113,6 +114,7 @@ hdrs = ["no_destructor.h"], copts = ABSL_DEFAULT_COPTS, linkopts = ABSL_DEFAULT_LINKOPTS, + visibility = ["//visibility:public"], deps = [ ":config", ":nullability", @@ -124,6 +126,7 @@ hdrs = ["nullability.h"], copts = ABSL_DEFAULT_COPTS, linkopts = ABSL_DEFAULT_LINKOPTS, + visibility = ["//visibility:public"], deps = [":config"], ) @@ -192,6 +195,7 @@ ], copts = ABSL_DEFAULT_COPTS, linkopts = ABSL_DEFAULT_LINKOPTS, + visibility = ["//visibility:public"], ) cc_library( @@ -222,6 +226,7 @@ ], copts = ABSL_DEFAULT_COPTS, linkopts = ABSL_DEFAULT_LINKOPTS, + visibility = ["//visibility:public"], deps = [ ":config", ":core_headers", @@ -240,6 +245,7 @@ ], copts = ABSL_DEFAULT_COPTS, linkopts = ABSL_DEFAULT_LINKOPTS, + visibility = ["//visibility:public"], deps = [ ":config", ], @@ -331,6 +337,7 @@ "@rules_cc//cc/compiler:emscripten": [], "//conditions:default": ["-pthread"], }) + ABSL_DEFAULT_LINKOPTS, + visibility = ["//visibility:public"], deps = [ ":atomic_hook", ":base_internal", @@ -425,6 +432,7 @@ ], copts = ABSL_DEFAULT_COPTS, linkopts = ABSL_DEFAULT_LINKOPTS, + visibility = ["//visibility:public"], deps = [ ":config", ":raw_logging_internal", @@ -491,6 +499,7 @@ hdrs = ["internal/exception_safety_testing.h"], copts = ABSL_TEST_COPTS, linkopts = ABSL_DEFAULT_LINKOPTS, + visibility = ["//absl:__subpackages__"], deps = [ ":config", ":pretty_function", @@ -523,6 +532,9 @@ srcs = ["spinlock_test_common.cc"], copts = ABSL_TEST_COPTS, linkopts = ABSL_DEFAULT_LINKOPTS, + visibility = [ + "//absl:friends", + ], deps = [ ":base", ":base_internal", @@ -924,6 +936,7 @@ hdrs = ["fast_type_id.h"], copts = ABSL_DEFAULT_COPTS, linkopts = ABSL_DEFAULT_LINKOPTS, + visibility = ["//visibility:public"], deps = [ ":config", ], @@ -950,6 +963,7 @@ ], copts = ABSL_DEFAULT_COPTS, linkopts = ABSL_DEFAULT_LINKOPTS, + visibility = ["//visibility:public"], deps = [ ":config", ":core_headers", @@ -1085,6 +1099,10 @@ hdrs = ["internal/iterator_traits_test_helper.h"], copts = ABSL_DEFAULT_COPTS, linkopts = ABSL_DEFAULT_LINKOPTS, + visibility = [ + "//absl:__subpackages__", + "//cloud/blockstore/metallica/util:__pkg__", + ], deps = [":config"], )