Explicitly depend on //absl/strings:string_view where used. Traditionally, `//absl/strings` provided string_view.h, but it is its own target now and we should depend on it whenever we include `absl/strings/string_view.h`, see comment here: https://github.com/abseil/abseil-cpp/blob/a690167a55b9e210b7884d311759977c0f5669c9/absl/strings/BUILD.bazel#L94-L99 Apply this strict reading to absl itself. In some cases, this also allowed to remove a dependency on the bigger `//absl/strings` library. PiperOrigin-RevId: 971981362 Change-Id: I66147bdcdc00c6d9c4602ac1af080487017387d3
diff --git a/absl/status/BUILD.bazel b/absl/status/BUILD.bazel index 5a611ec..3508b11 100644 --- a/absl/status/BUILD.bazel +++ b/absl/status/BUILD.bazel
@@ -71,6 +71,7 @@ "//absl/strings", "//absl/strings:cord", "//absl/strings:str_format", + "//absl/strings:string_view", "//absl/types:optional", "//absl/types:optional_ref", "//absl/types:source_location", @@ -88,6 +89,7 @@ "//absl/strings", "//absl/strings:cord", "//absl/strings:str_format", + "//absl/strings:string_view", "//absl/types:source_location", "@googletest//:gtest", "@googletest//:gtest_main", @@ -129,6 +131,7 @@ "//absl/strings", "//absl/strings:has_ostream_operator", "//absl/strings:str_format", + "//absl/strings:string_view", "//absl/types:source_location", "//absl/types:span", "//absl/types:variant", @@ -147,6 +150,7 @@ "//absl/base", "//absl/memory", "//absl/strings", + "//absl/strings:string_view", "//absl/types:any", "//absl/types:source_location", "//absl/types:variant", @@ -184,6 +188,7 @@ "//absl/strings", "//absl/strings:cord", "//absl/strings:internal", + "//absl/strings:string_view", "//absl/strings:stringify_stream", "//absl/time", "//absl/types:source_location", @@ -205,7 +210,7 @@ "//absl/log:flags", "//absl/log:log_entry", "//absl/log:log_sink", - "//absl/strings", + "//absl/strings:string_view", "//absl/types:source_location", "@googletest//:gtest", "@googletest//:gtest_main", @@ -273,7 +278,7 @@ ":status", ":status_matchers", ":statusor", - "//absl/strings", + "//absl/strings:string_view", "@googletest//:gtest", "@googletest//:gtest_main", ], @@ -290,7 +295,7 @@ ":status", ":status_matchers", ":statusor", - "//absl/strings", + "//absl/strings:string_view", "@googletest//:gtest", "@googletest//:gtest_main", ],
diff --git a/absl/status/CMakeLists.txt b/absl/status/CMakeLists.txt index 90d4baf..f7da3db 100644 --- a/absl/status/CMakeLists.txt +++ b/absl/status/CMakeLists.txt
@@ -47,6 +47,7 @@ absl::stacktrace absl::str_format absl::strerror + absl::string_view absl::strings absl::symbolize PUBLIC @@ -63,6 +64,7 @@ absl::status absl::source_location absl::str_format + absl::string_view absl::strings GTest::gmock_main ) @@ -87,6 +89,7 @@ absl::status absl::source_location absl::str_format + absl::string_view absl::strings absl::type_traits absl::utility @@ -106,6 +109,7 @@ absl::status_matchers absl::statusor absl::source_location + absl::string_view absl::strings GTest::gmock_main ) @@ -128,6 +132,7 @@ absl::source_location absl::span absl::status + absl::string_view absl::strings absl::time PUBLIC @@ -143,6 +148,7 @@ DEPS absl::core_headers absl::flags + absl::string_view GTest::gmock_main absl::log absl::log_entry @@ -230,6 +236,7 @@ absl::status absl::statusor absl::status_matchers + absl::string_view GTest::gmock_main ) @@ -246,5 +253,6 @@ absl::status absl::statusor absl::status_matchers + absl::string_view GTest::gmock_main )