Explicitly depend on //absl/strings:string_view where used. Traditionally, `//absl/strings` provided string_view.h, but it is its own target now and we should depend on it whenever we include `absl/strings/string_view.h`, see comment here: https://github.com/abseil/abseil-cpp/blob/a690167a55b9e210b7884d311759977c0f5669c9/absl/strings/BUILD.bazel#L94-L99 Apply this strict reading to absl itself. In some cases, this also allowed to remove a dependency on the bigger `//absl/strings` library. PiperOrigin-RevId: 971532529 Change-Id: I16cc171341e530619970c1e9c167591b9b316806
diff --git a/absl/flags/BUILD.bazel b/absl/flags/BUILD.bazel index 56dc2f5..a336794 100644 --- a/absl/flags/BUILD.bazel +++ b/absl/flags/BUILD.bazel
@@ -48,7 +48,7 @@ ], deps = [ "//absl/base:config", - "//absl/strings", + "//absl/strings:string_view", ], ) @@ -72,7 +72,7 @@ "//absl/base:config", "//absl/base:core_headers", "//absl/base:no_destructor", - "//absl/strings", + "//absl/strings:string_view", "//absl/synchronization", ], ) @@ -96,6 +96,7 @@ "//absl/base:core_headers", "//absl/base:no_destructor", "//absl/strings", + "//absl/strings:string_view", "//absl/synchronization", ], ) @@ -118,6 +119,7 @@ "//absl/numeric:int128", "//absl/strings", "//absl/strings:str_format", + "//absl/strings:string_view", "//absl/types:optional", ], ) @@ -157,7 +159,7 @@ "//absl/base:config", "//absl/base:fast_type_id", "//absl/base:nullability", - "//absl/strings", + "//absl/strings:string_view", "//absl/types:optional", ], ) @@ -181,7 +183,7 @@ ":commandlineflag", ":commandlineflag_internal", "//absl/base:config", - "//absl/strings", + "//absl/strings:string_view", ], ) @@ -208,6 +210,7 @@ "//absl/base:no_destructor", "//absl/container:flat_hash_map", "//absl/strings", + "//absl/strings:string_view", "//absl/synchronization", ], ) @@ -239,6 +242,7 @@ "//absl/memory", "//absl/meta:type_traits", "//absl/strings", + "//absl/strings:string_view", "//absl/synchronization", "//absl/utility", ], @@ -261,7 +265,7 @@ "//absl/base:config", "//absl/base:core_headers", "//absl/base:nullability", - "//absl/strings", + "//absl/strings:string_view", ], ) @@ -292,6 +296,7 @@ "//absl/base:core_headers", "//absl/base:no_destructor", "//absl/strings", + "//absl/strings:string_view", "//absl/synchronization", ], ) @@ -312,7 +317,7 @@ "//absl/base:config", "//absl/base:core_headers", "//absl/base:raw_logging_internal", - "//absl/strings", + "//absl/strings:string_view", "//absl/synchronization", ], ) @@ -343,6 +348,7 @@ "//absl/base:core_headers", "//absl/base:no_destructor", "//absl/strings", + "//absl/strings:string_view", "//absl/synchronization", ], ) @@ -373,6 +379,7 @@ ":reflection", "//absl/memory", "//absl/strings", + "//absl/strings:string_view", "@googletest//:gtest", "@googletest//:gtest_main", ], @@ -421,6 +428,7 @@ "//absl/base:raw_logging_internal", "//absl/numeric:int128", "//absl/strings", + "//absl/strings:string_view", "//absl/time", "@googletest//:gtest", "@googletest//:gtest_main", @@ -445,7 +453,7 @@ ":marshalling", ":parse", ":reflection", - "//absl/strings", + "//absl/strings:string_view", "//absl/time", "@google_benchmark//:benchmark_main", ], @@ -492,6 +500,7 @@ "//absl/base:scoped_set_env", "//absl/log", "//absl/strings", + "//absl/strings:string_view", "//absl/types:span", "@googletest//:gtest", "@googletest//:gtest_main", @@ -528,6 +537,7 @@ deps = [ ":program_name", "//absl/strings", + "//absl/strings:string_view", "@googletest//:gtest", "@googletest//:gtest_main", ], @@ -594,6 +604,7 @@ ":path_util", ":program_name", "//absl/strings", + "//absl/strings:string_view", "@googletest//:gtest", "@googletest//:gtest_main", ], @@ -624,6 +635,7 @@ ":usage", ":usage_internal", "//absl/strings", + "//absl/strings:string_view", "@googletest//:gtest", ], )
diff --git a/absl/flags/CMakeLists.txt b/absl/flags/CMakeLists.txt index 0c75c93..82b752d 100644 --- a/absl/flags/CMakeLists.txt +++ b/absl/flags/CMakeLists.txt
@@ -26,7 +26,7 @@ ${ABSL_DEFAULT_LINKOPTS} DEPS absl::config - absl::strings + absl::string_view PUBLIC ) @@ -47,7 +47,7 @@ absl::core_headers absl::no_destructor absl::flags_path_util - absl::strings + absl::string_view absl::synchronization PUBLIC ) @@ -70,6 +70,7 @@ absl::flags_program_name absl::core_headers absl::no_destructor + absl::string_view absl::strings absl::synchronization ) @@ -91,6 +92,7 @@ absl::log_severity absl::int128 absl::optional + absl::string_view absl::strings absl::str_format ) @@ -130,7 +132,7 @@ absl::flags_commandlineflag_internal absl::nullability absl::optional - absl::strings + absl::string_view ) # Internal-only target, do not depend on directly. @@ -149,7 +151,7 @@ absl::config absl::flags_commandlineflag absl::flags_commandlineflag_internal - absl::strings + absl::string_view ) absl_cc_library( @@ -170,6 +172,7 @@ absl::flags_commandlineflag absl::flags_private_handle_accessor absl::flags_config + absl::string_view absl::strings absl::synchronization absl::flat_hash_map @@ -247,6 +250,7 @@ absl::flags_private_handle_accessor absl::flags_program_name absl::flags_reflection + absl::string_view absl::strings absl::synchronization ) @@ -268,7 +272,7 @@ absl::flags_usage_internal absl::no_destructor absl::raw_logging_internal - absl::strings + absl::string_view absl::synchronization ) @@ -298,6 +302,7 @@ absl::flags_reflection absl::flags_usage absl::no_destructor + absl::string_view absl::strings absl::synchronization ) @@ -319,6 +324,7 @@ absl::flags_private_handle_accessor absl::flags_reflection absl::memory + absl::string_view absl::strings GTest::gtest_main ) @@ -353,6 +359,7 @@ absl::flags_reflection absl::int128 absl::raw_logging_internal + absl::string_view absl::strings absl::time GTest::gtest_main @@ -386,6 +393,7 @@ absl::log absl::scoped_set_env absl::span + absl::string_view absl::strings GTest::gmock_main ) @@ -411,6 +419,7 @@ ${ABSL_TEST_COPTS} DEPS absl::flags_program_name + absl::string_view absl::strings GTest::gtest_main ) @@ -457,6 +466,7 @@ absl::flags_config absl::flags_path_util absl::flags_program_name + absl::string_view absl::strings GTest::gtest_main ) @@ -476,6 +486,7 @@ absl::flags_parse absl::flags_reflection absl::flags_usage + absl::string_view absl::strings GTest::gmock )