Avoid some repetition in _make_analysis_test (#197)
diff --git a/lib/unittest.bzl b/lib/unittest.bzl
index 986a807..873d8f0 100644
--- a/lib/unittest.bzl
+++ b/lib/unittest.bzl
@@ -193,20 +193,18 @@
if expect_failure:
changed_settings["//command_line_option:allow_analysis_failures"] = "True"
+ target_attr_kwargs = {}
if changed_settings:
test_transition = analysis_test_transition(
settings = changed_settings,
)
- attrs["target_under_test"] = attr.label(
- aspects = [_action_retrieving_aspect],
- cfg = test_transition,
- mandatory = True,
- )
- else:
- attrs["target_under_test"] = attr.label(
- aspects = [_action_retrieving_aspect],
- mandatory = True,
- )
+ target_attr_kwargs["cfg"] = test_transition
+
+ attrs["target_under_test"] = attr.label(
+ aspects = [_action_retrieving_aspect],
+ mandatory = True,
+ **target_attr_kwargs
+ )
return rule(
impl,
