Don't flag conditional expressions that call rules as no-effect (#1541)

BUILD files don't support `if` statements, so a conditional expression
is the only way to choose between rules inline, as in rules_java's
`toolchains/BUILD`:

```starlark
toolchain_type(
    name = "toolchain_type",
) if bazel_features.java._toolchain_type_in_rules_java else alias(
    name = "toolchain_type",
    actual = "@bazel_tools//tools/jdk:toolchain_type",
)
```

`no-effect` flagged such statements even though they call a rule, which
required a `# buildifier: disable=no-effect` comment. A conditional
expression statement is now treated like a call if either of its
branches is a call, possibly nested in parentheses or further
conditional expressions. Conditional expressions without calls are still
flagged.
2 files changed
tree: b2250b7cfd45bc5c454a2f7671d2956a21a58feb
  1. .bazelci/
  2. .github/
  3. api_proto/
  4. build/
  5. build_proto/
  6. buildifier/
  7. buildozer/
  8. bzlenv/
  9. config/
  10. convertast/
  11. deps_proto/
  12. differ/
  13. edit/
  14. extra_actions_base_proto/
  15. file/
  16. generatetables/
  17. labels/
  18. lang/
  19. release/
  20. tables/
  21. testutils/
  22. unused_deps/
  23. warn/
  24. wspace/
  25. .bazelrc
  26. .bazelversion
  27. .gitignore
  28. .mailmap
  29. .pre-commit-config.yaml
  30. AGENTS.md
  31. BUILD.bazel
  32. CODEOWNERS
  33. CONTRIBUTING.md
  34. CONTRIBUTORS
  35. go.mod
  36. go.sum
  37. launcher.js
  38. LICENSE
  39. MODULE.bazel
  40. README.md
  41. renovate.json
  42. status.py
  43. update_generated.sh
  44. WARNINGS.md
  45. WORKSPACE
  46. WORKSPACE.bzlmod
README.md

Buildtools for bazel

This repository contains developer tools for working with Google's bazel buildtool.

Build status

Setup

See instructions in each tool's directory.