Google Git
Sign in
pigweed / third_party / github / bazelbuild / rules_cc / 34f0e1f038cff9bf28d65d101c806b48f35bf92e
commit34f0e1f038cff9bf28d65d101c806b48f35bf92e[log] [tgz]
authorMarcel <maleo@google.com>Thu Dec 12 04:22:32 2024 -0800
committerCopybara-Service <copybara-worker@google.com>Thu Dec 12 04:23:15 2024 -0800
tree3068c77a6e302878c7f494615d92e5615de9f4fd
parent5be90a4e04e64df0e9d26382e1006d3df21aaa91 [diff]
Fix `ends_with()` for runfiles

Copybara Import from https://github.com/bazelbuild/rules_cc/pull/289

BEGIN_PUBLIC
Fix `ends_with()` for runfiles (#289)

This erroneously failed for single character path queries like `Rlocation("a")`.
This queries `ends_with("a", "/.")` under the hood which was erroneously returning `true` and hitting the early abort in https://github.com/bazelbuild/rules_cc/blob/5be90a4e04e64df0e9d26382e1006d3df21aaa91/cc/runfiles/runfiles.cc#L218-L222

Erroneous logic:
```cpp
std::string s = "a"; // any single character
s.rfind("/.") == std::string::npos == -1 == s.size()-suffix.size()
```

Closes #289
END_PUBLIC

COPYBARA_INTEGRATE_REVIEW=https://github.com/bazelbuild/rules_cc/pull/289 from mering:fix-ends-with 2aec586307875f0eba52806d21277104b4e70600
PiperOrigin-RevId: 705455341
Change-Id: I44c8f1037514aad13721f486e5105b7379476730
1 file changed
tree: 3068c77a6e302878c7f494615d92e5615de9f4fd
  1. .bazelci/
  2. .bcr/
  3. .github/
  4. cc/
  5. docs/
  6. examples/
  7. tests/
  8. .bazelignore
  9. .bazelrc
  10. .gitignore
  11. AUTHORS
  12. BUILD
  13. CODEOWNERS
  14. CONTRIBUTING.md
  15. ISSUE_TEMPLATE.md
  16. LICENSE
  17. MODULE.bazel
  18. README.md
  19. renovate.json
  20. WORKSPACE
  21. WORKSPACE.bzlmod
README.md

C++ rules for Bazel

  • Postsubmit Build status
  • Postsubmit + Current Bazel Incompatible flags Build status

This repository contains a Starlark implementation of C++ rules in Bazel.

The rules are being incrementally converted from their native implementations in the Bazel source tree.

For the list of C++ rules, see the Bazel documentation.

Getting Started

There is no need to use rules from this repository just yet. If you want to use rules_cc anyway, add the following to your WORKSPACE file:

load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")

http_archive(
    name = "rules_cc",
    urls = ["https://github.com/bazelbuild/rules_cc/archive/refs/tags/<VERSION>.tar.gz"],
    sha256 = "...",
)

Then, in your BUILD files, import and use the rules:

load("@rules_cc//cc:defs.bzl", "cc_library")

cc_library(
    ...
)

Using the rules_cc toolchain

This repo contains an auto-detecting toolchain that expects to find tools installed on your host machine. This is non-hermetic, and may have varying behaviors depending on the versions of tools found.

There are third-party contributed hermetic toolchains you may want to investigate:

If you'd like to use the cc toolchain defined in this repo, add this to your WORKSPACE after you include rules_cc:

load("@rules_cc//cc:repositories.bzl", "rules_cc_dependencies", "rules_cc_toolchains")

rules_cc_dependencies()

rules_cc_toolchains()

Migration Tools

This repository also contains migration tools that can be used to migrate your project for Bazel incompatible changes.

Legacy fields migrator

Script that migrates legacy crosstool fields into features (incompatible flag, tracking issue).

TLDR:

bazel run @rules_cc//tools/migration:legacy_fields_migrator -- \
  --input=my_toolchain/CROSSTOOL \
  --inline

Contributing

Bazel and rules_cc are the work of many contributors. We appreciate your help!

To contribute, please read the contribution guidelines: CONTRIBUTING.md.

Note that the rules_cc use the GitHub issue tracker for bug reports and feature requests only. For asking questions see: