Start converting pkg rules to a separate repo (#27)
- Move to ABSL flags.
- Add deps.bzl.
- Fix some docs. There is certainly more to do.
- Fix the tests to use the runfiles library rather than ad hoc methods
Note that the tests are now all in a distinct folder from the BUILD file
which contains the tools needed to create packages. This is an experiment
in packaging techniques for rules. The idea is that most users should be
able to import a "thin" version of a rule set. That would only include
the files needed to use the rule, but not those needed to test and or
package the rules. That would currently be all the *files* in pkg but
none of the folders.
A "thicker" version might include the tests, but at the cost of perhaps
making your workspace deps resolver bring in more things.
The "thickest" version would include all the code needed to repackage
and redistribute the rule set. That would be using the full source
distribution.
I may abandon this experiment and fold tests back together with the
sources, but doing so will not impact users of the tools, so that
would be transparent and harmless. So please indulge me for now.
diff --git a/pkg/tests/BUILD b/pkg/tests/BUILD
new file mode 100644
index 0000000..305c8eb
--- /dev/null
+++ b/pkg/tests/BUILD
@@ -0,0 +1,243 @@
+# -*- coding: utf-8 -*-
+licenses(["notice"]) # Apache 2.0
+
+load("@rules_pkg//:pkg.bzl", "pkg_deb", "pkg_tar")
+
+genrule(
+ name = "generate_files",
+ outs = [
+ "etc/nsswitch.conf",
+ "usr/titi",
+ ],
+ cmd = "for i in $(OUTS); do echo 1 >$$i; done",
+)
+
+filegroup(
+ name = "archive_testdata",
+ srcs = glob(["testdata/**"]),
+ visibility = ["//visibility:private"],
+)
+
+py_test(
+ name = "archive_test",
+ srcs = [
+ "archive_test.py",
+ ],
+ data = [":archive_testdata"],
+ python_version = "PY2",
+ srcs_version = "PY2AND3",
+ tags = [
+ # archive.py requires xzcat, which is not available by default on Mac
+ "noci",
+ # TODO(laszlocsomor): fix on Windows or describe why it cannot pass.
+ "no_windows",
+ ],
+ deps = [
+ "@rules_pkg//:archive",
+ "@bazel_tools//tools/python/runfiles",
+ ],
+)
+
+py_test(
+ name = "path_test",
+ srcs = ["path_test.py"],
+ data = ["@rules_pkg//:path.bzl"],
+ srcs_version = "PY2AND3",
+)
+
+py_test(
+ name = "make_rpm_test",
+ srcs = ["make_rpm_test.py"],
+ python_version = "PY2",
+ srcs_version = "PY2AND3",
+ # rpmbuild is not available in windows
+ tags = [
+ "no_windows",
+ ],
+ deps = [
+ "@rules_pkg//:make_rpm_lib",
+ ],
+)
+
+pkg_deb(
+ name = "test-deb",
+ built_using = "some_test_data (0.1.2)",
+ conffiles = [
+ "/etc/nsswitch.conf",
+ "/etc/other",
+ ],
+ config = ":testdata/config",
+ data = ":test-tar-gz.tar.gz",
+ depends = [
+ "dep1",
+ "dep2",
+ ],
+ description = "toto ®, Й, ק ,م, ๗, あ, 叶, 葉, 말, ü and é",
+ distribution = "trusty",
+ maintainer = "soméone@somewhere.com",
+ make_deb = "@rules_pkg//:make_deb",
+ package = "titi",
+ templates = ":testdata/templates",
+ urgency = "low",
+ version = "test",
+)
+
+[pkg_tar(
+ name = "test-tar-%s" % ext[1:],
+ srcs = [
+ ":etc/nsswitch.conf",
+ ":usr/titi",
+ ],
+ build_tar = "@rules_pkg//:build_tar",
+ extension = "tar%s" % ext,
+ mode = "0644",
+ modes = {"usr/titi": "0755"},
+ owner = "42.24",
+ ownername = "titi.tata",
+ ownernames = {"etc/nsswitch.conf": "tata.titi"},
+ owners = {"etc/nsswitch.conf": "24.42"},
+ package_dir = "/",
+ strip_prefix = ".",
+ symlinks = {"usr/bin/java": "/path/to/bin/java"},
+) for ext in [
+ "",
+ ".gz",
+ ".bz2",
+ ".xz", # This will breaks if xzcat is not installed
+]]
+
+[pkg_tar(
+ name = "test-tar-inclusion-%s" % ext,
+ build_tar = "@rules_pkg//:build_tar",
+ deps = [":test-tar-%s" % ext],
+) for ext in [
+ "",
+ "gz",
+ "bz2",
+ "xz",
+]]
+
+pkg_tar(
+ name = "test-tar-strip_prefix-empty",
+ srcs = [
+ ":etc/nsswitch.conf",
+ ],
+ build_tar = "@rules_pkg//:build_tar",
+ strip_prefix = "",
+)
+
+pkg_tar(
+ name = "test-tar-strip_prefix-none",
+ srcs = [
+ ":etc/nsswitch.conf",
+ ],
+ build_tar = "@rules_pkg//:build_tar",
+)
+
+pkg_tar(
+ name = "test-tar-strip_prefix-etc",
+ srcs = [
+ ":etc/nsswitch.conf",
+ ],
+ build_tar = "@rules_pkg//:build_tar",
+ strip_prefix = "etc",
+)
+
+pkg_tar(
+ name = "test-tar-strip_prefix-dot",
+ srcs = [
+ ":etc/nsswitch.conf",
+ ],
+ build_tar = "@rules_pkg//:build_tar",
+ strip_prefix = ".",
+)
+
+pkg_tar(
+ name = "test-tar-files_dict",
+ build_tar = "@rules_pkg//:build_tar",
+ files = {
+ ":etc/nsswitch.conf": "not-etc/mapped-filename.conf",
+ },
+)
+
+pkg_tar(
+ name = "test-tar-empty_files",
+ build_tar = "@rules_pkg//:build_tar",
+ empty_files = [
+ "/a",
+ "/b",
+ ],
+ mode = "0o777",
+)
+
+pkg_tar(
+ name = "test-tar-empty_dirs",
+ build_tar = "@rules_pkg//:build_tar",
+ empty_dirs = [
+ "/tmp",
+ "/pmt",
+ ],
+ mode = "0o777",
+)
+
+pkg_tar(
+ name = "test-tar-mtime",
+ srcs = [
+ ":etc/nsswitch.conf",
+ ],
+ build_tar = "@rules_pkg//:build_tar",
+ mtime = 946684740, # 1999-12-31, 23:59
+ portable_mtime = False,
+)
+
+sh_test(
+ name = "build_test",
+ size = "medium",
+ srcs = [
+ "build_test.sh",
+ ],
+ data = [
+ "testenv.sh",
+ ":test-deb.deb",
+ ":test-tar-.tar",
+ ":test-tar-bz2.tar.bz2",
+ ":test-tar-empty_dirs.tar",
+ ":test-tar-empty_files.tar",
+ ":test-tar-files_dict.tar",
+ ":test-tar-gz.tar.gz",
+ ":test-tar-inclusion-.tar",
+ ":test-tar-inclusion-bz2.tar",
+ ":test-tar-inclusion-gz.tar",
+ ":test-tar-inclusion-xz.tar",
+ ":test-tar-mtime.tar",
+ ":test-tar-strip_prefix-dot.tar",
+ ":test-tar-strip_prefix-empty.tar",
+ ":test-tar-strip_prefix-etc.tar",
+ ":test-tar-strip_prefix-none.tar",
+ ":test-tar-xz.tar.xz",
+ ":titi_test_all.changes",
+ ],
+ tags = [
+ # archive.py requires xzcat, which is not available by default on Mac
+ "noci",
+ # TODO(laszlocsomor): fix on Windows or describe why it cannot pass.
+ "no_windows",
+ ],
+ deps = [
+ "@rules_pkg//third_party/test/shell:bashunit",
+ ],
+)
+
+test_suite(
+ name = "windows_tests",
+ tags = [
+ "-no_windows",
+ "-slow",
+ ],
+ visibility = ["//visibility:private"],
+)
+
+test_suite(
+ name = "all_windows_tests",
+ tests = [":windows_tests"],
+)
