| commit | 179e2cbf6a441159444d7e9d6c123b5590066249 | [log] [tgz] |
|---|---|---|
| author | Tim <timfallmk@users.noreply.github.com> | Tue Nov 11 17:07:06 2025 -0800 |
| committer | GitHub <noreply@github.com> | Wed Nov 12 01:07:06 2025 +0000 |
| tree | d5ffe12227a575570151840a7ec739cfb1892488 | |
| parent | e40b6093525feee99dc47db87ee7fb3b7da3f9ed [diff] |
fix(gazelle): correct runfiles path handling in gazelle_python_manifest test (#3398) ## Summary This PR fixes the `gazelle_python_manifest.test` failure on Linux CI by correcting the runfiles path handling in both the Bazel rule definition and the Go test code. Fixes #3397 ## Problem The test was failing on Linux but passing on macOS due to inconsistent file path handling: - Used `$(rootpath)` instead of `$(rlocationpath)` in the Bazel rule - Resolved runfiles paths but then didn't use the resolved values See issue #3397 for full technical details. ## Changes ### `gazelle/manifest/defs.bzl` - Line 120: Changed `$(rootpath)` to `$(rlocationpath)` for `_TEST_MANIFEST` - Line 122: Changed `$(rootpath)` to `$(rlocationpath)` for `_TEST_REQUIREMENTS` This makes them consistent with the existing `_TEST_MANIFEST_GENERATOR_HASH` which already used `$(rlocationpath)`. ### `gazelle/manifest/test/test.go` - Line 53: Use `manifestPathResolved` instead of `manifestPath` in `manifestFile.Decode()` - Line 73: Use `requirementsPathResolved` instead of `requirementsPath` in `os.Open()` - Lines 84-86: Use `manifestPathResolved` instead of `manifestPath` in error handling The test was already calling `runfiles.Rlocation()` to resolve the paths, but then wasn't using the resolved values. ## Testing Tested on Linux by running: ```bash cd gazelle/examples/bzlmod_build_file_generation bazel test //:gazelle_python_manifest.test ``` Result: ✅ **PASSED** ## Notes - This fix aligns with Bazel's recommended runfiles handling practices - All changes follow the existing pattern used for `_TEST_MANIFEST_GENERATOR_HASH` - Some code generation was assisted by Claude AI, but the human author has reviewed, tested, and takes full responsibility for all changes per the [contribution guidelines](https://github.com/bazel-contrib/rules_python/blob/main/CONTRIBUTING.md#ai-assisted-contributions) **Disclaimer**: This is my first contribution to this project, so I'm not entirely certain this is the correct contribution method. Please let me know if any changes to the PR process are needed. Happy to make adjustments!
This repository is the home of the core Python rules -- py_library, py_binary, py_test, py_proto_library, and related symbols that provide the basis for Python support in Bazel. It also contains package installation rules for integrating with PyPI and other indices.
Documentation for rules_python is at https://rules-python.readthedocs.io and in the Bazel Build Encyclopedia.
Examples live in the examples directory.
The core rules are stable. Their implementation is subject to Bazel's backward compatibility policy. This repository aims to follow semantic versioning.
The Bazel community maintains this repository. Neither Google nor the Bazel team provides support for the code. However, this repository is part of the test suite used to vet new Bazel releases. See How to contribute page for information on our development workflow.
For detailed documentation, see https://rules-python.readthedocs.io
See Bzlmod support for more details.