feat(toolchains): default py_runtime.implementation_name to cpython (#2272)
This defaults `py_runtime.implementation_name` to `cpython`, the value
that is most likely
to be used. This is done not only because it's the most likely value,
but because of how
it affects whether precompiling works.
Within py_runtime, automatically computing `pyc_tag` requires both
`implementation_name`
and Python version information. With upcoming changes to make
`--python_version` always
set to the correct value, it'll make enabling precompiling easier,
especially if there
are custom toolchains defined.
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 7235e89..3b348e6 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -25,7 +25,8 @@
[x.x.x]: https://github.com/bazelbuild/rules_python/releases/tag/x.x.x
### Changed
-* Nothing yet
+* (toolchains) `py_runtime.implementation_name` now defaults to `cpython`
+ (previously it defaulted to None).
### Fixed
* (bzlmod) correctly wire the {attr}`pip.parse.extra_pip_args` all the
diff --git a/python/private/common/py_runtime_rule.bzl b/python/private/common/py_runtime_rule.bzl
index b339425..d944796 100644
--- a/python/private/common/py_runtime_rule.bzl
+++ b/python/private/common/py_runtime_rule.bzl
@@ -226,6 +226,7 @@
),
"implementation_name": attr.string(
doc = "The Python implementation name (`sys.implementation.name`)",
+ default = "cpython",
),
"interpreter": attr.label(
# We set `allow_files = True` to allow specifying executable
