commit | 85e50d2a4b87b6ba27bb23ce29df89efcf1cfaa6 | [log] [tgz] |
---|---|---|
author | Ted Pudlik <tpudlik@gmail.com> | Tue Nov 14 06:04:59 2023 -0800 |
committer | GitHub <noreply@github.com> | Tue Nov 14 14:04:59 2023 +0000 |
tree | 77d2fd398fc0067d49edebbed6734183133840a1 | |
parent | 793e26b0e971816e8c2e0802bed35abce471ad66 [diff] |
fix: py_proto_library: append to PYTHONPATH less (#1553) Only append the `[proto_root]` to PYTHONPATH when it's actually necessary, i.e. when the generated Python modules are under _virtual_imports. Do no append it in the general case, when `[proto_root]` is just the repository root. This makes it much less likely that adding a transitive dep on a `py_proto_library` will reorder the `PYTHONPATH`. Such reordering is undesirable because it may lead to import errors. Fixes #1551
This repository is the home of the core Python rules -- py_library
, py_binary
, py_test
, py_proto_library
, and related symbols that provide the basis for Python support in Bazel. It also contains package installation rules for integrating with PyPI and other indices.
Documentation for rules_python is at https://rules-python.readthedocs.io and in the Bazel Build Encyclopedia.
Examples live in the examples directory.
Currently, the core rules build into the Bazel binary, and the symbols in this repository are simple aliases. However, we are migrating the rules to Starlark and removing them from the Bazel binary. Therefore, the future-proof way to depend on Python rules is via this repository. SeeMigrating from the Bundled Rules
below.
The core rules are stable. Their implementation in Bazel is subject to Bazel's backward compatibility policy. Once migrated to rules_python, they may evolve at a different rate, but this repository will still follow semantic versioning.
The Bazel community maintains this repository. Neither Google nor the Bazel team provides support for the code. However, this repository is part of the test suite used to vet new Bazel releases. See How to contribute page for information on our development workflow.
For detailed documentation, see https://rules-python.readthedocs.io
See Bzlmod support for more details.