| commit | d69559de837771c8d5c72bf8aef3846e8f40b3ab | [log] [tgz] |
|---|---|---|
| author | WSUFan <fan.ye@wsu.edu> | Thu Aug 15 02:13:40 2024 -0700 |
| committer | GitHub <noreply@github.com> | Thu Aug 15 09:13:40 2024 +0000 |
| tree | b77aa5e67e9cf70ce2e139d8894c16bed3866915 | |
| parent | 4f97f1a4fcb86410e078c020397a139b1912a31b [diff] |
fix: correctly handle absolute URLs in parse_simpleapi_html.bzl (#2112)
This PR addresses a typo and improves the handling of absolute URLs in
the
`parse_simpleapi_html.bzl` file and corrects a minor issue in the
`simpleapi_download.bzl` file.
Summary:
1. parse_simpleapi_html.bzl:
- Introduced a new private function `_get_root_directory(url)` to
extract
the root directory from a given URL.
- Enhanced `_absolute_url` function to correctly handle absolute URLs by
utilizing the `_get_root_directory` function. This ensures that URLs
starting with a "/" are correctly resolved to their full path, avoiding
potential incorrect concatenation.
2. simpleapi_download.bzl: Corrected the handling of the `real_url`
variable in
the `_read_simpleapi` function, ensuring that the correct URL is passed
to
`_read_index_result` when using non-blocking downloads.
This repository is the home of the core Python rules -- py_library, py_binary, py_test, py_proto_library, and related symbols that provide the basis for Python support in Bazel. It also contains package installation rules for integrating with PyPI and other indices.
Documentation for rules_python is at https://rules-python.readthedocs.io and in the Bazel Build Encyclopedia.
Examples live in the examples directory.
The core rules are stable. Their implementation is subject to Bazel's backward compatibility policy. This repository aims to follow semantic versioning.
The Bazel community maintains this repository. Neither Google nor the Bazel team provides support for the code. However, this repository is part of the test suite used to vet new Bazel releases. See How to contribute page for information on our development workflow.
For detailed documentation, see https://rules-python.readthedocs.io
See Bzlmod support for more details.