commit d85a3925c5d32783b4ebbd652ce7acda109fa27f
author Richard Levasseur <rlevasseur@google.com> Mon Oct 07 15:03:17 2024 -0700
committer GitHub <noreply@github.com> Mon Oct 07 22:03:17 2024 +0000
tree a8fbb02a94056da4b228e7afe0fe39f1caaf9a20
parent 30fc3f99b5fa50e0dc99ef0465c0b1ae89fb9212

feat: add public API for analysis-phase logic (#2252)

This adds a public API for rules (i.e. analysis-phase code) to use code
from rules_python.
The main motivation for this is so that users can propagate PyInfo
without having to know
all the fields of PyInfo and implement the merging logic. With upcoming
PRs adding additional
fields to PyInfo, this becomes much more important.

The way the API is exposed is through a target. There are three reasons
for this:
1. It avoids loading phase costs when the implementation of the API
functions change.
Within Google, this makes changes to rules_python much cheaper and
easier to submit
and revert. This also allows us to worry less about the loading-phase
impact of
   our code.
2. Because a target can have dependencies, it allows us to hide some
details
from users. For example, if we want a flag to affect behavior, we can
add it to the
API target's attributes; users don't have to add it to their rule's
attributes
3. By having the API take the user's `ctx` as an argument, it allows us
to capture it
and use it as part of future API calls (this isn't used now, but gives
us
   flexibility in the future).

Work towards https://github.com/bazelbuild/rules_python/issues/1647